virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Parav Pandit <parav@nvidia.com>
To: <virtualization@lists.linux-foundation.org>
Cc: Eli Cohen <elic@nvidia.com>, mst@redhat.com
Subject: [PATCH linux-next 1/9] vdpa_sim: Consider read only supported features instead of current
Date: Wed, 24 Feb 2021 08:18:36 +0200	[thread overview]
Message-ID: <20210224061844.137776-2-parav@nvidia.com> (raw)
In-Reply-To: <20210224061844.137776-1-parav@nvidia.com>

To honor VIRTIO_F_VERSION_1 feature bit, during endianness detection,
consider the read only supported features bit instead of current
features bit which can be modified by the driver.

This enables vdpa_sim_net driver to invoke cpu_to_vdpasim16() early
enough just after vdpasim device creation in subsequent patch.

Signed-off-by: Parav Pandit <parav@nvidia.com>
Reviewed-by: Eli Cohen <elic@nvidia.com>
---
 drivers/vdpa/vdpa_sim/vdpa_sim.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.h b/drivers/vdpa/vdpa_sim/vdpa_sim.h
index 6d75444f9948..176d641a0939 100644
--- a/drivers/vdpa/vdpa_sim/vdpa_sim.h
+++ b/drivers/vdpa/vdpa_sim/vdpa_sim.h
@@ -11,6 +11,7 @@
 #include <linux/virtio_byteorder.h>
 #include <linux/vhost_iotlb.h>
 #include <uapi/linux/virtio_config.h>
+#include <linux/bits.h>
 
 #define VDPASIM_FEATURES	((1ULL << VIRTIO_F_ANY_LAYOUT) | \
 				 (1ULL << VIRTIO_F_VERSION_1)  | \
@@ -71,7 +72,8 @@ struct vdpasim *vdpasim_create(struct vdpasim_dev_attr *attr);
 static inline bool vdpasim_is_little_endian(struct vdpasim *vdpasim)
 {
 	return virtio_legacy_is_little_endian() ||
-		(vdpasim->features & (1ULL << VIRTIO_F_VERSION_1));
+		(vdpasim->dev_attr.supported_features &
+		 BIT_ULL(VIRTIO_F_VERSION_1));
 }
 
 static inline u16 vdpasim16_to_cpu(struct vdpasim *vdpasim, __virtio16 val)
-- 
2.26.2

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  reply	other threads:[~2021-02-24  6:19 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-24  6:18 [PATCH linux-next 0/9] vdpa: Enable user to set mac address, Parav Pandit
2021-02-24  6:18 ` Parav Pandit [this message]
2021-02-24  7:10   ` [PATCH linux-next 1/9] vdpa_sim: Consider read only supported features instead of current Michael S. Tsirkin
2021-02-26  7:36     ` Parav Pandit
2021-02-26  8:33       ` Jason Wang
2021-02-24  6:18 ` [PATCH linux-next 2/9] vdpa: Introduce query of device config layout Parav Pandit
2021-02-24  7:02   ` Michael S. Tsirkin
2021-02-24 11:18     ` Parav Pandit
2021-02-24  8:47   ` Jason Wang
2021-02-26  5:32     ` Parav Pandit
2021-02-26  8:26       ` Jason Wang
2021-02-26  8:50         ` Parav Pandit
2021-03-01  3:59           ` Jason Wang
2021-03-01  7:29             ` Parav Pandit
2021-03-01  7:50               ` Jason Wang
2021-03-01 10:28                 ` Adrian Moreno
     [not found]                   ` <abc1d3d7cd321620f6ae7f9ac0bb92fcce30a474.camel@redhat.com>
2021-03-02  4:25                     ` Jason Wang
2021-03-03  9:24                       ` Adrian Moreno
2021-02-24  6:18 ` [PATCH linux-next 3/9] vdpa: Enable user to set mac and mtu of vdpa device Parav Pandit
2021-02-24  6:18 ` [PATCH linux-next 4/9] vdpa_sim_net: Enable user to set mac address and mtu Parav Pandit
2021-02-24  6:56   ` Michael S. Tsirkin
2021-02-26  5:26     ` Parav Pandit
2021-02-24  6:18 ` [PATCH linux-next 5/9] vdpa_sim_net: Remove redundant get_config callback Parav Pandit
2021-02-24  6:18 ` [PATCH linux-next 6/9] vdpa/mlx5: Enable user to add/delete vdpa device Parav Pandit
2021-02-24  6:18 ` [PATCH linux-next 7/9] vdpa/mlx5: Provide device generated random MAC address Parav Pandit
2021-02-24  9:11   ` Jason Wang
     [not found]     ` <20210301070828.GA184680@mtl-vdi-166.wap.labs.mlnx>
2021-03-01 13:09       ` Michael S. Tsirkin
     [not found]         ` <20210301131951.GA196924@mtl-vdi-166.wap.labs.mlnx>
2021-03-01 16:12           ` Michael S. Tsirkin
2021-03-02  4:10             ` Jason Wang
     [not found]             ` <20210302053919.GB227464@mtl-vdi-166.wap.labs.mlnx>
2021-03-03  3:59               ` Parav Pandit
     [not found]                 ` <20210303063350.GA29123@mtl-vdi-166.wap.labs.mlnx>
2021-03-03  9:29                   ` Michael S. Tsirkin
2021-03-03 10:01                     ` Parav Pandit
2021-03-03  9:35                 ` Michael S. Tsirkin
2021-02-24  6:18 ` [PATCH linux-next 8/9] vdpa/mlx5: Support configuration of MAC Parav Pandit
2021-02-24  9:12   ` Jason Wang
2021-02-24  6:18 ` [PATCH linux-next 9/9] vdpa/mlx5: Forward only packets with allowed MAC address Parav Pandit
2021-02-24  9:14   ` Jason Wang
2021-02-24  6:51 ` [PATCH linux-next 0/9] vdpa: Enable user to set mac address, Michael S. Tsirkin
2021-02-24  8:02   ` Parav Pandit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210224061844.137776-2-parav@nvidia.com \
    --to=parav@nvidia.com \
    --cc=elic@nvidia.com \
    --cc=mst@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).