From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F654C433E0 for ; Fri, 12 Mar 2021 15:18:00 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD6AE64FCE for ; Fri, 12 Mar 2021 15:17:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD6AE64FCE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 8346C4ED66; Fri, 12 Mar 2021 15:17:59 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VnJFGl3MbCjt; Fri, 12 Mar 2021 15:17:58 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTP id B37804ED55; Fri, 12 Mar 2021 15:17:57 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 964ECC000B; Fri, 12 Mar 2021 15:17:57 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id DEFA9C0001 for ; Fri, 12 Mar 2021 15:17:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id C8E0184505 for ; Fri, 12 Mar 2021 15:17:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp1.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dIfBe8PT88WC for ; Fri, 12 Mar 2021 15:17:56 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by smtp1.osuosl.org (Postfix) with ESMTPS id D98EA844E9 for ; Fri, 12 Mar 2021 15:17:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615562273; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fcdXIBkMUbEAmnKNGjfKXpW1RdG7ljI/r3++0m/WhAc=; b=PDydANflYXMOHAdRqqmk/bAARI1m2OEtDREfxUb1K5d/4zu0Q3u7vsIP94nX7VG1E5m/dt XlPmzRxJzfcMNUTnbqiH37EN/epUV8AJFi+FSBErCCR5qVtZkKM2jKZ0h9QppKhKzdRxwc wv3Z1R06FfrX3p/474vYdrlA1sCBkKo= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-355-ezNGNi-SODCzlkXdttemKw-1; Fri, 12 Mar 2021 10:17:51 -0500 X-MC-Unique: ezNGNi-SODCzlkXdttemKw-1 Received: by mail-wr1-f71.google.com with SMTP id l10so11301772wry.16 for ; Fri, 12 Mar 2021 07:17:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fcdXIBkMUbEAmnKNGjfKXpW1RdG7ljI/r3++0m/WhAc=; b=CF8Qjm13t0dSIq7mndGCAMG/Q46ZVoutt+ie1qfDPd/HMzK1qmRT5bVUHyBUusyxV/ K8qWqAlA9y4AQ4RsQ0YrP9Uvr0Rz89/z20+2WnzZIyOu2bey41B9JRNU7hTib5jJP2KA h0aipE0kppTsQGO8kD7/deghFB8+J96URKgvuDMOPCPPoGfFWKhywA1L24dnEm+9sO01 qpgjVqClfWr2v34He+BYpDcuksYtz9raRgm970gIcznVdvJ9slmZYGFq5dzqGMNAwU6O 9+xE1UF+QejLFAHSc+n767LGUmSrVAGwH+JHvTQzIpQYZToaIUCldRFc+UOj87W1CmY4 pKaw== X-Gm-Message-State: AOAM533oIRJ/KvkoN33NKOAs9u3lXOe72l0+ZjXn2ZYUWhhvWi1rJOzD e74mMTOhk2BWQjcJ5EbVpdZ6gYQdeap4jC4VNPRA1DutlhMumfzX1VTIFWp/vzMcQHor/m7MTb5 tMxfI5HxFU7LPwdfMZvKPk0hdjpMIy6m85vef96YyHw== X-Received: by 2002:adf:d1ce:: with SMTP id b14mr14461779wrd.126.1615562270439; Fri, 12 Mar 2021 07:17:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJzAMx11Ovd8zZCAJGG/0+ZaRgtZy/TRxsnI0ZPXiYL7ISzBWl3fOdUyeVOdPptrSBVoQa1AVA== X-Received: by 2002:adf:d1ce:: with SMTP id b14mr14461752wrd.126.1615562270269; Fri, 12 Mar 2021 07:17:50 -0800 (PST) Received: from steredhat (host-79-34-249-199.business.telecomitalia.it. [79.34.249.199]) by smtp.gmail.com with ESMTPSA id k4sm10606172wrd.9.2021.03.12.07.17.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 07:17:49 -0800 (PST) Date: Fri, 12 Mar 2021 16:17:47 +0100 From: Stefano Garzarella To: Arseny Krasnov Subject: Re: [RFC PATCH v6 04/22] af_vsock: implement SEQPACKET receive loop Message-ID: <20210312151747.quk37sezpcwwq4id@steredhat> References: <20210307175722.3464068-1-arseny.krasnov@kaspersky.com> <20210307175948.3464885-1-arseny.krasnov@kaspersky.com> MIME-Version: 1.0 In-Reply-To: <20210307175948.3464885-1-arseny.krasnov@kaspersky.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=sgarzare@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: Andra Paraschiv , kvm@vger.kernel.org, "Michael S. Tsirkin" , netdev@vger.kernel.org, stsp2@yandex.ru, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, oxffffaa@gmail.com, Norbert Slusarek , Stefan Hajnoczi , Colin Ian King , Jakub Kicinski , "David S. Miller" , Jorgen Hansen X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Sun, Mar 07, 2021 at 08:59:45PM +0300, Arseny Krasnov wrote: >This adds receive loop for SEQPACKET. It looks like receive loop for >STREAM, but there is a little bit difference: >1) It doesn't call notify callbacks. >2) It doesn't care about 'SO_SNDLOWAT' and 'SO_RCVLOWAT' values, because > there is no sense for these values in SEQPACKET case. >3) It waits until whole record is received or error is found during > receiving. >4) It processes and sets 'MSG_TRUNC' flag. > >So to avoid extra conditions for two types of socket inside one loop, two >independent functions were created. > >Signed-off-by: Arseny Krasnov >--- > include/net/af_vsock.h | 5 +++ > net/vmw_vsock/af_vsock.c | 95 +++++++++++++++++++++++++++++++++++++++- > 2 files changed, 99 insertions(+), 1 deletion(-) > >diff --git a/include/net/af_vsock.h b/include/net/af_vsock.h >index b1c717286993..5ad7ee7f78fd 100644 >--- a/include/net/af_vsock.h >+++ b/include/net/af_vsock.h >@@ -135,6 +135,11 @@ struct vsock_transport { > bool (*stream_is_active)(struct vsock_sock *); > bool (*stream_allow)(u32 cid, u32 port); > >+ /* SEQ_PACKET. */ >+ size_t (*seqpacket_seq_get_len)(struct vsock_sock *vsk); >+ int (*seqpacket_dequeue)(struct vsock_sock *vsk, struct msghdr *msg, >+ int flags, bool *msg_ready); >+ > /* Notification. */ > int (*notify_poll_in)(struct vsock_sock *, size_t, bool *); > int (*notify_poll_out)(struct vsock_sock *, size_t, bool *); >diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c >index 0bc661e54262..ac2f69362f2e 100644 >--- a/net/vmw_vsock/af_vsock.c >+++ b/net/vmw_vsock/af_vsock.c >@@ -1973,6 +1973,96 @@ static int __vsock_stream_recvmsg(struct sock *sk, struct msghdr *msg, > return err; > } > >+static int __vsock_seqpacket_recvmsg(struct sock *sk, struct msghdr *msg, >+ size_t len, int flags) >+{ >+ const struct vsock_transport *transport; >+ const struct iovec *orig_iov; >+ unsigned long orig_nr_segs; >+ bool msg_ready; >+ struct vsock_sock *vsk; >+ size_t record_len; >+ long timeout; >+ int err = 0; >+ DEFINE_WAIT(wait); >+ >+ vsk = vsock_sk(sk); >+ transport = vsk->transport; >+ >+ timeout = sock_rcvtimeo(sk, flags & MSG_DONTWAIT); >+ orig_nr_segs = msg->msg_iter.nr_segs; >+ orig_iov = msg->msg_iter.iov; >+ msg_ready = false; >+ record_len = 0; >+ >+ while (1) { >+ err = vsock_wait_data(sk, &wait, timeout, NULL, 0); >+ >+ if (err <= 0) { >+ /* In case of any loop break(timeout, signal >+ * interrupt or shutdown), we report user that >+ * nothing was copied. >+ */ >+ err = 0; >+ break; >+ } >+ >+ if (record_len == 0) { >+ record_len = >+ transport->seqpacket_seq_get_len(vsk); >+ >+ if (record_len == 0) >+ continue; >+ } >+ >+ err = transport->seqpacket_dequeue(vsk, msg, flags, &msg_ready); In order to simplify the transport interface, can we do the work of seqpacket_seq_get_len() at the beginning of seqpacket_dequeue()? So in this way seqpacket_dequeue() can return the 'record_len' or an error. _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization