From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_RED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7336AC433E0 for ; Mon, 15 Mar 2021 11:28:42 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D7B264E61 for ; Mon, 15 Mar 2021 11:28:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D7B264E61 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id BF00983566; Mon, 15 Mar 2021 11:28:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2CJRlDM9cckq; Mon, 15 Mar 2021 11:28:41 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTP id 614CC83547; Mon, 15 Mar 2021 11:28:40 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 357B2C000A; Mon, 15 Mar 2021 11:28:40 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 50DD0C0001 for ; Mon, 15 Mar 2021 11:28:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 367C74B398 for ; Mon, 15 Mar 2021 11:28:38 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wLlpcp-RJCxA for ; Mon, 15 Mar 2021 11:28:37 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by smtp4.osuosl.org (Postfix) with ESMTPS id 4F7FD4AAEE for ; Mon, 15 Mar 2021 11:28:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615807716; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6+Ab4d7pdKrk5yb3Huo0eOHzorz4U2kFO+nloggYgTE=; b=OcUYvPCdxjkF2sc/qvdK0P4v6Pja5Sfm3ns5etFBiZeoVnPsGUpiIbSJrYU1uTvDy9Lp3x 8noaAOtJl6mW4gXstQxMX07GMX/W+VWbKZ7heSzZDtzQsZVo6X1v8KdBR3VtWt/Pyliq8P 1RJrYO4OihV/L/BFSP3iD/MxfKX5IaY= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-335-U0NMEEgvMLac-XtLuM60iw-1; Mon, 15 Mar 2021 07:28:34 -0400 X-MC-Unique: U0NMEEgvMLac-XtLuM60iw-1 Received: by mail-wr1-f69.google.com with SMTP id y5so14954658wrp.2 for ; Mon, 15 Mar 2021 04:28:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6+Ab4d7pdKrk5yb3Huo0eOHzorz4U2kFO+nloggYgTE=; b=r/VqGFcKGx1TesE8/bvLVZ2B70YUcF8UMK4xpU5bx3l373hy5uP6AqOiRoe9GGAQVY iATSStYol/cRK8KTYcQRS9jbbyacu9crrV6rC/a1ufMxg1dTcz2/2SWhcBUaRP46MOhM VpImtGR1MJ96ejvxHqvU4j/3KcgZaSylEpcPqi+176YFp8QiYoq26CqLO6NwjynVPIty l62x8ienp6FkqElLcgY0CjwFiQRxqlF31rary9kzKX2NFcEbKHcBecpmrKBFHAJ1Mega SIKvBqV7uULjbVUnp5DJCJYSo/MOn0EdZJEkvCq82TK/NvvTTMwVs+4ark1nHiyILQGL 1ytg== X-Gm-Message-State: AOAM532R5VfVIETgB9BvJKyz4tbvhavZsQdcIkq5/nuVsLQm6qgRhDy8 NTDGvxsHLDEtzq4p75WLvX3yAs9r/xyt8SLOfKEnDTQvOx0U6UkwSpSHQvVNaMjzllmSEH5oAon EkcV6j+S4lMwXsqtw7KBMPvYdrII/Z9zEUk2P/qSqeA== X-Received: by 2002:a1c:f30a:: with SMTP id q10mr26369007wmq.159.1615807713328; Mon, 15 Mar 2021 04:28:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxB7EBmQowN5naQMkVQx5KsUpgIu5+ZOQSWr7rwjRrAdNKAoaTOGMg/KcI/Bgs8opSa6gMvzg== X-Received: by 2002:a1c:f30a:: with SMTP id q10mr26368990wmq.159.1615807713161; Mon, 15 Mar 2021 04:28:33 -0700 (PDT) Received: from steredhat (host-79-34-249-199.business.telecomitalia.it. [79.34.249.199]) by smtp.gmail.com with ESMTPSA id 1sm12342744wmj.2.2021.03.15.04.28.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Mar 2021 04:28:32 -0700 (PDT) Date: Mon, 15 Mar 2021 12:28:30 +0100 From: Stefano Garzarella To: Arseny Krasnov Subject: Re: [RFC PATCH v6 16/22] vhost/vsock: SEQPACKET feature bit support Message-ID: <20210315112830.3yqqjnqcgym2sdpg@steredhat> References: <20210307175722.3464068-1-arseny.krasnov@kaspersky.com> <20210307180344.3466469-1-arseny.krasnov@kaspersky.com> MIME-Version: 1.0 In-Reply-To: <20210307180344.3466469-1-arseny.krasnov@kaspersky.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=sgarzare@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: Andra Paraschiv , kvm@vger.kernel.org, "Michael S. Tsirkin" , netdev@vger.kernel.org, stsp2@yandex.ru, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, oxffffaa@gmail.com, Norbert Slusarek , Stefan Hajnoczi , Colin Ian King , Jakub Kicinski , "David S. Miller" , Jorgen Hansen X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Sun, Mar 07, 2021 at 09:03:41PM +0300, Arseny Krasnov wrote: >This adds handling of SEQPACKET bit: if guest sets features with >this bit cleared, then SOCK_SEQPACKET support will be disabled. > >Signed-off-by: Arseny Krasnov >--- > drivers/vhost/vsock.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) I think is better to move this patch after we set the seqpackets ops, so we are really able to handle SEQPACKET traffic. > >diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c >index 5e78fb719602..3b0a50e6de12 100644 >--- a/drivers/vhost/vsock.c >+++ b/drivers/vhost/vsock.c >@@ -31,7 +31,8 @@ > > enum { > VHOST_VSOCK_FEATURES = VHOST_FEATURES | >- (1ULL << VIRTIO_F_ACCESS_PLATFORM) >+ (1ULL << VIRTIO_F_ACCESS_PLATFORM) | >+ (1ULL << VIRTIO_VSOCK_F_SEQPACKET) > }; > > enum { >@@ -785,6 +786,9 @@ static int vhost_vsock_set_features(struct vhost_vsock *vsock, u64 features) > goto err; > } > >+ if (features & (1ULL << VIRTIO_VSOCK_F_SEQPACKET)) >+ vhost_transport.seqpacket_allow = true; >+ > for (i = 0; i < ARRAY_SIZE(vsock->vqs); i++) { > vq = &vsock->vqs[i]; > mutex_lock(&vq->mutex); >-- >2.25.1 > _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization