From: Christoph Hellwig <hch@infradead.org>
To: Yongji Xie <xieyongji@bytedance.com>
Cc: Jens Axboe <axboe@kernel.dk>, Jonathan Corbet <corbet@lwn.net>,
kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
netdev@vger.kernel.org, Randy Dunlap <rdunlap@infradead.org>,
Matthew Wilcox <willy@infradead.org>,
virtualization@lists.linux-foundation.org,
Christoph Hellwig <hch@infradead.org>,
Bob Liu <bob.liu@oracle.com>,
bcrl@kvack.org, viro@zeniv.linux.org.uk,
Stefan Hajnoczi <stefanha@redhat.com>,
linux-fsdevel@vger.kernel.org,
Dan Carpenter <dan.carpenter@oracle.com>,
Mika Penttil?? <mika.penttila@nextfour.com>
Subject: Re: [PATCH v5 01/11] file: Export __receive_fd() to modules
Date: Thu, 25 Mar 2021 08:23:52 +0000 [thread overview]
Message-ID: <20210325082352.GA2988009@infradead.org> (raw)
In-Reply-To: <CACycT3vrHOExXj6v8ULvUzdLcRkdzS5=TNK6=g4+RWEdN-nOJw@mail.gmail.com>
On Mon, Mar 15, 2021 at 05:46:43PM +0800, Yongji Xie wrote:
> On Mon, Mar 15, 2021 at 5:08 PM Christoph Hellwig <hch@infradead.org> wrote:
> >
> > On Mon, Mar 15, 2021 at 01:37:11PM +0800, Xie Yongji wrote:
> > > Export __receive_fd() so that some modules can use
> > > it to pass file descriptor between processes.
> >
> > I really don't think any non-core code should do that, especilly not
> > modular mere driver code.
>
> Do you see any issue? Now I think we're able to do that with the help
> of get_unused_fd_flags() and fd_install() in modules. But we may miss
> some security stuff in this way. So I try to export __receive_fd() and
> use it instead.
The real problem is now what helper to use, but rather that random
drivers should not just mess with the FD table like that.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-03-25 8:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210315053721.189-1-xieyongji@bytedance.com>
[not found] ` <20210315053721.189-2-xieyongji@bytedance.com>
2021-03-15 9:08 ` [PATCH v5 01/11] file: Export __receive_fd() to modules Christoph Hellwig
[not found] ` <CACycT3vrHOExXj6v8ULvUzdLcRkdzS5=TNK6=g4+RWEdN-nOJw@mail.gmail.com>
2021-03-25 8:23 ` Christoph Hellwig [this message]
[not found] ` <20210315053721.189-7-xieyongji@bytedance.com>
2021-03-23 3:09 ` [PATCH v5 06/11] vdpa: factor out vhost_vdpa_pa_map() Jason Wang
[not found] ` <20210315053721.189-8-xieyongji@bytedance.com>
2021-03-23 3:13 ` [PATCH v5 07/11] vdpa: Support transferring virtual addressing during DMA mapping Jason Wang
[not found] ` <20210315053721.189-9-xieyongji@bytedance.com>
2021-03-24 3:54 ` [PATCH v5 08/11] vduse: Implement an MMU-based IOMMU driver Jason Wang
[not found] ` <CACycT3v_-G6ju-poofXEzYt8QPKWNFHwsS7t=KTLgs-=g+iPQQ@mail.gmail.com>
2021-03-25 4:52 ` Jason Wang
[not found] ` <CACycT3uS870yy04rw7KBk==sioi+VNunxVz6BQH-Lmxk6m-VSg@mail.gmail.com>
2021-03-26 4:26 ` Jason Wang
[not found] ` <CACycT3v6Lj61fafztOuzBNFLs2TbKeqrNLXkzv5RK6-h-iTnvA@mail.gmail.com>
2021-03-26 6:16 ` Jason Wang
[not found] ` <CACycT3t+2MC9rQ7iWdWQ4=O3ojCXHvHZ-M7y7AjXoXYZUiAOzQ@mail.gmail.com>
2021-03-26 7:36 ` Jason Wang
[not found] ` <20210315053721.189-10-xieyongji@bytedance.com>
2021-03-24 4:43 ` [PATCH v5 09/11] vduse: Introduce VDUSE - vDPA Device in Userspace Jason Wang
[not found] ` <CACycT3u5hEO8=JVkbHmKXYMManiZ1VedyS6O+7M8Rzbk1ftC7A@mail.gmail.com>
2021-03-25 6:30 ` Jason Wang
[not found] ` <20210315053721.189-11-xieyongji@bytedance.com>
2021-03-24 4:45 ` [PATCH v5 10/11] vduse: Add config interrupt support Jason Wang
[not found] ` <20210315053721.189-4-xieyongji@bytedance.com>
2021-03-23 3:02 ` [PATCH v5 03/11] vhost-vdpa: protect concurrent access to vhost device iotlb Jason Wang
2021-03-25 11:08 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210325082352.GA2988009@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=bcrl@kvack.org \
--cc=bob.liu@oracle.com \
--cc=corbet@lwn.net \
--cc=dan.carpenter@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mika.penttila@nextfour.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=stefanha@redhat.com \
--cc=viro@zeniv.linux.org.uk \
--cc=virtualization@lists.linux-foundation.org \
--cc=willy@infradead.org \
--cc=xieyongji@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).