* Re: [PATCH v2] virtio_blk: Add support for lifetime feature
[not found] <20210416194709.155497-1-egranata@google.com>
@ 2021-04-20 7:01 ` Christoph Hellwig
2021-04-20 10:08 ` Michael S. Tsirkin
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2021-04-20 7:01 UTC (permalink / raw)
To: Enrico Granata
Cc: axboe, mst, linux-kernel, virtualization, linux-block, stefanha,
pbonzini
Just to despit my 2 cents again: I think the way this is specified
in the virtio spec is actively harmful and we should not suport it in
Linux.
If others override me we at least need to require a detailed
documentation of these fields as the virto spec does not provide it.
Please also do not add pointless over 80 character lines, and follow
the one value per sysfs file rule.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] virtio_blk: Add support for lifetime feature
2021-04-20 7:01 ` [PATCH v2] virtio_blk: Add support for lifetime feature Christoph Hellwig
@ 2021-04-20 10:08 ` Michael S. Tsirkin
2021-04-20 16:41 ` Cornelia Huck
0 siblings, 1 reply; 3+ messages in thread
From: Michael S. Tsirkin @ 2021-04-20 10:08 UTC (permalink / raw)
To: Christoph Hellwig
Cc: axboe, linux-kernel, virtualization, linux-block, stefanha,
pbonzini, Enrico Granata
On Tue, Apr 20, 2021 at 08:01:29AM +0100, Christoph Hellwig wrote:
> Just to despit my 2 cents again: I think the way this is specified
> in the virtio spec is actively harmful and we should not suport it in
> Linux.
>
> If others override me we at least need to require a detailed
> documentation of these fields as the virto spec does not provide it.
>
> Please also do not add pointless over 80 character lines, and follow
> the one value per sysfs file rule.
Enrico would you like to raise the issues with the virtio TC
for resolution?
--
MST
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] virtio_blk: Add support for lifetime feature
2021-04-20 10:08 ` Michael S. Tsirkin
@ 2021-04-20 16:41 ` Cornelia Huck
0 siblings, 0 replies; 3+ messages in thread
From: Cornelia Huck @ 2021-04-20 16:41 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: axboe, linux-block, linux-kernel, virtualization,
Christoph Hellwig, stefanha, pbonzini, Enrico Granata
On Tue, 20 Apr 2021 06:08:29 -0400
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Tue, Apr 20, 2021 at 08:01:29AM +0100, Christoph Hellwig wrote:
> > Just to despit my 2 cents again: I think the way this is specified
> > in the virtio spec is actively harmful and we should not suport it in
> > Linux.
> >
> > If others override me we at least need to require a detailed
> > documentation of these fields as the virto spec does not provide it.
> >
> > Please also do not add pointless over 80 character lines, and follow
> > the one value per sysfs file rule.
>
> Enrico would you like to raise the issues with the virtio TC
> for resolution?
>
FWIW, I've opened https://github.com/oasis-tcs/virtio-spec/issues/106
to track this.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-20 16:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20210416194709.155497-1-egranata@google.com>
2021-04-20 7:01 ` [PATCH v2] virtio_blk: Add support for lifetime feature Christoph Hellwig
2021-04-20 10:08 ` Michael S. Tsirkin
2021-04-20 16:41 ` Cornelia Huck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).