* Re: [PATCH] virtio_ring: boolean values to a bool variable [not found] <1610704825-17724-1-git-send-email-abaci-bugfix@linux.alibaba.com> @ 2021-01-18 2:57 ` Jason Wang 2021-05-03 8:17 ` Michael S. Tsirkin 0 siblings, 1 reply; 2+ messages in thread From: Jason Wang @ 2021-01-18 2:57 UTC (permalink / raw) To: Jiapeng Zhong, mst; +Cc: linux-kernel, virtualization On 2021/1/15 下午6:00, Jiapeng Zhong wrote: > Fix the following coccicheck warnings: > > ./drivers/virtio/virtio_ring.c:1637:1-29: WARNING: Assignment of > 0/1 to bool variable. > > ./drivers/virtio/virtio_ring.c:1636:1-30: WARNING: Assignment of > 0/1 to bool variable. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com> It looks to me it's not the only places: git grep avail_wrap_counter drivers/virtio/virtio_ring.c: bool avail_wrap_counter; drivers/virtio/virtio_ring.c: vq->packed.avail_wrap_counter ^= 1; drivers/virtio/virtio_ring.c: vq->packed.avail_wrap_counter ^= 1; drivers/virtio/virtio_ring.c: if (wrap_counter != vq->packed.avail_wrap_counter) drivers/virtio/virtio_ring.c: vq->packed.avail_wrap_counter = 1; Thanks > --- > drivers/virtio/virtio_ring.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c > index 71e16b5..5adb361 100644 > --- a/drivers/virtio/virtio_ring.c > +++ b/drivers/virtio/virtio_ring.c > @@ -1633,8 +1633,8 @@ static struct virtqueue *vring_create_virtqueue_packed( > vq->packed.vring.device = device; > > vq->packed.next_avail_idx = 0; > - vq->packed.avail_wrap_counter = 1; > - vq->packed.used_wrap_counter = 1; > + vq->packed.avail_wrap_counter = true; > + vq->packed.used_wrap_counter = true; > vq->packed.event_flags_shadow = 0; > vq->packed.avail_used_flags = 1 << VRING_PACKED_DESC_F_AVAIL; > _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] virtio_ring: boolean values to a bool variable 2021-01-18 2:57 ` [PATCH] virtio_ring: boolean values to a bool variable Jason Wang @ 2021-05-03 8:17 ` Michael S. Tsirkin 0 siblings, 0 replies; 2+ messages in thread From: Michael S. Tsirkin @ 2021-05-03 8:17 UTC (permalink / raw) To: Jason Wang; +Cc: virtualization, linux-kernel, Jiapeng Zhong On Mon, Jan 18, 2021 at 10:57:03AM +0800, Jason Wang wrote: > > On 2021/1/15 下午6:00, Jiapeng Zhong wrote: > > Fix the following coccicheck warnings: > > > > ./drivers/virtio/virtio_ring.c:1637:1-29: WARNING: Assignment of > > 0/1 to bool variable. > > > > ./drivers/virtio/virtio_ring.c:1636:1-30: WARNING: Assignment of > > 0/1 to bool variable. > > > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > > Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com> > > > It looks to me it's not the only places: > > git grep avail_wrap_counter > drivers/virtio/virtio_ring.c: bool avail_wrap_counter; > drivers/virtio/virtio_ring.c: vq->packed.avail_wrap_counter ^= 1; > drivers/virtio/virtio_ring.c: vq->packed.avail_wrap_counter ^= 1; > drivers/virtio/virtio_ring.c: if (wrap_counter != > vq->packed.avail_wrap_counter) > drivers/virtio/virtio_ring.c: vq->packed.avail_wrap_counter = 1; > > Thanks Agreed if we are doing this let's change them all. > > > --- > > drivers/virtio/virtio_ring.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c > > index 71e16b5..5adb361 100644 > > --- a/drivers/virtio/virtio_ring.c > > +++ b/drivers/virtio/virtio_ring.c > > @@ -1633,8 +1633,8 @@ static struct virtqueue *vring_create_virtqueue_packed( > > vq->packed.vring.device = device; > > vq->packed.next_avail_idx = 0; > > - vq->packed.avail_wrap_counter = 1; > > - vq->packed.used_wrap_counter = 1; > > + vq->packed.avail_wrap_counter = true; > > + vq->packed.used_wrap_counter = true; > > vq->packed.event_flags_shadow = 0; > > vq->packed.avail_used_flags = 1 << VRING_PACKED_DESC_F_AVAIL; _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-03 8:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1610704825-17724-1-git-send-email-abaci-bugfix@linux.alibaba.com>
2021-01-18 2:57 ` [PATCH] virtio_ring: boolean values to a bool variable Jason Wang
2021-05-03 8:17 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).