From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B74C6C433ED for ; Thu, 13 May 2021 11:42:34 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 321C16143D for ; Thu, 13 May 2021 11:42:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 321C16143D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id CF35360885; Thu, 13 May 2021 11:42:33 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ch5FVUtfHzOw; Thu, 13 May 2021 11:42:25 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp3.osuosl.org (Postfix) with ESMTP id 5151460816; Thu, 13 May 2021 11:42:25 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1FBF2C000E; Thu, 13 May 2021 11:42:25 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3D8F1C0001 for ; Thu, 13 May 2021 11:42:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 2B7DE403A9 for ; Thu, 13 May 2021 11:42:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8mQe_1jEMhzB for ; Thu, 13 May 2021 11:42:22 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp2.osuosl.org (Postfix) with ESMTPS id F186C401C3 for ; Thu, 13 May 2021 11:42:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620906140; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=R+xpriwoqMR4hMxYIDQ9tzTIIOzNsv7iGskqwPCMAtI=; b=OI27jo8NIxgomqRr60ykXGsCjDHgwrGm6G0QX0rLYa7GqsbaWTFZBEyG2DSoBKKFUH4mDT fvl90ygMZEZH9fjAwXot8JUE1E6HdyYmdmBLyfdu+kELMjMPqK3XRN965emRnKKApcYXaR wsT+QkA80iJTLKt3zc29VpCMlHUYNCo= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-2-Ks-D3Y3kM4mA9VQhhNyFmw-1; Thu, 13 May 2021 07:42:18 -0400 X-MC-Unique: Ks-D3Y3kM4mA9VQhhNyFmw-1 Received: by mail-ed1-f69.google.com with SMTP id i19-20020a05640242d3b0290388cea34ed3so14467927edc.15 for ; Thu, 13 May 2021 04:42:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=R+xpriwoqMR4hMxYIDQ9tzTIIOzNsv7iGskqwPCMAtI=; b=THBOIAugmxhhaxDXUJgchUjeh9xQ3dazB0CmDafCTgbFvR7aT5bye7jIn9Cnd/mXpX Ce3Dl12M9TtDpkKB8GOIA5l/lcBJvmv8x77jNry0MMiasom0Z9Aggjcel9SOQFe/4dLC LJ/divnlDrRp9Vqxy+dGpOqYUg6n6+nl0DBqwP1TSFI0PsU1Y9UUrechjqzOFfesYgWh gRKo6RpaP39X+j3bS4wq7xiKYICG23RXI/1fxbN28Hgy0o/B9XHiJumfwNvvU5xz3CyJ JohsHjKSWh0f/Ej9xqXDFL1QulYnsW9xfozmHygYEbfA5WYxIYCXfxlA5qdFkE9lvm6g iaiA== X-Gm-Message-State: AOAM531q7qBbCabMXBE4oHgClku8moHtZH4nssjuGgze8yEtdCqg2S8q pnY6M9xZmoRVJwCMR2gSrHzLJ/30X2Np5Dy9TQjz4t+q86xjZ5TYg6ws5Z4w2Fm39uq6Cp/6N0D N2SmWsxy5aJeq+9rxuwbV0s3MWhd7i8zNhe07ZWbn/g== X-Received: by 2002:a17:906:11d5:: with SMTP id o21mr39425180eja.176.1620906137651; Thu, 13 May 2021 04:42:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy4evvrqMGAM5r4UR85o5vJGUe4V1rA7BD2JGHOAS51E0jB0311f1ua3YMBd6FJgtBjiTezpQ== X-Received: by 2002:a17:906:11d5:: with SMTP id o21mr39425159eja.176.1620906137418; Thu, 13 May 2021 04:42:17 -0700 (PDT) Received: from steredhat (host-79-18-148-79.retail.telecomitalia.it. [79.18.148.79]) by smtp.gmail.com with ESMTPSA id q25sm1704765ejd.9.2021.05.13.04.42.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 04:42:17 -0700 (PDT) Date: Thu, 13 May 2021 13:42:14 +0200 From: Stefano Garzarella To: Arseny Krasnov Subject: Re: [RFC PATCH v9 06/19] af_vsock: rest of SEQPACKET support Message-ID: <20210513114214.66mfm76tp65af5yq@steredhat> References: <20210508163027.3430238-1-arseny.krasnov@kaspersky.com> <20210508163350.3431361-1-arseny.krasnov@kaspersky.com> MIME-Version: 1.0 In-Reply-To: <20210508163350.3431361-1-arseny.krasnov@kaspersky.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=sgarzare@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: Andra Paraschiv , kvm@vger.kernel.org, "Michael S. Tsirkin" , netdev@vger.kernel.org, stsp2@yandex.ru, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, oxffffaa@gmail.com, Norbert Slusarek , Stefan Hajnoczi , Colin Ian King , Jakub Kicinski , "David S. Miller" , Jorgen Hansen X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Sat, May 08, 2021 at 07:33:46PM +0300, Arseny Krasnov wrote: >This does rest of SOCK_SEQPACKET support: >1) Adds socket ops for SEQPACKET type. >2) Allows to create socket with SEQPACKET type. > >Signed-off-by: Arseny Krasnov >Reviewed-by: Stefano Garzarella This patch is changed, so usually you should remove the R-b tags. >--- > include/net/af_vsock.h | 1 + > net/vmw_vsock/af_vsock.c | 36 +++++++++++++++++++++++++++++++++++- > 2 files changed, 36 insertions(+), 1 deletion(-) > >diff --git a/include/net/af_vsock.h b/include/net/af_vsock.h >index 5860027d5173..1747c0b564ef 100644 >--- a/include/net/af_vsock.h >+++ b/include/net/af_vsock.h >@@ -140,6 +140,7 @@ struct vsock_transport { > int flags, bool *msg_ready); > int (*seqpacket_enqueue)(struct vsock_sock *vsk, struct msghdr *msg, > size_t len); >+ bool (*seqpacket_allow)(u32 remote_cid); I'm thinking if it's better to follow .dgram_allow() and .stream_allow(), specifying also the `port` param, but since it's not used, we can add later if needed. So, I think this is fine: Reviewed-by: Stefano Garzarella _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization