From: "Michael S. Tsirkin" <mst@redhat.com>
To: Eli Cohen <elic@nvidia.com>
Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 1/2] vdpa/mlx5: Fix umem sizes assignments on VQ create
Date: Sun, 30 May 2021 04:19:01 -0400 [thread overview]
Message-ID: <20210530041624-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20210530081536.GA119906@mtl-vdi-166.wap.labs.mlnx>
On Sun, May 30, 2021 at 11:15:36AM +0300, Eli Cohen wrote:
> On Sun, May 30, 2021 at 04:05:16AM -0400, Michael S. Tsirkin wrote:
> > On Sun, May 30, 2021 at 09:31:28AM +0300, Eli Cohen wrote:
> > > Fix copy paste bug assigning umem1 size to umem2 and umem3.
> > >
> > > Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices")
> > > Signed-off-by: Eli Cohen <elic@nvidia.com>
> >
> > could you clarify the impact of the bug please?
> >
>
> I leads to firmware failure to create the virtqueue resource when you
> try to use a 1:1 mapping MR. This kind of usage is presented in the
> virtio_vdpa support I sent earlier.
OK pls include this info in the commit log. And is 1:1 the only case where
sizes differ? Is it true that in other cases sizes are all the same?
> > > ---
> > > drivers/vdpa/mlx5/net/mlx5_vnet.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > index 189e4385df40..53312f0460ad 100644
> > > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > @@ -828,9 +828,9 @@ static int create_virtqueue(struct mlx5_vdpa_net *ndev, struct mlx5_vdpa_virtque
> > > MLX5_SET(virtio_q, vq_ctx, umem_1_id, mvq->umem1.id);
> > > MLX5_SET(virtio_q, vq_ctx, umem_1_size, mvq->umem1.size);
> > > MLX5_SET(virtio_q, vq_ctx, umem_2_id, mvq->umem2.id);
> > > - MLX5_SET(virtio_q, vq_ctx, umem_2_size, mvq->umem1.size);
> > > + MLX5_SET(virtio_q, vq_ctx, umem_2_size, mvq->umem2.size);
> > > MLX5_SET(virtio_q, vq_ctx, umem_3_id, mvq->umem3.id);
> > > - MLX5_SET(virtio_q, vq_ctx, umem_3_size, mvq->umem1.size);
> > > + MLX5_SET(virtio_q, vq_ctx, umem_3_size, mvq->umem3.size);
> > > MLX5_SET(virtio_q, vq_ctx, pd, ndev->mvdev.res.pdn);
> > > if (MLX5_CAP_DEV_VDPA_EMULATION(ndev->mvdev.mdev, eth_frame_offload_type))
> > > MLX5_SET(virtio_q, vq_ctx, virtio_version_1_0, 1);
> > > --
> > > 2.31.1
> >
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-05-30 8:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210530063128.183258-1-elic@nvidia.com>
2021-05-30 8:05 ` [PATCH 1/2] vdpa/mlx5: Fix umem sizes assignments on VQ create Michael S. Tsirkin
[not found] ` <20210530081536.GA119906@mtl-vdi-166.wap.labs.mlnx>
2021-05-30 8:19 ` Michael S. Tsirkin [this message]
[not found] ` <20210530082646.GA120333@mtl-vdi-166.wap.labs.mlnx>
2021-05-30 8:36 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210530041624-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=elic@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).