From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D104C47082 for ; Tue, 8 Jun 2021 05:39:19 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D5146127A for ; Tue, 8 Jun 2021 05:39:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D5146127A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 3CAAE60726; Tue, 8 Jun 2021 05:39:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5NxkCOYe-LhH; Tue, 8 Jun 2021 05:39:14 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp3.osuosl.org (Postfix) with ESMTP id CEDA360769; Tue, 8 Jun 2021 05:39:13 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id B28D9C000D; Tue, 8 Jun 2021 05:39:13 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id C0453C0001 for ; Tue, 8 Jun 2021 05:39:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id BB7698308D for ; Tue, 8 Jun 2021 05:39:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vfQ_H-F5daYP for ; Tue, 8 Jun 2021 05:39:12 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by smtp1.osuosl.org (Postfix) with ESMTPS id CA97583096 for ; Tue, 8 Jun 2021 05:39:11 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 2EEDF67373; Tue, 8 Jun 2021 07:39:06 +0200 (CEST) Date: Tue, 8 Jun 2021 07:39:05 +0200 From: Christoph Hellwig To: Chaitanya Kulkarni Subject: Re: [PATCH 20/30] nullb: use blk_mq_alloc_disk Message-ID: <20210608053905.GA14183@lst.de> References: <20210602065345.355274-1-hch@lst.de> <20210602065345.355274-21-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Cc: Justin Sanders , Vignesh Raghavendra , Mike Snitzer , "Michael S. Tsirkin" , "virtualization@lists.linux-foundation.org" , "dm-devel@redhat.com" , "Md. Haris Iqbal" , Miquel Raynal , Jack Wang , Christoph Hellwig , Tim Waugh , "linux-s390@vger.kernel.org" , Maxim Levitsky , Richard Weinberger , Christian Borntraeger , "xen-devel@lists.xenproject.org" , Ilya Dryomov , Vasily Gorbik , Alex Dubov , Konrad Rzeszutek Wilk , Heiko Carstens , Josef Bacik , Denis Efremov , "nbd@other.debian.org" , "linux-block@vger.kernel.org" , "ceph-devel@vger.kernel.org" , Jens Axboe , Geoff Levand , "linux-mmc@vger.kernel.org" , "linux-mtd@lists.infradead.org" , "linuxppc-dev@lists.ozlabs.org" , Roger Pau =?iso-8859-1?Q?Monn=E9?= X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Thu, Jun 03, 2021 at 12:10:09AM +0000, Chaitanya Kulkarni wrote: > > diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c > > index d8e098f1e5b5..74fb2ec63219 100644 > > --- a/drivers/block/null_blk/main.c > > +++ b/drivers/block/null_blk/main.c > > @@ -1851,13 +1851,12 @@ static int null_add_dev(struct nullb_device *dev) > > > > rv = -ENOMEM; > > Is above initialization needed ? It isn't strictly required any more. _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization