From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 552BAC49361 for ; Fri, 18 Jun 2021 12:38:25 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C643661369 for ; Fri, 18 Jun 2021 12:38:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C643661369 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 722696060F; Fri, 18 Jun 2021 12:38:24 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id maoi5Tohb3gJ; Fri, 18 Jun 2021 12:38:23 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id 2B290605CC; Fri, 18 Jun 2021 12:38:23 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id E3DB0C000D; Fri, 18 Jun 2021 12:38:22 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 02BA5C000B for ; Fri, 18 Jun 2021 12:38:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id DBA6D415A4 for ; Fri, 18 Jun 2021 12:38:20 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Fi6OMAkTP_t1 for ; Fri, 18 Jun 2021 12:38:20 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by smtp4.osuosl.org (Postfix) with ESMTPS id F32864159E for ; Fri, 18 Jun 2021 12:38:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624019898; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8BPRFSs4ZDIzsU3WeQFolZqPnT6BylD3v05yUAKiC4I=; b=AhGKUxu0ffCzsgG696WX6ysaRLgQLrcEvATcClIZeJux4zPSEWmvIJpjaas+dGZjyV7CKl bic6oY7Q0fGtFR8dn06zUzvt9dJZMlUEuOwrWbIzYgemy5+AUvjxTfEjo+6ULZaI28MGDq 5MyFIoBtbBnLPlNnpQMwLMAn2BDZjC0= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-555-EXKasVjCPNa7aYAR72SfJw-1; Fri, 18 Jun 2021 08:38:17 -0400 X-MC-Unique: EXKasVjCPNa7aYAR72SfJw-1 Received: by mail-wm1-f71.google.com with SMTP id z62-20020a1c65410000b0290179bd585ef9so946372wmb.7 for ; Fri, 18 Jun 2021 05:38:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8BPRFSs4ZDIzsU3WeQFolZqPnT6BylD3v05yUAKiC4I=; b=sb3jQvE9JMlSdrgO1NmnekRNxl/hFCB4RnW37E4CLvohhOkPg+JH+vBbsHbMcxHQ/d R2xe12LzgoqgKWVaA5/7g5izgIJX8lerbsNH/7mGgcMD01AtUZ31dyZbVsT+YpLNJaut DVjMSMkOtkSuombfw8qhjywu9OE3zh56GQqVLiuLNQ1+cAp2PlnxL1+0Jm61Q7eEhAZv 6Si5nyvQEj4OoHV4DNFiBhRALoIa7IwdoHl6krvcCYABLXSH7q+atxF0RCiwefeA6FQ+ 5oadgCooXInoWSlT3vOJHAZ1zeWJIQJM4wm/SA8K/PLMYH9yl7MwoM5yh6E3npUWUzMe FLSA== X-Gm-Message-State: AOAM533cbSg47MZgn74FVUlilIivVTefmGyYdPdRC3qpBr2Q6EDYHdnR NW4ml520P5K7rUK+1UU70u2DwjKhRbJpan50iGZs03hGG4xnPdLDeRWF9j1mg4FplCBmQvWC6hO UMNPk8WtqNmRXt9Yy+ujVWSxFvkZdohEljFsZJuuDqg== X-Received: by 2002:a5d:5983:: with SMTP id n3mr12218319wri.241.1624019896285; Fri, 18 Jun 2021 05:38:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy6buMSygSMET2HRRFto0utYr5pHmbiCUKzswQXXbWqPi3keYL8lMRIvXzbPyrGGaftLze7cQ== X-Received: by 2002:a5d:5983:: with SMTP id n3mr12218290wri.241.1624019896020; Fri, 18 Jun 2021 05:38:16 -0700 (PDT) Received: from redhat.com ([77.126.22.11]) by smtp.gmail.com with ESMTPSA id b71sm2236262wmb.2.2021.06.18.05.38.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Jun 2021 05:38:14 -0700 (PDT) Date: Fri, 18 Jun 2021 08:38:10 -0400 From: "Michael S. Tsirkin" To: Keiichi Watanabe Subject: Re: [PATCH] virtio_net: Enable MSI-X vector for ctrl queue Message-ID: <20210618083650-mutt-send-email-mst@kernel.org> References: <20210618072625.957837-1-keiichiw@chromium.org> MIME-Version: 1.0 In-Reply-To: <20210618072625.957837-1-keiichiw@chromium.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: chirantan@chromium.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, "David S . Miller" X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Fri, Jun 18, 2021 at 04:26:25PM +0900, Keiichi Watanabe wrote: > When we use vhost-user backend on the host, MSI-X vector should be set > so that the vmm can get an irq FD and send it to the backend device > process with vhost-user protocol. > Since whether the vector is set for a queue is determined depending on > the queue has a callback, this commit sets an empty callback for > virtio-net's control queue. > > Signed-off-by: Keiichi Watanabe I'm confused by this explanation. If the vmm wants to get an interrupt it can do so - why change the guest driver? > --- > drivers/net/virtio_net.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index 11f722460513..002e3695d4b3 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -2696,6 +2696,11 @@ static void virtnet_del_vqs(struct virtnet_info *vi) > virtnet_free_queues(vi); > } > > +static void virtnet_ctrlq_done(struct virtqueue *rvq) > +{ > + /* Do nothing */ > +} > + > /* How large should a single buffer be so a queue full of these can fit at > * least one full packet? > * Logic below assumes the mergeable buffer header is used. > @@ -2748,7 +2753,7 @@ static int virtnet_find_vqs(struct virtnet_info *vi) > > /* Parameters for control virtqueue, if any */ > if (vi->has_cvq) { > - callbacks[total_vqs - 1] = NULL; > + callbacks[total_vqs - 1] = virtnet_ctrlq_done; > names[total_vqs - 1] = "control"; > } > > -- > 2.32.0.288.g62a8d224e6-goog _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization