From: Dan Carpenter <dan.carpenter@oracle.com>
To: Xie Yongji <xieyongji@bytedance.com>
Cc: kvm@vger.kernel.org, mst@redhat.com,
virtualization@lists.linux-foundation.org,
christian.brauner@canonical.com, corbet@lwn.net, joro@8bytes.org,
willy@infradead.org, hch@infradead.org, xiaodong.liu@intel.com,
viro@zeniv.linux.org.uk, stefanha@redhat.com,
songmuchun@bytedance.com, axboe@kernel.dk, zhe.he@windriver.com,
gregkh@linuxfoundation.org, rdunlap@infradead.org,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
bcrl@kvack.org, netdev@vger.kernel.org,
linux-fsdevel@vger.kernel.org, mika.penttila@nextfour.com
Subject: Re: [PATCH v9 07/17] virtio: Don't set FAILED status bit on device index allocation failure
Date: Tue, 13 Jul 2021 14:02:11 +0300 [thread overview]
Message-ID: <20210713110211.GK1954@kadam> (raw)
In-Reply-To: <20210713084656.232-8-xieyongji@bytedance.com>
On Tue, Jul 13, 2021 at 04:46:46PM +0800, Xie Yongji wrote:
> We don't need to set FAILED status bit on device index allocation
> failure since the device initialization hasn't been started yet.
The commit message should say what the effect of this change is to the
user. Is this a bugfix? Will it have any effect on runtime at all?
To me, hearing your thoughts on this is valuable even if you have to
guess. "I noticed this mistake during review and I don't think it will
affect runtime."
regards,
dan carpenter
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next parent reply other threads:[~2021-07-13 11:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210713084656.232-1-xieyongji@bytedance.com>
[not found] ` <20210713084656.232-8-xieyongji@bytedance.com>
2021-07-13 11:02 ` Dan Carpenter [this message]
[not found] ` <20210713084656.232-14-xieyongji@bytedance.com>
2021-07-13 11:31 ` [PATCH v9 13/17] vdpa: factor out vhost_vdpa_pa_map() and vhost_vdpa_pa_unmap() Dan Carpenter
2021-07-14 2:14 ` Jason Wang
2021-07-14 8:05 ` Dan Carpenter
2021-07-14 9:41 ` Jason Wang
2021-07-14 9:57 ` Dan Carpenter
2021-07-15 2:20 ` Jason Wang
[not found] ` <20210713084656.232-17-xieyongji@bytedance.com>
2021-07-13 13:27 ` [PATCH v9 16/17] vduse: Introduce VDUSE - vDPA Device in Userspace Dan Carpenter
2021-07-14 2:54 ` Jason Wang
2021-07-14 5:45 ` Jason Wang
2021-07-14 5:54 ` Michael S. Tsirkin
2021-07-14 6:02 ` Jason Wang
2021-07-14 6:47 ` Greg KH
2021-07-14 8:56 ` Jason Wang
[not found] ` <CACycT3uh+wUeDM1H7JiCJTMeCVCBngURGKeXD-h+meekNNwiQw@mail.gmail.com>
2021-07-14 9:12 ` Jason Wang
[not found] ` <CACycT3vTyR=+6xOJyXCu_bGAKcz4Fx3bA25WfdBjhxJ6MOvLzw@mail.gmail.com>
2021-07-15 5:00 ` Jason Wang
[not found] ` <20210713084656.232-4-xieyongji@bytedance.com>
2021-07-14 4:20 ` [PATCH v9 03/17] vdpa: Fix code indentation Joe Perches
[not found] ` <20210713084656.232-18-xieyongji@bytedance.com>
2021-07-15 5:18 ` [PATCH v9 17/17] Documentation: Add documentation for VDUSE Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210713110211.GK1954@kadam \
--to=dan.carpenter@oracle.com \
--cc=axboe@kernel.dk \
--cc=bcrl@kvack.org \
--cc=christian.brauner@canonical.com \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.penttila@nextfour.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=songmuchun@bytedance.com \
--cc=stefanha@redhat.com \
--cc=viro@zeniv.linux.org.uk \
--cc=virtualization@lists.linux-foundation.org \
--cc=willy@infradead.org \
--cc=xiaodong.liu@intel.com \
--cc=xieyongji@bytedance.com \
--cc=zhe.he@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).