From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 1/4] virtio: Improve vq->broken access to avoid any compiler optimization
Date: Sat, 17 Jul 2021 16:38:41 -0400 [thread overview]
Message-ID: <20210717163319-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20210717074258.1463313-2-parav@nvidia.com>
On Sat, Jul 17, 2021 at 10:42:55AM +0300, Parav Pandit wrote:
> Currently vq->broken field is read by virtqueue_is_broken() in busy
> loop in one context by virtnet_send_command().
>
> vq->broken is set to true in other process context by
> virtio_break_device(). Reader and writer are accessing it without any
> synchronization. This may lead to a compiler optimization which may
> result to optimize reading vq->broken only once.
>
> Hence, force reading vq->broken on each invocation of
> virtqueue_is_broken() and ensure that its update is visible.
>
> Fixes: e2dcdfe95c0b ("virtio: virtio_break_device() to mark all virtqueues broken.")
This is all theoretical right?
virtqueue_get_buf is not inlined so compiler generally
assumes any vq field can change.
I'm inclined to not include a Fixes
tag then. And please do change subject to say "theoretical"
to make that clear to people.
> Signed-off-by: Parav Pandit <parav@nvidia.com>
> ---
> drivers/virtio/virtio_ring.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
> index 89bfe46a8a7f..7f379fe7d78d 100644
> --- a/drivers/virtio/virtio_ring.c
> +++ b/drivers/virtio/virtio_ring.c
> @@ -2373,7 +2373,7 @@ bool virtqueue_is_broken(struct virtqueue *_vq)
> {
> struct vring_virtqueue *vq = to_vvq(_vq);
>
> - return vq->broken;
> + return READ_ONCE(vq->broken);
> }
> EXPORT_SYMBOL_GPL(virtqueue_is_broken);
>
> @@ -2387,7 +2387,9 @@ void virtio_break_device(struct virtio_device *dev)
>
> list_for_each_entry(_vq, &dev->vqs, list) {
> struct vring_virtqueue *vq = to_vvq(_vq);
> - vq->broken = true;
> +
> + /* Pairs with READ_ONCE() in virtqueue_is_broken(). */
> + smp_store_release(&vq->broken, true);
A bit puzzled here. Why do we need release semantics here?
IUC store_release does not generally pair with READ_ONCE - does it?
The commit log does not describe this either.
> }
> }
> EXPORT_SYMBOL_GPL(virtio_break_device);
> --
> 2.27.0
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-07-17 20:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-17 7:42 [PATCH 0/4] virtio short improvements Parav Pandit via Virtualization
2021-07-17 7:42 ` [PATCH 1/4] virtio: Improve vq->broken access to avoid any compiler optimization Parav Pandit via Virtualization
2021-07-17 20:38 ` Michael S. Tsirkin [this message]
2021-07-19 5:26 ` Parav Pandit via Virtualization
2021-07-19 12:04 ` Michael S. Tsirkin
2021-07-19 14:20 ` Parav Pandit via Virtualization
2021-07-17 7:42 ` [PATCH 2/4] virtio: Keep vring_del_virtqueue() mirror of VQ create Parav Pandit via Virtualization
2021-07-17 7:42 ` [PATCH 3/4] virtio: Protect vqs list access Parav Pandit via Virtualization
2021-07-17 20:41 ` Michael S. Tsirkin
2021-07-19 5:37 ` Parav Pandit via Virtualization
2021-07-17 7:42 ` [PATCH 4/4] virtio_pci: Support surprise removal of virtio pci device Parav Pandit via Virtualization
2021-07-17 20:46 ` Michael S. Tsirkin
2021-07-19 5:44 ` Parav Pandit via Virtualization
2021-07-19 12:07 ` Michael S. Tsirkin
2021-07-19 14:15 ` Parav Pandit via Virtualization
2021-07-19 9:40 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210717163319-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=parav@nvidia.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).