Re: PROBLEM: virtio_net LRO kernel panics

From: "Michael S. Tsirkin" <mst@redhat.com>
To: Ivan <ivan@prestigetransportation.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	virtualization@lists.linux-foundation.org,
	Willem de Bruijn <willemb@google.com>
Subject: Re: PROBLEM: virtio_net LRO kernel panics
Date: Fri, 23 Jul 2021 04:13:33 -0400	[thread overview]
Message-ID: <20210723041248-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CACFia2fWhWKMGF3g8SfU++2-jQ1rCKtCJo3h08KmhGfMTuZaQQ@mail.gmail.com>

On Fri, Jul 23, 2021 at 03:06:04AM -0500, Ivan wrote:
> On Fri, Jul 23, 2021 at 2:59 AM Michael S. Tsirkin <mst@redhat.com> wrote:
> >
> > On Thu, Jul 22, 2021 at 11:50:11PM -0500, Ivan wrote:
> > > On Thu, Jul 22, 2021 at 11:25 PM Jason Wang <jasowang@redhat.com> wrote:
> > > > 在 2021/7/23 上午10:54, Ivan 写道:
> > > > > On Thu, Jul 22, 2021 at 9:37 PM Jason Wang <jasowang@redhat.com> wrote:
> > > > >> Does it work if you turn off lro before enabling the forwarding?
> > > > > 0 root@NuRaid:~# ethtool -K eth0 lro off
> > > > > Actual changes:
> > > > > rx-lro: on [requested off]
> > > > > Could not change any device features
> > > >
> > > > Ok, it looks like the device misses the VIRTIO_NET_F_CTRL_GUEST_OFFLOADS
> > > > which makes it impossible to change the LRO setting.
> > > >
> > > > Did you use qemu? If yes, what's the qemu version you've used?
> > >
> > > These are VirtualBox machines, which I've been using for years with
> > > longterm kernels 4.19, and I never had such a problem.  But now that I
> > > tried upgrading to kernels 5.10 or 5.13 -- the panics started.  These
> > > are just generic kernel builds, and a minimalistic userspace.
> >
> > I would be useful to see the features your virtualbox instance provides
> >
> > cat /sys/class/net/eth0/device/features
> 
> # cat /sys/class/net/eth0/device/features
> 1100010110111011111100000000000000000000000000000000000000000000

So if I'm not wrong:

1#define VIRTIO_NET_F_CSUM      0       /* Host handles pkts w/ partial csum */
1#define VIRTIO_NET_F_GUEST_CSUM        1       /* Guest handles pkts w/ partial csum */
0#define VIRTIO_NET_F_CTRL_GUEST_OFFLOADS 2 /* Dynamic offload configuration. */
0#define VIRTIO_NET_F_MTU       3       /* Initial MTU advice */
0
1#define VIRTIO_NET_F_MAC       5       /* Host has given MAC address. */
0
1#define VIRTIO_NET_F_GUEST_TSO4        7       /* Guest can handle TSOv4 in. */
1#define VIRTIO_NET_F_GUEST_TSO6        8       /* Guest can handle TSOv6 in. */
0#define VIRTIO_NET_F_GUEST_ECN 9       /* Guest can handle TSO[6] w/ ECN in. */
1#define VIRTIO_NET_F_GUEST_UFO 10      /* Guest can handle UFO in. */
1#define VIRTIO_NET_F_HOST_TSO4 11      /* Host can handle TSOv4 in. */
1#define VIRTIO_NET_F_HOST_TSO6 12      /* Host can handle TSOv6 in. */
0#define VIRTIO_NET_F_HOST_ECN  13      /* Host can handle TSO[6] w/ ECN in. */
1#define VIRTIO_NET_F_HOST_UFO  14      /* Host can handle UFO in. */
1#define VIRTIO_NET_F_MRG_RXBUF 15      /* Host can merge receive buffers. */
1#define VIRTIO_NET_F_STATUS    16      /* virtio_net_config.status available */
1#define VIRTIO_NET_F_CTRL_VQ   17      /* Control channel available */
1#define VIRTIO_NET_F_CTRL_RX   18      /* Control channel RX mode support */
1#define VIRTIO_NET_F_CTRL_VLAN 19      /* Control channel VLAN filtering */

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization