virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH 0/3] vdpa/mlx5: Add Control VQ and MAC and Multi queue support
       [not found] <20210809080043.169701-1-elic@nvidia.com>
@ 2021-08-09  9:35 ` Michael S. Tsirkin
       [not found]   ` <20210809094803.GA217441@mtl-vdi-166.wap.labs.mlnx>
  0 siblings, 1 reply; 3+ messages in thread
From: Michael S. Tsirkin @ 2021-08-09  9:35 UTC (permalink / raw)
  To: Eli Cohen; +Cc: eperezma, virtualization

On Mon, Aug 09, 2021 at 11:00:40AM +0300, Eli Cohen wrote:
> Hi Michael,
> 
> First patch is just a cleaup.
> Second patch adds control virtqueue support for mlx5_vdpa and handle MAC
> configutations through the control VQ.
> Third patch adds multi queue support for mlx5_vdpa accepting
> configurations from the control VQ.

Threading broken again :(

> Eli Cohen (3):
>   vdpa/mlx5: Remove redundant header file inclusion
>   vdpa/mlx5: Add support for control VQ and MAC setting
>   vdpa/mlx5: Add multiqueue support
> 
>  drivers/vdpa/mlx5/core/mlx5_vdpa.h |  25 +-
>  drivers/vdpa/mlx5/core/mr.c        |  87 ++++--
>  drivers/vdpa/mlx5/core/resources.c |  41 +++
>  drivers/vdpa/mlx5/net/mlx5_vnet.c  | 471 +++++++++++++++++++++++++----
>  4 files changed, 549 insertions(+), 75 deletions(-)
> 
> -- 
> 2.31.1

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 0/3] vdpa/mlx5: Add Control VQ and MAC and Multi queue support
       [not found]   ` <20210809094803.GA217441@mtl-vdi-166.wap.labs.mlnx>
@ 2021-08-09  9:50     ` Michael S. Tsirkin
       [not found]       ` <20210809095950.GA217852@mtl-vdi-166.wap.labs.mlnx>
  0 siblings, 1 reply; 3+ messages in thread
From: Michael S. Tsirkin @ 2021-08-09  9:50 UTC (permalink / raw)
  To: Eli Cohen; +Cc: eperezma, virtualization

On Mon, Aug 09, 2021 at 12:48:03PM +0300, Eli Cohen wrote:
> On Mon, Aug 09, 2021 at 05:35:49AM -0400, Michael S. Tsirkin wrote:
> > On Mon, Aug 09, 2021 at 11:00:40AM +0300, Eli Cohen wrote:
> > > Hi Michael,
> > > 
> > > First patch is just a cleaup.
> > > Second patch adds control virtqueue support for mlx5_vdpa and handle MAC
> > > configutations through the control VQ.
> > > Third patch adds multi queue support for mlx5_vdpa accepting
> > > configurations from the control VQ.
> > 
> > Threading broken again :(
> 
> My mail client failed after sending the first two patches so I sent the
> other two as distinct emails. I assume it is realted but how can you see
> that threading is broken?

Patches 2 and 3 do not have In-Reply-To or References headers.

Patch 1 does:

In-Reply-To: <20210809080043.169701-1-elic@nvidia.com>
References: <20210809080043.169701-1-elic@nvidia.com>

One way to fix the setup is using git-send-email.



> > 
> > > Eli Cohen (3):
> > >   vdpa/mlx5: Remove redundant header file inclusion
> > >   vdpa/mlx5: Add support for control VQ and MAC setting
> > >   vdpa/mlx5: Add multiqueue support
> > > 
> > >  drivers/vdpa/mlx5/core/mlx5_vdpa.h |  25 +-
> > >  drivers/vdpa/mlx5/core/mr.c        |  87 ++++--
> > >  drivers/vdpa/mlx5/core/resources.c |  41 +++
> > >  drivers/vdpa/mlx5/net/mlx5_vnet.c  | 471 +++++++++++++++++++++++++----
> > >  4 files changed, 549 insertions(+), 75 deletions(-)
> > > 
> > > -- 
> > > 2.31.1
> > 

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 0/3] vdpa/mlx5: Add Control VQ and MAC and Multi queue support
       [not found]       ` <20210809095950.GA217852@mtl-vdi-166.wap.labs.mlnx>
@ 2021-08-10 14:32         ` Michael S. Tsirkin
  0 siblings, 0 replies; 3+ messages in thread
From: Michael S. Tsirkin @ 2021-08-10 14:32 UTC (permalink / raw)
  To: Eli Cohen; +Cc: eperezma, virtualization

On Mon, Aug 09, 2021 at 12:59:50PM +0300, Eli Cohen wrote:
> On Mon, Aug 09, 2021 at 05:50:02AM -0400, Michael S. Tsirkin wrote:
> > On Mon, Aug 09, 2021 at 12:48:03PM +0300, Eli Cohen wrote:
> > > On Mon, Aug 09, 2021 at 05:35:49AM -0400, Michael S. Tsirkin wrote:
> > > > On Mon, Aug 09, 2021 at 11:00:40AM +0300, Eli Cohen wrote:
> > > > > Hi Michael,
> > > > > 
> > > > > First patch is just a cleaup.
> > > > > Second patch adds control virtqueue support for mlx5_vdpa and handle MAC
> > > > > configutations through the control VQ.
> > > > > Third patch adds multi queue support for mlx5_vdpa accepting
> > > > > configurations from the control VQ.
> > > > 
> > > > Threading broken again :(
> > > 
> > > My mail client failed after sending the first two patches so I sent the
> > > other two as distinct emails. I assume it is realted but how can you see
> > > that threading is broken?
> > 
> > Patches 2 and 3 do not have In-Reply-To or References headers.
> > 
> > Patch 1 does:
> > 
> > In-Reply-To: <20210809080043.169701-1-elic@nvidia.com>
> > References: <20210809080043.169701-1-elic@nvidia.com>
> > 
> > One way to fix the setup is using git-send-email.
> > 
> 
> I did use git-send-email and here's what I got:
> 
> ...
> Result: 250
> (mbox) Adding cc: Eli Cohen <elic@nvidia.com> from line 'From: Eli Cohen
> <elic@nvidia.com>'
> (body) Adding cc: Eli Cohen <elic@nvidia.com> from line 'Signed-off-by:
> Eli Cohen <elic@nvidia.com>'
> 4.3.1 Insufficient system resources

That's your server's response.

> 
> Maybe it was a temporary problem. I will resend. Should I put v1 on it?

v1 is implicit.  Either v2 or "resend" in the prefix.

> > 
> > 
> > > > 
> > > > > Eli Cohen (3):
> > > > >   vdpa/mlx5: Remove redundant header file inclusion
> > > > >   vdpa/mlx5: Add support for control VQ and MAC setting
> > > > >   vdpa/mlx5: Add multiqueue support
> > > > > 
> > > > >  drivers/vdpa/mlx5/core/mlx5_vdpa.h |  25 +-
> > > > >  drivers/vdpa/mlx5/core/mr.c        |  87 ++++--
> > > > >  drivers/vdpa/mlx5/core/resources.c |  41 +++
> > > > >  drivers/vdpa/mlx5/net/mlx5_vnet.c  | 471 +++++++++++++++++++++++++----
> > > > >  4 files changed, 549 insertions(+), 75 deletions(-)
> > > > > 
> > > > > -- 
> > > > > 2.31.1
> > > > 
> > 

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-08-10 14:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20210809080043.169701-1-elic@nvidia.com>
2021-08-09  9:35 ` [PATCH 0/3] vdpa/mlx5: Add Control VQ and MAC and Multi queue support Michael S. Tsirkin
     [not found]   ` <20210809094803.GA217441@mtl-vdi-166.wap.labs.mlnx>
2021-08-09  9:50     ` Michael S. Tsirkin
     [not found]       ` <20210809095950.GA217852@mtl-vdi-166.wap.labs.mlnx>
2021-08-10 14:32         ` Michael S. Tsirkin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).