From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: willemb@google.com, netdev@vger.kernel.org,
ivan@prestigetransportation.com, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, edumazet@google.com,
Jakub Kicinski <kuba@kernel.org>,
davem@davemloft.net
Subject: Re: [RFC PATCH] virtio-net: use NETIF_F_GRO_HW instead of NETIF_F_LRO
Date: Thu, 12 Aug 2021 00:50:03 -0400 [thread overview]
Message-ID: <20210812004655-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <aa3e2aca-05a9-aed7-59ec-eb4bd32d8f76@redhat.com>
On Thu, Aug 12, 2021 at 11:23:04AM +0800, Jason Wang wrote:
>
> 在 2021/8/12 上午6:17, Jakub Kicinski 写道:
> > On Wed, 11 Aug 2021 16:16:23 +0800 Jason Wang wrote:
> > > Try to fix this by using NETIF_F_GRO_HW instead so we're not
> > > guaranteed to be re-segmented as original.
> > This sentence may need rephrasing.
>
>
> Right, actually, I meant:
>
>
> Try to fix this by using NETIF_F_GRO_HW instead. But we're not sure the
> packet could be re-segmented to the exact original packet stream. Since it's
> really depends on the bakcend implementation.
>
>
> >
> > > Or we may want a new netdev
> > > feature like RX_GSO since the guest offloads for virtio-net is
> > > actually to receive GSO packet.
> > >
> > > Or we can try not advertise LRO is control guest offloads is not
> > > enabled. This solves the warning but will still slow down the traffic.
> > IMO gro-hw fits pretty well, patch looks good.
>
>
> If the re-segmentation is not a issue. I will post a formal patch.
>
> Thanks
It is but the point is even though spec did not require this
we always allowed these configurations
in the past so hopefully most of them are not broken and combine
packets in the same way as GRO. Let's not break them all
in an attempt to catch bad configs, and meanwhile amend
the spec to recommend doing GW GRO.
>
> >
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-08-12 4:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 8:16 [RFC PATCH] virtio-net: use NETIF_F_GRO_HW instead of NETIF_F_LRO Jason Wang
[not found] ` <20210811151754.030a22a7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
2021-08-12 3:23 ` Jason Wang
2021-08-12 4:50 ` Michael S. Tsirkin [this message]
2021-08-12 6:18 ` Jason Wang
[not found] ` <CACFia2dOarWzZ-FfOgA-n3Puxhw4zacdEPtabzbbveyeuV3YBA@mail.gmail.com>
2021-08-12 4:59 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210812004655-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ivan@prestigetransportation.com \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).