From: "Michael S. Tsirkin" <mst@redhat.com>
To: Li RongQing <lirongqing@baidu.com>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio_net: reduce raw_smp_processor_id() calling in virtnet_xdp_get_sq
Date: Mon, 30 Aug 2021 17:10:13 -0400 [thread overview]
Message-ID: <20210830170837-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1629966095-16341-1-git-send-email-lirongqing@baidu.com>
On Thu, Aug 26, 2021 at 04:21:35PM +0800, Li RongQing wrote:
> smp_processor_id()/raw* will be called once each when not
> more queues in virtnet_xdp_get_sq() which is called in
> non-preemptible context, so it's safe to call the function
> smp_processor_id() once.
>
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
commit log should probably explain why it's a good idea
to replace raw_smp_processor_id with smp_processor_id
in the case of curr_queue_pairs <= nr_cpu_ids.
> ---
> drivers/net/virtio_net.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 2e42210a6503..2a7b368c1da2 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -528,19 +528,20 @@ static int __virtnet_xdp_xmit_one(struct virtnet_info *vi,
> * functions to perfectly solve these three problems at the same time.
> */
> #define virtnet_xdp_get_sq(vi) ({ \
> + int cpu = smp_processor_id(); \
> struct netdev_queue *txq; \
> typeof(vi) v = (vi); \
> unsigned int qp; \
> \
> if (v->curr_queue_pairs > nr_cpu_ids) { \
> qp = v->curr_queue_pairs - v->xdp_queue_pairs; \
> - qp += smp_processor_id(); \
> + qp += cpu; \
> txq = netdev_get_tx_queue(v->dev, qp); \
> __netif_tx_acquire(txq); \
> } else { \
> - qp = smp_processor_id() % v->curr_queue_pairs; \
> + qp = cpu % v->curr_queue_pairs; \
> txq = netdev_get_tx_queue(v->dev, qp); \
> - __netif_tx_lock(txq, raw_smp_processor_id()); \
> + __netif_tx_lock(txq, cpu); \
> } \
> v->sq + qp; \
> })
> --
> 2.33.0.69.gc420321.dirty
>
>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next parent reply other threads:[~2021-08-30 21:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1629966095-16341-1-git-send-email-lirongqing@baidu.com>
2021-08-30 21:10 ` Michael S. Tsirkin [this message]
[not found] ` <bbf978c3252b4f2ea13ab7ca07d53034@baidu.com>
2021-08-31 14:33 ` 答复: [PATCH] virtio_net: reduce raw_smp_processor_id() calling in virtnet_xdp_get_sq Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210830170837-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=bpf@vger.kernel.org \
--cc=lirongqing@baidu.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).