* Re: [PATCH 1/1] virtio-blk: remove unneeded "likely" statements [not found] <20210830120111.22661-1-mgurtovoy@nvidia.com> @ 2021-09-02 15:00 ` Stefan Hajnoczi [not found] ` <6800aad7-038a-b251-4ad5-3dc005b0a8a1@nvidia.com> 0 siblings, 1 reply; 2+ messages in thread From: Stefan Hajnoczi @ 2021-09-02 15:00 UTC (permalink / raw) To: Max Gurtovoy; +Cc: axboe, kvm, mst, virtualization, linux-block, oren [-- Attachment #1.1: Type: text/plain, Size: 706 bytes --] On Mon, Aug 30, 2021 at 03:01:11PM +0300, Max Gurtovoy wrote: > Usually we use "likely/unlikely" to optimize the fast path. Remove > redundant "likely" statements in the control path to ease on the code. > > Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com> > --- > drivers/block/virtio_blk.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) It would be nice to tweak the commit description before merging this. I had trouble parsing the second sentence. If I understand correctly the purpose of this patch is to make the code simpler and easier to read: s/ease on the code/simplify the code and make it easier to read/ Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 183 bytes --] _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization ^ permalink raw reply [flat|nested] 2+ messages in thread
[parent not found: <6800aad7-038a-b251-4ad5-3dc005b0a8a1@nvidia.com>]
* Re: [PATCH 1/1] virtio-blk: remove unneeded "likely" statements [not found] ` <6800aad7-038a-b251-4ad5-3dc005b0a8a1@nvidia.com> @ 2021-09-03 9:04 ` Michael S. Tsirkin 0 siblings, 0 replies; 2+ messages in thread From: Michael S. Tsirkin @ 2021-09-03 9:04 UTC (permalink / raw) To: Max Gurtovoy Cc: axboe, kvm, virtualization, linux-block, Stefan Hajnoczi, oren On Thu, Sep 02, 2021 at 10:13:04PM +0300, Max Gurtovoy wrote: > > On 9/2/2021 6:00 PM, Stefan Hajnoczi wrote: > > On Mon, Aug 30, 2021 at 03:01:11PM +0300, Max Gurtovoy wrote: > > > Usually we use "likely/unlikely" to optimize the fast path. Remove > > > redundant "likely" statements in the control path to ease on the code. > > > > > > Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com> > > > --- > > > drivers/block/virtio_blk.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > It would be nice to tweak the commit description before merging this. I > > had trouble parsing the second sentence. If I understand correctly the > > purpose of this patch is to make the code simpler and easier to read: > > > > s/ease on the code/simplify the code and make it easier to read/ > > I'm ok with this change in commit message. > > MST, > > can you apply this change if you'll pick this commit ? > > -Max. Just repost with a fixed commit log pls, easier for me. Thanks! > > > > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-03 9:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20210830120111.22661-1-mgurtovoy@nvidia.com>
2021-09-02 15:00 ` [PATCH 1/1] virtio-blk: remove unneeded "likely" statements Stefan Hajnoczi
[not found] ` <6800aad7-038a-b251-4ad5-3dc005b0a8a1@nvidia.com>
2021-09-03 9:04 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).