From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C72A8C433EF for ; Sat, 4 Sep 2021 20:02:08 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 681C6600D4 for ; Sat, 4 Sep 2021 20:02:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 681C6600D4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 1EF8C40171; Sat, 4 Sep 2021 20:02:08 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9pU_ZjLTQEZ5; Sat, 4 Sep 2021 20:02:06 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp2.osuosl.org (Postfix) with ESMTPS id C3CD940167; Sat, 4 Sep 2021 20:02:05 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 97AC5C0010; Sat, 4 Sep 2021 20:02:05 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 26C1DC000E for ; Sat, 4 Sep 2021 20:02:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id DEF0E60753 for ; Sat, 4 Sep 2021 20:02:03 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SP4pmWZgKQAb for ; Sat, 4 Sep 2021 20:02:02 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp3.osuosl.org (Postfix) with ESMTPS id 48D066071E for ; Sat, 4 Sep 2021 20:02:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630785721; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bxNG1ngO4HwoCYP87SmRIj56CKEkRg8j1xnpIh/b4qo=; b=MYHgiuWGg0QoLSUygQScSqxBjss6LSWYCWaeB27ysuhRG3hlGKB/fpisyB9GPV+Tsc86at 6PAC6hbUeYoGce/gG7H5p1dyel21Wocxte8YmjupESl6QDO+28n4k54Ry+ZzeDpG1HMTTB Yx3iNIAGeLcRe+KoU1bdElrjkhzeaEg= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-18-hiDK_1SQNS2WlFdxXLMbKg-1; Sat, 04 Sep 2021 16:01:58 -0400 X-MC-Unique: hiDK_1SQNS2WlFdxXLMbKg-1 Received: by mail-ej1-f69.google.com with SMTP id 22-20020a170906301600b005ca77a21183so821570ejz.20 for ; Sat, 04 Sep 2021 13:01:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bxNG1ngO4HwoCYP87SmRIj56CKEkRg8j1xnpIh/b4qo=; b=Okoql9s4qjshBdD1cjdVjmg+AK94d4rm0YCTxlutKekOZx4kY99DDmAJhmQo15cr+3 /tE9NtZOGSH5xsFNTypsEqdS2rGhRqarQ9NIH1QRqrJO3hVhf9ADK4vwHDORyw0BWrkT yZabNk/fIsX8UK4q5TT8Fm3j5IVIzad8t3V1HVjWMvRVYwvErKaVnfsXU1t0YuTlzjTd Netxwkd4GzTHiueU288+bHu+T+SImguaIK2R8189IdU/pA83XYKcplPHlfilDFItlouz ovulQvNgPAD87xBVXTbBnhMSXABnQQ1RaKaVCHXMwVJg10l0bbWcFrqTUK8CoCuvFb5t 2JLA== X-Gm-Message-State: AOAM531iWmaILaaTq+68CwpQ0vAKCh8UW83lX6ae2wCuftxUOaCs9KMQ +b6RMxaII7JI5HbpYtkFRFlIFjmAW8l5CFCcsM7KxFb4cAuNYOUhWimlp37RCwfPp4uTgzn8k+Z ZE598aUK4YGU4327kqlH0Xzs6Ez5N1m8opIjpaIQhCQ== X-Received: by 2002:a17:906:8469:: with SMTP id hx9mr5590894ejc.455.1630785716820; Sat, 04 Sep 2021 13:01:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz/IFl/77KsCBo8tiU8poez8TfDJqeFRwnwqTvDUW/SzQ4YMbBpp78Z5/B+MMeAzidIlEvy3Q== X-Received: by 2002:a17:906:8469:: with SMTP id hx9mr5590859ejc.455.1630785716512; Sat, 04 Sep 2021 13:01:56 -0700 (PDT) Received: from redhat.com ([2.55.150.176]) by smtp.gmail.com with ESMTPSA id n13sm1454084ejk.97.2021.09.04.13.01.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Sep 2021 13:01:55 -0700 (PDT) Date: Sat, 4 Sep 2021 16:01:51 -0400 From: "Michael S. Tsirkin" To: Jie Deng Subject: Re: [PATCH v14] i2c: virtio: add a virtio i2c frontend driver Message-ID: <20210904160059-mutt-send-email-mst@kernel.org> References: <984ebecaf697058eb73389ed14ead9dd6d38fb53.1625796246.git.jie.deng@intel.com> MIME-Version: 1.0 In-Reply-To: <984ebecaf697058eb73389ed14ead9dd6d38fb53.1625796246.git.jie.deng@intel.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: yu1.wang@intel.com, arnd@arndb.de, gregkh@linuxfoundation.org, viresh.kumar@linaro.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, wsa@kernel.org, wsa+renesas@sang-engineering.com, linux-i2c@vger.kernel.org, stefanha@redhat.com, shuo.a.liu@intel.com, andriy.shevchenko@linux.intel.com, conghui.chen@intel.com X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Fri, Jul 09, 2021 at 10:25:30AM +0800, Jie Deng wrote: > Add an I2C bus driver for virtio para-virtualization. > > The controller can be emulated by the backend driver in > any device model software by following the virtio protocol. > > The device specification can be found on > https://lists.oasis-open.org/archives/virtio-comment/202101/msg00008.html. > > By following the specification, people may implement different > backend drivers to emulate different controllers according to > their needs. > > Co-developed-by: Conghui Chen > Signed-off-by: Conghui Chen > Signed-off-by: Jie Deng Same as with qemu bits, I am confused as to what is the status of proposed spec changes and whether the driver will work with them. Let's let the dust settle on them then, then resubmit? > --- > Changes v13 -> v14 > - Put the headers in virtio_i2c.h in alphabetical order. > - Dropped I2C_FUNC_SMBUS_QUICK support. > - Dropped few unnecessary variables and checks. > - Use "num" everywhere instead of num or nr, to be consistent. > - Added few comments which make the design more clear. > > Changes v12 -> v13 > - Use _BITUL() instead of BIT(). > - Rename "virtio_i2c_send_reqs" to "virtio_i2c_prepare_reqs". > - Optimize the return value of "virtio_i2c_complete_reqs". > > Changes v11 -> v12 > - Do not sent msg_buf for zero-length request. > - Send requests to host only if all the number of transfers requested prepared successfully. > - Remove the line #include in virtio_i2c.h. > > Changes v10 -> v11 > - Remove vi->adap.class = I2C_CLASS_DEPRECATED. > - Use #ifdef CONFIG_PM_SLEEP to replace the "__maybe_unused". > - Remove "struct mutex lock" in "struct virtio_i2c". > - Support zero-length request. > - Remove unnecessary logs. > - Remove vi->adap.timeout = HZ / 10, just use the default value. > - Use BIT(0) to define VIRTIO_I2C_FLAGS_FAIL_NEXT. > - Add the virtio_device index to adapter's naming mechanism. > > drivers/i2c/busses/Kconfig | 11 ++ > drivers/i2c/busses/Makefile | 3 + > drivers/i2c/busses/i2c-virtio.c | 285 ++++++++++++++++++++++++++++++++++++++++ > include/uapi/linux/virtio_i2c.h | 41 ++++++ > include/uapi/linux/virtio_ids.h | 1 + > 5 files changed, 341 insertions(+) > create mode 100644 drivers/i2c/busses/i2c-virtio.c > create mode 100644 include/uapi/linux/virtio_i2c.h > > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > index 10acece..e47616a 100644 > --- a/drivers/i2c/busses/Kconfig > +++ b/drivers/i2c/busses/Kconfig > @@ -21,6 +21,17 @@ config I2C_ALI1535 > This driver can also be built as a module. If so, the module > will be called i2c-ali1535. > > +config I2C_VIRTIO > + tristate "Virtio I2C Adapter" > + select VIRTIO > + help > + If you say yes to this option, support will be included for the virtio > + I2C adapter driver. The hardware can be emulated by any device model > + software according to the virtio protocol. > + > + This driver can also be built as a module. If so, the module > + will be called i2c-virtio. > + > config I2C_ALI1563 > tristate "ALI 1563" > depends on PCI > diff --git a/drivers/i2c/busses/Makefile b/drivers/i2c/busses/Makefile > index 69e9963..9843756 100644 > --- a/drivers/i2c/busses/Makefile > +++ b/drivers/i2c/busses/Makefile > @@ -147,4 +147,7 @@ obj-$(CONFIG_I2C_XGENE_SLIMPRO) += i2c-xgene-slimpro.o > obj-$(CONFIG_SCx200_ACB) += scx200_acb.o > obj-$(CONFIG_I2C_FSI) += i2c-fsi.o > > +# VIRTIO I2C host controller driver > +obj-$(CONFIG_I2C_VIRTIO) += i2c-virtio.o > + > ccflags-$(CONFIG_I2C_DEBUG_BUS) := -DDEBUG > diff --git a/drivers/i2c/busses/i2c-virtio.c b/drivers/i2c/busses/i2c-virtio.c > new file mode 100644 > index 0000000..0139cdc > --- /dev/null > +++ b/drivers/i2c/busses/i2c-virtio.c > @@ -0,0 +1,285 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > +/* > + * Virtio I2C Bus Driver > + * > + * The Virtio I2C Specification: > + * https://raw.githubusercontent.com/oasis-tcs/virtio-spec/master/virtio-i2c.tex > + * > + * Copyright (c) 2021 Intel Corporation. All rights reserved. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +/** > + * struct virtio_i2c - virtio I2C data > + * @vdev: virtio device for this controller > + * @completion: completion of virtio I2C message > + * @adap: I2C adapter for this controller > + * @vq: the virtio virtqueue for communication > + */ > +struct virtio_i2c { > + struct virtio_device *vdev; > + struct completion completion; > + struct i2c_adapter adap; > + struct virtqueue *vq; > +}; > + > +/** > + * struct virtio_i2c_req - the virtio I2C request structure > + * @out_hdr: the OUT header of the virtio I2C message > + * @buf: the buffer into which data is read, or from which it's written > + * @in_hdr: the IN header of the virtio I2C message > + */ > +struct virtio_i2c_req { > + struct virtio_i2c_out_hdr out_hdr ____cacheline_aligned; > + uint8_t *buf ____cacheline_aligned; > + struct virtio_i2c_in_hdr in_hdr ____cacheline_aligned; > +}; > + > +static void virtio_i2c_msg_done(struct virtqueue *vq) > +{ > + struct virtio_i2c *vi = vq->vdev->priv; > + > + complete(&vi->completion); > +} > + > +static int virtio_i2c_prepare_reqs(struct virtqueue *vq, > + struct virtio_i2c_req *reqs, > + struct i2c_msg *msgs, int num) > +{ > + struct scatterlist *sgs[3], out_hdr, msg_buf, in_hdr; > + int i; > + > + for (i = 0; i < num; i++) { > + int outcnt = 0, incnt = 0; > + > + /* > + * We don't support 0 length messages and so masked out > + * I2C_FUNC_SMBUS_QUICK in virtio_i2c_func(). > + */ > + if (!msgs[i].len) > + break; > + > + /* > + * Only 7-bit mode supported for this moment. For the address > + * format, Please check the Virtio I2C Specification. > + */ > + reqs[i].out_hdr.addr = cpu_to_le16(msgs[i].addr << 1); > + > + if (i != num - 1) > + reqs[i].out_hdr.flags = cpu_to_le32(VIRTIO_I2C_FLAGS_FAIL_NEXT); > + > + sg_init_one(&out_hdr, &reqs[i].out_hdr, sizeof(reqs[i].out_hdr)); > + sgs[outcnt++] = &out_hdr; > + > + reqs[i].buf = i2c_get_dma_safe_msg_buf(&msgs[i], 1); > + if (!reqs[i].buf) > + break; > + > + sg_init_one(&msg_buf, reqs[i].buf, msgs[i].len); > + > + if (msgs[i].flags & I2C_M_RD) > + sgs[outcnt + incnt++] = &msg_buf; > + else > + sgs[outcnt++] = &msg_buf; > + > + sg_init_one(&in_hdr, &reqs[i].in_hdr, sizeof(reqs[i].in_hdr)); > + sgs[outcnt + incnt++] = &in_hdr; > + > + if (virtqueue_add_sgs(vq, sgs, outcnt, incnt, &reqs[i], GFP_KERNEL)) { > + i2c_put_dma_safe_msg_buf(reqs[i].buf, &msgs[i], false); > + break; > + } > + } > + > + return i; > +} > + > +static int virtio_i2c_complete_reqs(struct virtqueue *vq, > + struct virtio_i2c_req *reqs, > + struct i2c_msg *msgs, int num, > + bool timedout) > +{ > + struct virtio_i2c_req *req; > + bool failed = timedout; > + unsigned int len; > + int i, j = 0; > + > + for (i = 0; i < num; i++) { > + /* Detach the ith request from the vq */ > + req = virtqueue_get_buf(vq, &len); > + > + /* > + * Condition req == &reqs[i] should always meet since we have > + * total num requests in the vq. reqs[i] can never be NULL here. > + */ > + if (!failed && (WARN_ON(req != &reqs[i]) || > + req->in_hdr.status != VIRTIO_I2C_MSG_OK)) > + failed = true; > + > + i2c_put_dma_safe_msg_buf(reqs[i].buf, &msgs[i], !failed); > + > + if (!failed) > + j++; > + } > + > + return timedout ? -ETIMEDOUT : j; > +} > + > +static int virtio_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, > + int num) > +{ > + struct virtio_i2c *vi = i2c_get_adapdata(adap); > + struct virtqueue *vq = vi->vq; > + struct virtio_i2c_req *reqs; > + unsigned long time_left; > + int count; > + > + reqs = kcalloc(num, sizeof(*reqs), GFP_KERNEL); > + if (!reqs) > + return -ENOMEM; > + > + count = virtio_i2c_prepare_reqs(vq, reqs, msgs, num); > + if (!count) > + goto err_free; > + > + /* > + * For the case where count < num, i.e. we weren't able to queue all the > + * msgs, ideally we should abort right away and return early, but some > + * of the messages are already sent to the remote I2C controller and the > + * virtqueue will be left in undefined state in that case. We kick the > + * remote here to clear the virtqueue, so we can try another set of > + * messages later on. > + */ > + > + reinit_completion(&vi->completion); > + virtqueue_kick(vq); > + > + time_left = wait_for_completion_timeout(&vi->completion, adap->timeout); > + if (!time_left) > + dev_err(&adap->dev, "virtio i2c backend timeout.\n"); > + > + count = virtio_i2c_complete_reqs(vq, reqs, msgs, count, !time_left); > + > +err_free: > + kfree(reqs); > + return count; > +} > + > +static void virtio_i2c_del_vqs(struct virtio_device *vdev) > +{ > + vdev->config->reset(vdev); > + vdev->config->del_vqs(vdev); > +} > + > +static int virtio_i2c_setup_vqs(struct virtio_i2c *vi) > +{ > + struct virtio_device *vdev = vi->vdev; > + > + vi->vq = virtio_find_single_vq(vdev, virtio_i2c_msg_done, "msg"); > + return PTR_ERR_OR_ZERO(vi->vq); > +} > + > +static u32 virtio_i2c_func(struct i2c_adapter *adap) > +{ > + return I2C_FUNC_I2C | (I2C_FUNC_SMBUS_EMUL & ~I2C_FUNC_SMBUS_QUICK); > +} > + > +static struct i2c_algorithm virtio_algorithm = { > + .master_xfer = virtio_i2c_xfer, > + .functionality = virtio_i2c_func, > +}; > + > +static int virtio_i2c_probe(struct virtio_device *vdev) > +{ > + struct device *pdev = vdev->dev.parent; > + struct virtio_i2c *vi; > + int ret; > + > + vi = devm_kzalloc(&vdev->dev, sizeof(*vi), GFP_KERNEL); > + if (!vi) > + return -ENOMEM; > + > + vdev->priv = vi; > + vi->vdev = vdev; > + > + init_completion(&vi->completion); > + > + ret = virtio_i2c_setup_vqs(vi); > + if (ret) > + return ret; > + > + vi->adap.owner = THIS_MODULE; > + snprintf(vi->adap.name, sizeof(vi->adap.name), > + "i2c_virtio at virtio bus %d", vdev->index); > + vi->adap.algo = &virtio_algorithm; > + vi->adap.dev.parent = &vdev->dev; > + i2c_set_adapdata(&vi->adap, vi); > + > + /* > + * Setup ACPI node for controlled devices which will be probed through > + * ACPI. > + */ > + ACPI_COMPANION_SET(&vi->adap.dev, ACPI_COMPANION(pdev)); > + > + ret = i2c_add_adapter(&vi->adap); > + if (ret) > + virtio_i2c_del_vqs(vdev); > + > + return ret; > +} > + > +static void virtio_i2c_remove(struct virtio_device *vdev) > +{ > + struct virtio_i2c *vi = vdev->priv; > + > + i2c_del_adapter(&vi->adap); > + virtio_i2c_del_vqs(vdev); > +} > + > +static struct virtio_device_id id_table[] = { > + { VIRTIO_ID_I2C_ADAPTER, VIRTIO_DEV_ANY_ID }, > + {} > +}; > +MODULE_DEVICE_TABLE(virtio, id_table); > + > +#ifdef CONFIG_PM_SLEEP > +static int virtio_i2c_freeze(struct virtio_device *vdev) > +{ > + virtio_i2c_del_vqs(vdev); > + return 0; > +} > + > +static int virtio_i2c_restore(struct virtio_device *vdev) > +{ > + return virtio_i2c_setup_vqs(vdev->priv); > +} > +#endif > + > +static struct virtio_driver virtio_i2c_driver = { > + .id_table = id_table, > + .probe = virtio_i2c_probe, > + .remove = virtio_i2c_remove, > + .driver = { > + .name = "i2c_virtio", > + }, > +#ifdef CONFIG_PM_SLEEP > + .freeze = virtio_i2c_freeze, > + .restore = virtio_i2c_restore, > +#endif > +}; > +module_virtio_driver(virtio_i2c_driver); > + > +MODULE_AUTHOR("Jie Deng "); > +MODULE_AUTHOR("Conghui Chen "); > +MODULE_DESCRIPTION("Virtio i2c bus driver"); > +MODULE_LICENSE("GPL"); > diff --git a/include/uapi/linux/virtio_i2c.h b/include/uapi/linux/virtio_i2c.h > new file mode 100644 > index 0000000..7c6a6fc > --- /dev/null > +++ b/include/uapi/linux/virtio_i2c.h > @@ -0,0 +1,41 @@ > +/* SPDX-License-Identifier: GPL-2.0-or-later WITH Linux-syscall-note */ > +/* > + * Definitions for virtio I2C Adpter > + * > + * Copyright (c) 2021 Intel Corporation. All rights reserved. > + */ > + > +#ifndef _UAPI_LINUX_VIRTIO_I2C_H > +#define _UAPI_LINUX_VIRTIO_I2C_H > + > +#include > +#include > + > +/* The bit 0 of the @virtio_i2c_out_hdr.@flags, used to group the requests */ > +#define VIRTIO_I2C_FLAGS_FAIL_NEXT _BITUL(0) > + > +/** > + * struct virtio_i2c_out_hdr - the virtio I2C message OUT header > + * @addr: the controlled device address > + * @padding: used to pad to full dword > + * @flags: used for feature extensibility > + */ > +struct virtio_i2c_out_hdr { > + __le16 addr; > + __le16 padding; > + __le32 flags; > +}; > + > +/** > + * struct virtio_i2c_in_hdr - the virtio I2C message IN header > + * @status: the processing result from the backend > + */ > +struct virtio_i2c_in_hdr { > + __u8 status; > +}; > + > +/* The final status written by the device */ > +#define VIRTIO_I2C_MSG_OK 0 > +#define VIRTIO_I2C_MSG_ERR 1 > + > +#endif /* _UAPI_LINUX_VIRTIO_I2C_H */ > diff --git a/include/uapi/linux/virtio_ids.h b/include/uapi/linux/virtio_ids.h > index 4fe842c..3b5f05a 100644 > --- a/include/uapi/linux/virtio_ids.h > +++ b/include/uapi/linux/virtio_ids.h > @@ -55,6 +55,7 @@ > #define VIRTIO_ID_FS 26 /* virtio filesystem */ > #define VIRTIO_ID_PMEM 27 /* virtio pmem */ > #define VIRTIO_ID_MAC80211_HWSIM 29 /* virtio mac80211-hwsim */ > +#define VIRTIO_ID_I2C_ADAPTER 34 /* virtio i2c adapter */ > #define VIRTIO_ID_BT 40 /* virtio bluetooth */ > > #endif /* _LINUX_VIRTIO_IDS_H */ > -- > 2.7.4 _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization