From: "Michael S. Tsirkin" <mst@redhat.com>
To: Xie Yongji <xieyongji@bytedance.com>
Cc: kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
christian.brauner@canonical.com, will@kernel.org, corbet@lwn.net,
joro@8bytes.org, willy@infradead.org, hch@infradead.org,
dan.carpenter@oracle.com, john.garry@huawei.com,
xiaodong.liu@intel.com, linux-fsdevel@vger.kernel.org,
viro@zeniv.linux.org.uk, stefanha@redhat.com,
songmuchun@bytedance.com, axboe@kernel.dk, zhe.he@windriver.com,
gregkh@linuxfoundation.org, rdunlap@infradead.org,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
bcrl@kvack.org, netdev@vger.kernel.org, joe@perches.com,
robin.murphy@arm.com, mika.penttila@nextfour.com
Subject: Re: [PATCH v13 05/13] vdpa: Add reset callback in vdpa_config_ops
Date: Mon, 6 Sep 2021 01:55:56 -0400 [thread overview]
Message-ID: <20210906015524-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20210831103634.33-6-xieyongji@bytedance.com>
On Tue, Aug 31, 2021 at 06:36:26PM +0800, Xie Yongji wrote:
> This adds a new callback to support device specific reset
> behavior. The vdpa bus driver will call the reset function
> instead of setting status to zero during resetting.
>
> Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
This does gloss over a significant change though:
> ---
> @@ -348,12 +352,12 @@ static inline struct device *vdpa_get_dma_dev(struct vdpa_device *vdev)
> return vdev->dma_dev;
> }
>
> -static inline void vdpa_reset(struct vdpa_device *vdev)
> +static inline int vdpa_reset(struct vdpa_device *vdev)
> {
> const struct vdpa_config_ops *ops = vdev->config;
>
> vdev->features_valid = false;
> - ops->set_status(vdev, 0);
> + return ops->reset(vdev);
> }
>
> static inline int vdpa_set_features(struct vdpa_device *vdev, u64 features)
Unfortunately this breaks virtio_vdpa:
static void virtio_vdpa_reset(struct virtio_device *vdev)
{
struct vdpa_device *vdpa = vd_get_vdpa(vdev);
vdpa_reset(vdpa);
}
and there's no easy way to fix this, kernel can't recover
from a reset failure e.g. during driver unbind.
Find a way to disable virtio_vdpa for now?
> --
> 2.11.0
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-09-06 5:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210831103634.33-1-xieyongji@bytedance.com>
[not found] ` <20210831103634.33-3-xieyongji@bytedance.com>
2021-09-01 2:50 ` [PATCH v13 02/13] eventfd: Export eventfd_wake_count to modules Jason Wang
[not found] ` <20210831103634.33-4-xieyongji@bytedance.com>
2021-09-05 15:57 ` [PATCH v13 03/13] file: Export receive_fd() " Michael S. Tsirkin
2021-09-05 16:44 ` Al Viro
[not found] ` <20210831103634.33-6-xieyongji@bytedance.com>
2021-09-06 5:55 ` Michael S. Tsirkin [this message]
[not found] ` <CACycT3v4ZVnh7DGe_RtAOx4Vvau0km=HWyCM=KzKhD+ahYKafQ@mail.gmail.com>
2021-09-06 6:37 ` [PATCH v13 05/13] vdpa: Add reset callback in vdpa_config_ops Michael S. Tsirkin
[not found] ` <CACycT3ssC1bhNzY9Pk=LPvKjMrFFavTfCKTJtR2XEiVYqDxT1Q@mail.gmail.com>
2021-09-06 8:00 ` Michael S. Tsirkin
[not found] ` <CACycT3vQHRsJ_j5f4T9RoB4MQzBoYO5ts3egVe9K6TcCVfLOFQ@mail.gmail.com>
2021-09-06 10:43 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210906015524-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=axboe@kernel.dk \
--cc=bcrl@kvack.org \
--cc=christian.brauner@canonical.com \
--cc=corbet@lwn.net \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joe@perches.com \
--cc=john.garry@huawei.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.penttila@nextfour.com \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=robin.murphy@arm.com \
--cc=songmuchun@bytedance.com \
--cc=stefanha@redhat.com \
--cc=viro@zeniv.linux.org.uk \
--cc=virtualization@lists.linux-foundation.org \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=xiaodong.liu@intel.com \
--cc=xieyongji@bytedance.com \
--cc=zhe.he@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).