* Re: [PATCH RFC] virtio: wrap config->reset calls
2021-10-13 10:55 [PATCH RFC] virtio: wrap config->reset calls Michael S. Tsirkin
@ 2021-10-13 11:00 ` Viresh Kumar
2021-10-13 11:03 ` David Hildenbrand
` (5 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Viresh Kumar @ 2021-10-13 11:00 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: nvdimm, Stefan Hajnoczi, kvm, David Airlie, Viresh Kumar,
linux-remoteproc, alsa-devel, dri-devel, Bjorn Andersson, netdev,
linux-scsi, Will Deacon, v9fs-developer, Anton Ivanov,
Jean-Philippe Brucker, Linus Walleij, Dave Jiang, Herbert Xu,
linux-arm-kernel, Miklos Szeredi, Richard Weinberger,
Bartosz Golaszewski, Takashi Iwai, Kalle Valo, Martin K. Petersen,
James E.J. Bottomley, Jakub Kicinski, Ira Weiny, virtualization,
Jeff Dike, Vivek Goyal, Ohad Ben-Cohen, Johan Hedberg,
Arnd Bergmann, Amit Shah, Eric Van Hensbergen, Marcel Holtmann,
linux-um, linux-crypto, linux-block, Vishal Verma,
Luiz Augusto von Dentz, Matt Mackall, Dan Williams,
Jaroslav Kysela, Cristian Marussi, Jens Axboe, Mathieu Poirier,
linux-gpio, Greg Kroah-Hartman, linux-wireless, linux-kernel,
linux-i2c, linux-bluetooth, iommu, Daniel Vetter, Sudeep Holla,
linux-fsdevel, Paolo Bonzini, Johannes Berg,
Enrico Weigelt, metux IT consult, David S. Miller, Joerg Roedel
On 13-10-21, 06:55, Michael S. Tsirkin wrote:
> This will enable cleanups down the road.
> The idea is to disable cbs, then add "flush_queued_cbs" callback
> as a parameter, this way drivers can flush any work
> queued after callbacks have been disabled.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/gpio/gpio-virtio.c | 2 +-
> drivers/i2c/busses/i2c-virtio.c | 2 +-
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH RFC] virtio: wrap config->reset calls
2021-10-13 10:55 [PATCH RFC] virtio: wrap config->reset calls Michael S. Tsirkin
2021-10-13 11:00 ` Viresh Kumar
@ 2021-10-13 11:03 ` David Hildenbrand
2021-10-13 12:17 ` Michael S. Tsirkin
2021-10-13 13:16 ` Vivek Goyal
` (4 subsequent siblings)
6 siblings, 1 reply; 10+ messages in thread
From: David Hildenbrand @ 2021-10-13 11:03 UTC (permalink / raw)
To: Michael S. Tsirkin, linux-kernel
Cc: nvdimm, v9fs-developer, Stefan Hajnoczi, kvm, David Airlie,
Viresh Kumar, Linus Walleij, linux-remoteproc, alsa-devel,
dri-devel, Bjorn Andersson, netdev, linux-scsi, Will Deacon,
Anton Ivanov, Jean-Philippe Brucker, Dave Jiang, Herbert Xu,
linux-arm-kernel, Miklos Szeredi, Richard Weinberger,
Bartosz Golaszewski, Kalle Valo, Martin K. Petersen,
James E.J. Bottomley, Jakub Kicinski, Ira Weiny, virtualization,
Marcel Holtmann, Vivek Goyal, Ohad Ben-Cohen, Johan Hedberg,
Arnd Bergmann, Amit Shah, Eric Van Hensbergen, Jeff Dike,
linux-um, linux-crypto, linux-block, Vishal Verma,
Luiz Augusto von Dentz, Matt Mackall, Dan Williams,
Jaroslav Kysela, Cristian Marussi, Jens Axboe, Mathieu Poirier,
linux-gpio, Greg Kroah-Hartman, linux-wireless, Takashi Iwai,
linux-i2c, linux-bluetooth, iommu, Daniel Vetter, Sudeep Holla,
linux-fsdevel, Paolo Bonzini, Johannes Berg,
Enrico Weigelt, metux IT consult, David S. Miller, Joerg Roedel
On 13.10.21 12:55, Michael S. Tsirkin wrote:
> This will enable cleanups down the road.
> The idea is to disable cbs, then add "flush_queued_cbs" callback
> as a parameter, this way drivers can flush any work
> queued after callbacks have been disabled.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> arch/um/drivers/virt-pci.c | 2 +-
> drivers/block/virtio_blk.c | 4 ++--
> drivers/bluetooth/virtio_bt.c | 2 +-
> drivers/char/hw_random/virtio-rng.c | 2 +-
> drivers/char/virtio_console.c | 4 ++--
> drivers/crypto/virtio/virtio_crypto_core.c | 8 ++++----
> drivers/firmware/arm_scmi/virtio.c | 2 +-
> drivers/gpio/gpio-virtio.c | 2 +-
> drivers/gpu/drm/virtio/virtgpu_kms.c | 2 +-
> drivers/i2c/busses/i2c-virtio.c | 2 +-
> drivers/iommu/virtio-iommu.c | 2 +-
> drivers/net/caif/caif_virtio.c | 2 +-
> drivers/net/virtio_net.c | 4 ++--
> drivers/net/wireless/mac80211_hwsim.c | 2 +-
> drivers/nvdimm/virtio_pmem.c | 2 +-
> drivers/rpmsg/virtio_rpmsg_bus.c | 2 +-
> drivers/scsi/virtio_scsi.c | 2 +-
> drivers/virtio/virtio.c | 5 +++++
> drivers/virtio/virtio_balloon.c | 2 +-
> drivers/virtio/virtio_input.c | 2 +-
> drivers/virtio/virtio_mem.c | 2 +-
> fs/fuse/virtio_fs.c | 4 ++--
> include/linux/virtio.h | 1 +
> net/9p/trans_virtio.c | 2 +-
> net/vmw_vsock/virtio_transport.c | 4 ++--
> sound/virtio/virtio_card.c | 4 ++--
> 26 files changed, 39 insertions(+), 33 deletions(-)
>
> diff --git a/arch/um/drivers/virt-pci.c b/arch/um/drivers/virt-pci.c
> index c08066633023..22c4d87c9c15 100644
> --- a/arch/um/drivers/virt-pci.c
> +++ b/arch/um/drivers/virt-pci.c
> @@ -616,7 +616,7 @@ static void um_pci_virtio_remove(struct virtio_device *vdev)
> int i;
>
> /* Stop all virtqueues */
> - vdev->config->reset(vdev);
> + virtio_reset_device(vdev);
> vdev->config->del_vqs(vdev);
Nit: virtio_device_reset()?
Because I see:
int virtio_device_freeze(struct virtio_device *dev);
int virtio_device_restore(struct virtio_device *dev);
void virtio_device_ready(struct virtio_device *dev)
But well, there is:
void virtio_break_device(struct virtio_device *dev);
--
Thanks,
David / dhildenb
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH RFC] virtio: wrap config->reset calls
2021-10-13 11:03 ` David Hildenbrand
@ 2021-10-13 12:17 ` Michael S. Tsirkin
2021-10-13 16:00 ` David Hildenbrand
0 siblings, 1 reply; 10+ messages in thread
From: Michael S. Tsirkin @ 2021-10-13 12:17 UTC (permalink / raw)
To: David Hildenbrand
Cc: nvdimm, v9fs-developer, Stefan Hajnoczi, kvm, David Airlie,
Viresh Kumar, linux-remoteproc, alsa-devel, dri-devel,
Bjorn Andersson, netdev, linux-scsi, Will Deacon, Anton Ivanov,
Jean-Philippe Brucker, Linus Walleij, Dave Jiang, Herbert Xu,
linux-arm-kernel, Miklos Szeredi, Richard Weinberger,
Bartosz Golaszewski, Takashi Iwai, Kalle Valo, Martin K. Petersen,
James E.J. Bottomley, Jakub Kicinski, Ira Weiny, virtualization,
Jeff Dike, Vivek Goyal, Ohad Ben-Cohen, Johan Hedberg,
Arnd Bergmann, Amit Shah, Eric Van Hensbergen, Marcel Holtmann,
linux-um, linux-crypto, linux-block, Vishal Verma,
Luiz Augusto von Dentz, Matt Mackall, Dan Williams,
Jaroslav Kysela, Cristian Marussi, Jens Axboe, Mathieu Poirier,
linux-gpio, Greg Kroah-Hartman, linux-wireless, linux-kernel,
linux-i2c, linux-bluetooth, iommu, Daniel Vetter, Sudeep Holla,
linux-fsdevel, Paolo Bonzini, Johannes Berg,
Enrico Weigelt, metux IT consult, David S. Miller, Joerg Roedel
On Wed, Oct 13, 2021 at 01:03:46PM +0200, David Hildenbrand wrote:
> On 13.10.21 12:55, Michael S. Tsirkin wrote:
> > This will enable cleanups down the road.
> > The idea is to disable cbs, then add "flush_queued_cbs" callback
> > as a parameter, this way drivers can flush any work
> > queued after callbacks have been disabled.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > arch/um/drivers/virt-pci.c | 2 +-
> > drivers/block/virtio_blk.c | 4 ++--
> > drivers/bluetooth/virtio_bt.c | 2 +-
> > drivers/char/hw_random/virtio-rng.c | 2 +-
> > drivers/char/virtio_console.c | 4 ++--
> > drivers/crypto/virtio/virtio_crypto_core.c | 8 ++++----
> > drivers/firmware/arm_scmi/virtio.c | 2 +-
> > drivers/gpio/gpio-virtio.c | 2 +-
> > drivers/gpu/drm/virtio/virtgpu_kms.c | 2 +-
> > drivers/i2c/busses/i2c-virtio.c | 2 +-
> > drivers/iommu/virtio-iommu.c | 2 +-
> > drivers/net/caif/caif_virtio.c | 2 +-
> > drivers/net/virtio_net.c | 4 ++--
> > drivers/net/wireless/mac80211_hwsim.c | 2 +-
> > drivers/nvdimm/virtio_pmem.c | 2 +-
> > drivers/rpmsg/virtio_rpmsg_bus.c | 2 +-
> > drivers/scsi/virtio_scsi.c | 2 +-
> > drivers/virtio/virtio.c | 5 +++++
> > drivers/virtio/virtio_balloon.c | 2 +-
> > drivers/virtio/virtio_input.c | 2 +-
> > drivers/virtio/virtio_mem.c | 2 +-
> > fs/fuse/virtio_fs.c | 4 ++--
> > include/linux/virtio.h | 1 +
> > net/9p/trans_virtio.c | 2 +-
> > net/vmw_vsock/virtio_transport.c | 4 ++--
> > sound/virtio/virtio_card.c | 4 ++--
> > 26 files changed, 39 insertions(+), 33 deletions(-)
> >
> > diff --git a/arch/um/drivers/virt-pci.c b/arch/um/drivers/virt-pci.c
> > index c08066633023..22c4d87c9c15 100644
> > --- a/arch/um/drivers/virt-pci.c
> > +++ b/arch/um/drivers/virt-pci.c
> > @@ -616,7 +616,7 @@ static void um_pci_virtio_remove(struct virtio_device *vdev)
> > int i;
> > /* Stop all virtqueues */
> > - vdev->config->reset(vdev);
> > + virtio_reset_device(vdev);
> > vdev->config->del_vqs(vdev);
>
> Nit: virtio_device_reset()?
>
> Because I see:
>
> int virtio_device_freeze(struct virtio_device *dev);
> int virtio_device_restore(struct virtio_device *dev);
> void virtio_device_ready(struct virtio_device *dev)
>
> But well, there is:
> void virtio_break_device(struct virtio_device *dev);
Exactly. I don't know what's best, so I opted for plain english :)
> --
> Thanks,
>
> David / dhildenb
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH RFC] virtio: wrap config->reset calls
2021-10-13 12:17 ` Michael S. Tsirkin
@ 2021-10-13 16:00 ` David Hildenbrand
0 siblings, 0 replies; 10+ messages in thread
From: David Hildenbrand @ 2021-10-13 16:00 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: nvdimm, v9fs-developer, Stefan Hajnoczi, kvm, David Airlie,
Viresh Kumar, linux-remoteproc, alsa-devel, dri-devel,
Bjorn Andersson, netdev, linux-scsi, Will Deacon, Anton Ivanov,
Jean-Philippe Brucker, Linus Walleij, Dave Jiang, Herbert Xu,
linux-arm-kernel, Miklos Szeredi, Richard Weinberger,
Bartosz Golaszewski, Takashi Iwai, Kalle Valo, Martin K. Petersen,
James E.J. Bottomley, Jakub Kicinski, Ira Weiny, virtualization,
Jeff Dike, Vivek Goyal, Ohad Ben-Cohen, Johan Hedberg,
Arnd Bergmann, Amit Shah, Eric Van Hensbergen, Marcel Holtmann,
linux-um, linux-crypto, linux-block, Vishal Verma,
Luiz Augusto von Dentz, Matt Mackall, Dan Williams,
Jaroslav Kysela, Cristian Marussi, Jens Axboe, Mathieu Poirier,
linux-gpio, Greg Kroah-Hartman, linux-wireless, linux-kernel,
linux-i2c, linux-bluetooth, iommu, Daniel Vetter, Sudeep Holla,
linux-fsdevel, Paolo Bonzini, Johannes Berg,
Enrico Weigelt, metux IT consult, David S. Miller, Joerg Roedel
On 13.10.21 14:17, Michael S. Tsirkin wrote:
> On Wed, Oct 13, 2021 at 01:03:46PM +0200, David Hildenbrand wrote:
>> On 13.10.21 12:55, Michael S. Tsirkin wrote:
>>> This will enable cleanups down the road.
>>> The idea is to disable cbs, then add "flush_queued_cbs" callback
>>> as a parameter, this way drivers can flush any work
>>> queued after callbacks have been disabled.
>>>
>>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>>> ---
>>> arch/um/drivers/virt-pci.c | 2 +-
>>> drivers/block/virtio_blk.c | 4 ++--
>>> drivers/bluetooth/virtio_bt.c | 2 +-
>>> drivers/char/hw_random/virtio-rng.c | 2 +-
>>> drivers/char/virtio_console.c | 4 ++--
>>> drivers/crypto/virtio/virtio_crypto_core.c | 8 ++++----
>>> drivers/firmware/arm_scmi/virtio.c | 2 +-
>>> drivers/gpio/gpio-virtio.c | 2 +-
>>> drivers/gpu/drm/virtio/virtgpu_kms.c | 2 +-
>>> drivers/i2c/busses/i2c-virtio.c | 2 +-
>>> drivers/iommu/virtio-iommu.c | 2 +-
>>> drivers/net/caif/caif_virtio.c | 2 +-
>>> drivers/net/virtio_net.c | 4 ++--
>>> drivers/net/wireless/mac80211_hwsim.c | 2 +-
>>> drivers/nvdimm/virtio_pmem.c | 2 +-
>>> drivers/rpmsg/virtio_rpmsg_bus.c | 2 +-
>>> drivers/scsi/virtio_scsi.c | 2 +-
>>> drivers/virtio/virtio.c | 5 +++++
>>> drivers/virtio/virtio_balloon.c | 2 +-
>>> drivers/virtio/virtio_input.c | 2 +-
>>> drivers/virtio/virtio_mem.c | 2 +-
>>> fs/fuse/virtio_fs.c | 4 ++--
>>> include/linux/virtio.h | 1 +
>>> net/9p/trans_virtio.c | 2 +-
>>> net/vmw_vsock/virtio_transport.c | 4 ++--
>>> sound/virtio/virtio_card.c | 4 ++--
>>> 26 files changed, 39 insertions(+), 33 deletions(-)
>>>
>>> diff --git a/arch/um/drivers/virt-pci.c b/arch/um/drivers/virt-pci.c
>>> index c08066633023..22c4d87c9c15 100644
>>> --- a/arch/um/drivers/virt-pci.c
>>> +++ b/arch/um/drivers/virt-pci.c
>>> @@ -616,7 +616,7 @@ static void um_pci_virtio_remove(struct virtio_device *vdev)
>>> int i;
>>> /* Stop all virtqueues */
>>> - vdev->config->reset(vdev);
>>> + virtio_reset_device(vdev);
>>> vdev->config->del_vqs(vdev);
>>
>> Nit: virtio_device_reset()?
>>
>> Because I see:
>>
>> int virtio_device_freeze(struct virtio_device *dev);
>> int virtio_device_restore(struct virtio_device *dev);
>> void virtio_device_ready(struct virtio_device *dev)
>>
>> But well, there is:
>> void virtio_break_device(struct virtio_device *dev);
>
> Exactly. I don't know what's best, so I opted for plain english :)
Fair enough, LGTM
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH RFC] virtio: wrap config->reset calls
2021-10-13 10:55 [PATCH RFC] virtio: wrap config->reset calls Michael S. Tsirkin
2021-10-13 11:00 ` Viresh Kumar
2021-10-13 11:03 ` David Hildenbrand
@ 2021-10-13 13:16 ` Vivek Goyal
2021-10-14 6:11 ` Anton Yakovlev
` (3 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Vivek Goyal @ 2021-10-13 13:16 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: nvdimm, v9fs-developer, Stefan Hajnoczi, kvm, David Airlie,
Viresh Kumar, linux-remoteproc, alsa-devel, dri-devel,
Bjorn Andersson, netdev, linux-scsi, Will Deacon, Anton Ivanov,
Jean-Philippe Brucker, Linus Walleij, Dave Jiang, Herbert Xu,
linux-arm-kernel, Miklos Szeredi, Richard Weinberger,
Bartosz Golaszewski, Takashi Iwai, Kalle Valo, Martin K. Petersen,
James E.J. Bottomley, Jakub Kicinski, Ira Weiny, virtualization,
Jeff Dike, Ohad Ben-Cohen, Johan Hedberg, Arnd Bergmann,
Amit Shah, Eric Van Hensbergen, Marcel Holtmann, linux-um,
linux-crypto, linux-block, Vishal Verma, Luiz Augusto von Dentz,
Matt Mackall, Dan Williams, Jaroslav Kysela, Cristian Marussi,
Jens Axboe, Mathieu Poirier, linux-gpio, Greg Kroah-Hartman,
linux-wireless, linux-kernel, linux-i2c, linux-bluetooth, iommu,
Daniel Vetter, Sudeep Holla, linux-fsdevel, Paolo Bonzini,
Johannes Berg, Enrico Weigelt, metux IT consult, David S. Miller,
Joerg Roedel
On Wed, Oct 13, 2021 at 06:55:31AM -0400, Michael S. Tsirkin wrote:
> This will enable cleanups down the road.
> The idea is to disable cbs, then add "flush_queued_cbs" callback
> as a parameter, this way drivers can flush any work
> queued after callbacks have been disabled.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> arch/um/drivers/virt-pci.c | 2 +-
> drivers/block/virtio_blk.c | 4 ++--
> drivers/bluetooth/virtio_bt.c | 2 +-
> drivers/char/hw_random/virtio-rng.c | 2 +-
> drivers/char/virtio_console.c | 4 ++--
> drivers/crypto/virtio/virtio_crypto_core.c | 8 ++++----
> drivers/firmware/arm_scmi/virtio.c | 2 +-
> drivers/gpio/gpio-virtio.c | 2 +-
> drivers/gpu/drm/virtio/virtgpu_kms.c | 2 +-
> drivers/i2c/busses/i2c-virtio.c | 2 +-
> drivers/iommu/virtio-iommu.c | 2 +-
> drivers/net/caif/caif_virtio.c | 2 +-
> drivers/net/virtio_net.c | 4 ++--
> drivers/net/wireless/mac80211_hwsim.c | 2 +-
> drivers/nvdimm/virtio_pmem.c | 2 +-
> drivers/rpmsg/virtio_rpmsg_bus.c | 2 +-
> drivers/scsi/virtio_scsi.c | 2 +-
> drivers/virtio/virtio.c | 5 +++++
> drivers/virtio/virtio_balloon.c | 2 +-
> drivers/virtio/virtio_input.c | 2 +-
> drivers/virtio/virtio_mem.c | 2 +-
> fs/fuse/virtio_fs.c | 4 ++--
fs/fuse/virtio_fs.c changes look good to me.
Reviewed-by: Vivek Goyal <vgoyal@redhat.com>
Vivek
[..]
> diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c
> index 0ad89c6629d7..27c3b74070a2 100644
> --- a/fs/fuse/virtio_fs.c
> +++ b/fs/fuse/virtio_fs.c
> @@ -895,7 +895,7 @@ static int virtio_fs_probe(struct virtio_device *vdev)
> return 0;
>
> out_vqs:
> - vdev->config->reset(vdev);
> + virtio_reset_device(vdev);
> virtio_fs_cleanup_vqs(vdev, fs);
> kfree(fs->vqs);
>
> @@ -927,7 +927,7 @@ static void virtio_fs_remove(struct virtio_device *vdev)
> list_del_init(&fs->list);
> virtio_fs_stop_all_queues(fs);
> virtio_fs_drain_all_queues_locked(fs);
> - vdev->config->reset(vdev);
> + virtio_reset_device(vdev);
> virtio_fs_cleanup_vqs(vdev, fs);
>
> vdev->priv = NULL;
Thanks
Vivek
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH RFC] virtio: wrap config->reset calls
2021-10-13 10:55 [PATCH RFC] virtio: wrap config->reset calls Michael S. Tsirkin
` (2 preceding siblings ...)
2021-10-13 13:16 ` Vivek Goyal
@ 2021-10-14 6:11 ` Anton Yakovlev
2021-10-14 8:36 ` Jean-Philippe Brucker
` (2 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Anton Yakovlev @ 2021-10-14 6:11 UTC (permalink / raw)
To: Michael S. Tsirkin, linux-kernel
Cc: nvdimm, Stefan Hajnoczi, kvm, David Airlie, Viresh Kumar,
Linus Walleij, linux-remoteproc, alsa-devel, dri-devel,
Bjorn Andersson, netdev, linux-scsi, Will Deacon, v9fs-developer,
Anton Ivanov, Jean-Philippe Brucker, Dave Jiang, Herbert Xu,
linux-arm-kernel, Miklos Szeredi, Richard Weinberger,
Bartosz Golaszewski, Kalle Valo, Martin K. Petersen,
James E.J. Bottomley, Jakub Kicinski, Ira Weiny, virtualization,
Marcel Holtmann, Vivek Goyal, Ohad Ben-Cohen, Johan Hedberg,
Arnd Bergmann, Amit Shah, Eric Van Hensbergen, Jeff Dike,
linux-um, linux-block, Vishal Verma, Luiz Augusto von Dentz,
Matt Mackall, Dan Williams, Jaroslav Kysela, Cristian Marussi,
Jens Axboe, Mathieu Poirier, linux-gpio, Greg Kroah-Hartman,
linux-wireless, Takashi Iwai, linux-i2c, linux-bluetooth, iommu,
linux-crypto, Daniel Vetter, Sudeep Holla, linux-fsdevel,
Paolo Bonzini, Johannes Berg, Enrico Weigelt, metux IT consult,
David S. Miller, Joerg Roedel
On 13.10.2021 12:55, Michael S. Tsirkin wrote:
> This will enable cleanups down the road.
> The idea is to disable cbs, then add "flush_queued_cbs" callback
> as a parameter, this way drivers can flush any work
> queued after callbacks have been disabled.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> sound/virtio/virtio_card.c | 4 ++--
>
Reviewed-by: Anton Yakovlev <anton.yakovlev@opensynergy.com>
--
Anton Yakovlev
Senior Software Engineer
OpenSynergy GmbH
Rotherstr. 20, 10245 Berlin
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH RFC] virtio: wrap config->reset calls
2021-10-13 10:55 [PATCH RFC] virtio: wrap config->reset calls Michael S. Tsirkin
` (3 preceding siblings ...)
2021-10-14 6:11 ` Anton Yakovlev
@ 2021-10-14 8:36 ` Jean-Philippe Brucker
2021-10-18 9:11 ` Stefan Hajnoczi
2021-10-18 9:24 ` Stefano Garzarella
6 siblings, 0 replies; 10+ messages in thread
From: Jean-Philippe Brucker @ 2021-10-14 8:36 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: nvdimm, Stefan Hajnoczi, kvm, David Airlie, Viresh Kumar,
linux-remoteproc, alsa-devel, dri-devel, Bjorn Andersson, netdev,
linux-scsi, Will Deacon, v9fs-developer, Anton Ivanov,
Linus Walleij, Dave Jiang, Herbert Xu, linux-arm-kernel,
Miklos Szeredi, Richard Weinberger, Bartosz Golaszewski,
Takashi Iwai, Kalle Valo, Martin K. Petersen,
James E.J. Bottomley, Jakub Kicinski, Ira Weiny, virtualization,
Jeff Dike, Vivek Goyal, Ohad Ben-Cohen, Johan Hedberg,
Arnd Bergmann, Amit Shah, Eric Van Hensbergen, Marcel Holtmann,
linux-um, linux-crypto, linux-block, Vishal Verma,
Luiz Augusto von Dentz, Matt Mackall, Dan Williams,
Jaroslav Kysela, Cristian Marussi, Jens Axboe, Mathieu Poirier,
linux-gpio, Greg Kroah-Hartman, linux-wireless, linux-kernel,
linux-i2c, linux-bluetooth, iommu, Daniel Vetter, Sudeep Holla,
linux-fsdevel, Paolo Bonzini, Johannes Berg,
Enrico Weigelt, metux IT consult, David S. Miller, Joerg Roedel
On Wed, Oct 13, 2021 at 06:55:31AM -0400, Michael S. Tsirkin wrote:
> This will enable cleanups down the road.
> The idea is to disable cbs, then add "flush_queued_cbs" callback
> as a parameter, this way drivers can flush any work
> queued after callbacks have been disabled.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/iommu/virtio-iommu.c | 2 +-
Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH RFC] virtio: wrap config->reset calls
2021-10-13 10:55 [PATCH RFC] virtio: wrap config->reset calls Michael S. Tsirkin
` (4 preceding siblings ...)
2021-10-14 8:36 ` Jean-Philippe Brucker
@ 2021-10-18 9:11 ` Stefan Hajnoczi
2021-10-18 9:24 ` Stefano Garzarella
6 siblings, 0 replies; 10+ messages in thread
From: Stefan Hajnoczi @ 2021-10-18 9:11 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: nvdimm, kvm, David Airlie, Linus Walleij, Jeff Dike, alsa-devel,
dri-devel, Bjorn Andersson, netdev, linux-scsi, Will Deacon,
v9fs-developer, Anton Ivanov, Jean-Philippe Brucker, Dave Jiang,
Herbert Xu, linux-arm-kernel, Miklos Szeredi, Viresh Kumar,
Bartosz Golaszewski, Takashi Iwai, Kalle Valo, Martin K. Petersen,
James E.J. Bottomley, Jakub Kicinski, Ira Weiny, virtualization,
Vivek Goyal, Ohad Ben-Cohen, Johan Hedberg, Arnd Bergmann,
Amit Shah, Eric Van Hensbergen, linux-remoteproc, Marcel Holtmann,
Sudeep Holla, linux-um, linux-crypto, linux-block, Vishal Verma,
Luiz Augusto von Dentz, Matt Mackall, Dan Williams,
Jaroslav Kysela, Cristian Marussi, Jens Axboe, Mathieu Poirier,
linux-gpio, Greg Kroah-Hartman, linux-wireless, linux-kernel,
linux-i2c, linux-bluetooth, iommu, Daniel Vetter,
Richard Weinberger, linux-fsdevel, Paolo Bonzini, Johannes Berg,
Enrico Weigelt, metux IT consult, David S. Miller, Joerg Roedel
[-- Attachment #1.1: Type: text/plain, Size: 1881 bytes --]
On Wed, Oct 13, 2021 at 06:55:31AM -0400, Michael S. Tsirkin wrote:
> This will enable cleanups down the road.
> The idea is to disable cbs, then add "flush_queued_cbs" callback
> as a parameter, this way drivers can flush any work
> queued after callbacks have been disabled.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> arch/um/drivers/virt-pci.c | 2 +-
> drivers/block/virtio_blk.c | 4 ++--
> drivers/bluetooth/virtio_bt.c | 2 +-
> drivers/char/hw_random/virtio-rng.c | 2 +-
> drivers/char/virtio_console.c | 4 ++--
> drivers/crypto/virtio/virtio_crypto_core.c | 8 ++++----
> drivers/firmware/arm_scmi/virtio.c | 2 +-
> drivers/gpio/gpio-virtio.c | 2 +-
> drivers/gpu/drm/virtio/virtgpu_kms.c | 2 +-
> drivers/i2c/busses/i2c-virtio.c | 2 +-
> drivers/iommu/virtio-iommu.c | 2 +-
> drivers/net/caif/caif_virtio.c | 2 +-
> drivers/net/virtio_net.c | 4 ++--
> drivers/net/wireless/mac80211_hwsim.c | 2 +-
> drivers/nvdimm/virtio_pmem.c | 2 +-
> drivers/rpmsg/virtio_rpmsg_bus.c | 2 +-
> drivers/scsi/virtio_scsi.c | 2 +-
> drivers/virtio/virtio.c | 5 +++++
> drivers/virtio/virtio_balloon.c | 2 +-
> drivers/virtio/virtio_input.c | 2 +-
> drivers/virtio/virtio_mem.c | 2 +-
> fs/fuse/virtio_fs.c | 4 ++--
> include/linux/virtio.h | 1 +
> net/9p/trans_virtio.c | 2 +-
> net/vmw_vsock/virtio_transport.c | 4 ++--
> sound/virtio/virtio_card.c | 4 ++--
> 26 files changed, 39 insertions(+), 33 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 183 bytes --]
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH RFC] virtio: wrap config->reset calls
2021-10-13 10:55 [PATCH RFC] virtio: wrap config->reset calls Michael S. Tsirkin
` (5 preceding siblings ...)
2021-10-18 9:11 ` Stefan Hajnoczi
@ 2021-10-18 9:24 ` Stefano Garzarella
6 siblings, 0 replies; 10+ messages in thread
From: Stefano Garzarella @ 2021-10-18 9:24 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: nvdimm, Stefan Hajnoczi, kvm, David Airlie, Viresh Kumar,
linux-remoteproc, alsa-devel, dri-devel, Bjorn Andersson, netdev,
linux-scsi, Will Deacon, v9fs-developer, Anton Ivanov,
Jean-Philippe Brucker, Linus Walleij, Dave Jiang, Herbert Xu,
linux-arm-kernel, Miklos Szeredi, Richard Weinberger,
Bartosz Golaszewski, Takashi Iwai, Kalle Valo, Martin K. Petersen,
James E.J. Bottomley, Jakub Kicinski, Ira Weiny, virtualization,
Jeff Dike, Vivek Goyal, linux-crypto, Ohad Ben-Cohen,
Johan Hedberg, Arnd Bergmann, Amit Shah, Eric Van Hensbergen,
Marcel Holtmann, linux-um, linux-block, Vishal Verma,
Luiz Augusto von Dentz, Matt Mackall, Dan Williams,
Jaroslav Kysela, Cristian Marussi, Jens Axboe, Mathieu Poirier,
linux-gpio, Greg Kroah-Hartman, linux-wireless, linux-kernel,
linux-i2c, linux-bluetooth, iommu, Daniel Vetter, Sudeep Holla,
linux-fsdevel, Paolo Bonzini, Johannes Berg,
Enrico Weigelt, metux IT consult, David S. Miller, Joerg Roedel
On Wed, Oct 13, 2021 at 06:55:31AM -0400, Michael S. Tsirkin wrote:
>This will enable cleanups down the road.
>The idea is to disable cbs, then add "flush_queued_cbs" callback
>as a parameter, this way drivers can flush any work
>queued after callbacks have been disabled.
>
>Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>---
> arch/um/drivers/virt-pci.c | 2 +-
> drivers/block/virtio_blk.c | 4 ++--
> drivers/bluetooth/virtio_bt.c | 2 +-
> drivers/char/hw_random/virtio-rng.c | 2 +-
> drivers/char/virtio_console.c | 4 ++--
> drivers/crypto/virtio/virtio_crypto_core.c | 8 ++++----
> drivers/firmware/arm_scmi/virtio.c | 2 +-
> drivers/gpio/gpio-virtio.c | 2 +-
> drivers/gpu/drm/virtio/virtgpu_kms.c | 2 +-
> drivers/i2c/busses/i2c-virtio.c | 2 +-
> drivers/iommu/virtio-iommu.c | 2 +-
> drivers/net/caif/caif_virtio.c | 2 +-
> drivers/net/virtio_net.c | 4 ++--
> drivers/net/wireless/mac80211_hwsim.c | 2 +-
> drivers/nvdimm/virtio_pmem.c | 2 +-
> drivers/rpmsg/virtio_rpmsg_bus.c | 2 +-
> drivers/scsi/virtio_scsi.c | 2 +-
> drivers/virtio/virtio.c | 5 +++++
> drivers/virtio/virtio_balloon.c | 2 +-
> drivers/virtio/virtio_input.c | 2 +-
> drivers/virtio/virtio_mem.c | 2 +-
> fs/fuse/virtio_fs.c | 4 ++--
> include/linux/virtio.h | 1 +
> net/9p/trans_virtio.c | 2 +-
> net/vmw_vsock/virtio_transport.c | 4 ++--
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 10+ messages in thread