From: "Michael S. Tsirkin" <mst@redhat.com>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Tiwei Bie <tiwei.bie@intel.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v3 1/2] virtio_ring: fix style of virtqueue_add_indirect_packed
Date: Tue, 19 Oct 2021 07:09:15 -0400 [thread overview]
Message-ID: <20211019070814-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20211019105657.9108-2-xuanzhuo@linux.alibaba.com>
On Tue, Oct 19, 2021 at 06:56:56PM +0800, Xuan Zhuo wrote:
> Fix the style problem of virtqueue_add_indirect_packed().
> Align arguments to the open ( to make it look prettier.
>
> Signed-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
> Acked-by: Jason Wang <jasowang@redhat.com>
fix the style problem -> make virtqueue_add_indirect_packed prettier.
same for subject
there's no style problem, certainly not the problem.
> ---
> drivers/virtio/virtio_ring.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
> index dd95dfd85e98..91a46c4da87d 100644
> --- a/drivers/virtio/virtio_ring.c
> +++ b/drivers/virtio/virtio_ring.c
> @@ -1050,12 +1050,12 @@ static struct vring_packed_desc *alloc_indirect_packed(unsigned int total_sg,
> }
>
> static int virtqueue_add_indirect_packed(struct vring_virtqueue *vq,
> - struct scatterlist *sgs[],
> - unsigned int total_sg,
> - unsigned int out_sgs,
> - unsigned int in_sgs,
> - void *data,
> - gfp_t gfp)
> + struct scatterlist *sgs[],
> + unsigned int total_sg,
> + unsigned int out_sgs,
> + unsigned int in_sgs,
> + void *data,
> + gfp_t gfp)
> {
> struct vring_packed_desc *desc;
> struct scatterlist *sg;
> --
> 2.31.0
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-10-19 11:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 10:56 [PATCH v3 0/2] virtio_ring: check desc == NULL when packed and indirect Xuan Zhuo
2021-10-19 10:56 ` [PATCH v3 1/2] virtio_ring: fix style of virtqueue_add_indirect_packed Xuan Zhuo
2021-10-19 11:09 ` Michael S. Tsirkin [this message]
2021-10-19 10:56 ` [PATCH v3 2/2] virtio_ring: check desc == NULL when packed and indirect Xuan Zhuo
2021-10-19 11:07 ` Michael S. Tsirkin
2021-10-19 11:12 ` Xuan Zhuo
2021-10-19 11:31 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211019070814-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=davem@davemloft.net \
--cc=tiwei.bie@intel.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox