From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: Eli Cohen <elic@nvidia.com>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH linux-next v4 2/8] vdpa: Introduce query of device config layout
Date: Mon, 25 Oct 2021 04:10:32 -0400 [thread overview]
Message-ID: <20211025041006-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <PH0PR12MB5481196C8E3509E55709C91FDC839@PH0PR12MB5481.namprd12.prod.outlook.com>
On Mon, Oct 25, 2021 at 06:59:56AM +0000, Parav Pandit wrote:
>
>
> > From: Jason Wang <jasowang@redhat.com>
> > Sent: Monday, October 25, 2021 11:36 AM
> >
> >
> > 在 2021/10/22 上午12:35, Parav Pandit 写道:
> > > Introduce a command to query a device config layout.
> > >
> > > An example query of network vdpa device:
> > >
> > > $ vdpa dev add name bar mgmtdev vdpasim_net
> > >
> > > $ vdpa dev config show
> > > bar: mac 00:35:09:19:48:05 link up link_announce false mtu 1500
> >
> >
> > Nit: it looks to me this patch doesn't expose link_announce but
> > max_virtqueue_pairs.
> It does expose the net status field that contains the link_announce.
> I missed to update the example for including max_vq_pairs.
> >
> > Other looks good.
> >
> > Thanks
Post a corrected commit log?
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-10-25 8:10 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 16:35 [PATCH linux-next v4 0/8] vdpa: enable user to set mac, mtu Parav Pandit via Virtualization
2021-10-21 16:35 ` [PATCH linux-next v4 1/8] vdpa: Introduce and use vdpa device get, set config helpers Parav Pandit via Virtualization
2021-10-25 6:03 ` Jason Wang
2021-10-25 11:24 ` Parav Pandit via Virtualization
2021-10-21 16:35 ` [PATCH linux-next v4 2/8] vdpa: Introduce query of device config layout Parav Pandit via Virtualization
2021-10-25 6:05 ` Jason Wang
2021-10-25 6:59 ` Parav Pandit via Virtualization
2021-10-25 8:10 ` Michael S. Tsirkin [this message]
2021-10-26 2:45 ` Jason Wang
2021-10-25 11:43 ` Parav Pandit via Virtualization
2021-10-21 16:35 ` [PATCH linux-next v4 3/8] vdpa: Use kernel coding style for structure comments Parav Pandit via Virtualization
2021-10-25 6:06 ` Jason Wang
2021-10-21 16:35 ` [PATCH linux-next v4 4/8] vdpa: Enable user to set mac and mtu of vdpa device Parav Pandit via Virtualization
2021-10-25 7:01 ` Jason Wang
2021-10-25 7:06 ` Parav Pandit via Virtualization
2021-10-25 8:08 ` Michael S. Tsirkin
2021-10-25 8:26 ` Parav Pandit via Virtualization
2021-10-26 2:40 ` Jason Wang
2021-10-21 16:35 ` [PATCH linux-next v4 5/8] vdpa_sim_net: Enable user to set mac address and mtu Parav Pandit via Virtualization
2021-10-25 7:02 ` Jason Wang
2021-10-25 7:11 ` Parav Pandit via Virtualization
2021-10-25 8:09 ` Michael S. Tsirkin
2021-10-25 8:10 ` Parav Pandit via Virtualization
2021-10-25 8:16 ` Michael S. Tsirkin
2021-10-21 16:35 ` [PATCH linux-next v4 6/8] vdpa/mlx5: Fix clearing of VIRTIO_NET_F_MAC feature bit Parav Pandit via Virtualization
2021-10-25 7:05 ` Jason Wang
2021-10-25 7:08 ` Parav Pandit via Virtualization
2021-10-26 2:42 ` Jason Wang
2021-10-21 16:35 ` [PATCH linux-next v4 7/8] vdpa/mlx5: Support configuration of MAC Parav Pandit via Virtualization
2021-10-25 7:07 ` Jason Wang
2021-10-21 16:35 ` [PATCH linux-next v4 8/8] vdpa/mlx5: Forward only packets with allowed MAC address Parav Pandit via Virtualization
2021-10-22 10:41 ` [PATCH linux-next v4 0/8] vdpa: enable user to set mac, mtu Michael S. Tsirkin
2021-10-22 15:07 ` Parav Pandit via Virtualization
2021-10-23 20:03 ` Michael S. Tsirkin
2021-10-23 21:15 ` Michael S. Tsirkin
2021-10-25 3:43 ` Parav Pandit via Virtualization
2021-10-25 7:27 ` Parav Pandit via Virtualization
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211025041006-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=elic@nvidia.com \
--cc=parav@nvidia.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).