* Re: [PATCH] net/mlx5_vdpa: Increase the limit on the number of virtuques
[not found] <20211124171953.57858-1-elic@nvidia.com>
@ 2021-11-24 23:55 ` Si-Wei Liu
[not found] ` <20211125070126.GB211101@mtl-vdi-166.wap.labs.mlnx>
2021-11-25 4:40 ` Jason Wang
2021-11-25 7:21 ` Michael S. Tsirkin
2 siblings, 1 reply; 6+ messages in thread
From: Si-Wei Liu @ 2021-11-24 23:55 UTC (permalink / raw)
To: Eli Cohen, mst, jasowang, virtualization; +Cc: lvivier, eperezma
On 11/24/2021 9:19 AM, Eli Cohen wrote:
> Increase the limit on the maximum number of supported virtqueues to 256
> to match hardware capabilities.
>
> Signed-off-by: Eli Cohen <elic@nvidia.com>
Acked-by: Si-Wei Liu <si-wei.liu@oracle.com>
> ---
> drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> index ed7a63e48335..8f2918a8efc6 100644
> --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> @@ -135,7 +135,7 @@ struct mlx5_vdpa_virtqueue {
> /* We will remove this limitation once mlx5_vdpa_alloc_resources()
> * provides for driver space allocation
> */
> -#define MLX5_MAX_SUPPORTED_VQS 16
> +#define MLX5_MAX_SUPPORTED_VQS 256
Did we check how much increase of memory footprint ended up with on
struct mlx5_vdpa_net?
-Siwei
>
> static bool is_index_valid(struct mlx5_vdpa_dev *mvdev, u16 idx)
> {
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net/mlx5_vdpa: Increase the limit on the number of virtuques
[not found] <20211124171953.57858-1-elic@nvidia.com>
2021-11-24 23:55 ` [PATCH] net/mlx5_vdpa: Increase the limit on the number of virtuques Si-Wei Liu
@ 2021-11-25 4:40 ` Jason Wang
2021-11-25 7:21 ` Michael S. Tsirkin
2 siblings, 0 replies; 6+ messages in thread
From: Jason Wang @ 2021-11-25 4:40 UTC (permalink / raw)
To: Eli Cohen; +Cc: Laurent Vivier, mst, virtualization, eperezma, si-wei.liu
On Thu, Nov 25, 2021 at 1:20 AM Eli Cohen <elic@nvidia.com> wrote:
>
> Increase the limit on the maximum number of supported virtqueues to 256
> to match hardware capabilities.
>
> Signed-off-by: Eli Cohen <elic@nvidia.com>
(A typo in the subject)
Other than this:
Acked-by: Jason Wang <jasowang@redhat.com>
> ---
> drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> index ed7a63e48335..8f2918a8efc6 100644
> --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> @@ -135,7 +135,7 @@ struct mlx5_vdpa_virtqueue {
> /* We will remove this limitation once mlx5_vdpa_alloc_resources()
> * provides for driver space allocation
> */
> -#define MLX5_MAX_SUPPORTED_VQS 16
> +#define MLX5_MAX_SUPPORTED_VQS 256
>
> static bool is_index_valid(struct mlx5_vdpa_dev *mvdev, u16 idx)
> {
> --
> 2.33.1
>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net/mlx5_vdpa: Increase the limit on the number of virtuques
[not found] <20211124171953.57858-1-elic@nvidia.com>
2021-11-24 23:55 ` [PATCH] net/mlx5_vdpa: Increase the limit on the number of virtuques Si-Wei Liu
2021-11-25 4:40 ` Jason Wang
@ 2021-11-25 7:21 ` Michael S. Tsirkin
[not found] ` <20211125072953.GA213638@mtl-vdi-166.wap.labs.mlnx>
2 siblings, 1 reply; 6+ messages in thread
From: Michael S. Tsirkin @ 2021-11-25 7:21 UTC (permalink / raw)
To: Eli Cohen; +Cc: lvivier, virtualization, eperezma, si-wei.liu
On Wed, Nov 24, 2021 at 07:19:53PM +0200, Eli Cohen wrote:
> Increase the limit on the maximum number of supported virtqueues to 256
> to match hardware capabilities.
Hmm and are we going to have to tweak it each time new hardware/firmware
is out? Can't this be queried in some way?
In fact there's a suggestion in code to remove the limitation -
any plans to do this?
> Signed-off-by: Eli Cohen <elic@nvidia.com>
typo in subject
> ---
> drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> index ed7a63e48335..8f2918a8efc6 100644
> --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> @@ -135,7 +135,7 @@ struct mlx5_vdpa_virtqueue {
> /* We will remove this limitation once mlx5_vdpa_alloc_resources()
> * provides for driver space allocation
> */
> -#define MLX5_MAX_SUPPORTED_VQS 16
> +#define MLX5_MAX_SUPPORTED_VQS 256
>
> static bool is_index_valid(struct mlx5_vdpa_dev *mvdev, u16 idx)
> {
> --
> 2.33.1
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net/mlx5_vdpa: Increase the limit on the number of virtuques
[not found] ` <20211125070126.GB211101@mtl-vdi-166.wap.labs.mlnx>
@ 2021-11-25 7:22 ` Michael S. Tsirkin
0 siblings, 0 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2021-11-25 7:22 UTC (permalink / raw)
To: Eli Cohen; +Cc: lvivier, virtualization, eperezma, Si-Wei Liu
On Thu, Nov 25, 2021 at 09:01:26AM +0200, Eli Cohen wrote:
> On Wed, Nov 24, 2021 at 03:55:34PM -0800, Si-Wei Liu wrote:
> >
> >
> > On 11/24/2021 9:19 AM, Eli Cohen wrote:
> > > Increase the limit on the maximum number of supported virtqueues to 256
> > > to match hardware capabilities.
> > >
> > > Signed-off-by: Eli Cohen <elic@nvidia.com>
> > Acked-by: Si-Wei Liu <si-wei.liu@oracle.com>
> > > ---
> > > drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > index ed7a63e48335..8f2918a8efc6 100644
> > > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > @@ -135,7 +135,7 @@ struct mlx5_vdpa_virtqueue {
> > > /* We will remove this limitation once mlx5_vdpa_alloc_resources()
> > > * provides for driver space allocation
> > > */
> > > -#define MLX5_MAX_SUPPORTED_VQS 16
> > > +#define MLX5_MAX_SUPPORTED_VQS 256
> > Did we check how much increase of memory footprint ended up with on struct
> > mlx5_vdpa_net?
> >
>
> The grow is 1048 * 240 = 251520 bytes.
Pls include this info in the commit log.
> > -Siwei
> >
> > > static bool is_index_valid(struct mlx5_vdpa_dev *mvdev, u16 idx)
> > > {
> >
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net/mlx5_vdpa: Increase the limit on the number of virtuques
[not found] ` <20211125072953.GA213638@mtl-vdi-166.wap.labs.mlnx>
@ 2021-11-25 16:22 ` Michael S. Tsirkin
2021-11-29 22:59 ` Si-Wei Liu
0 siblings, 1 reply; 6+ messages in thread
From: Michael S. Tsirkin @ 2021-11-25 16:22 UTC (permalink / raw)
To: Eli Cohen; +Cc: lvivier, virtualization, eperezma, si-wei.liu
On Thu, Nov 25, 2021 at 09:29:53AM +0200, Eli Cohen wrote:
> On Thu, Nov 25, 2021 at 02:21:43AM -0500, Michael S. Tsirkin wrote:
> > On Wed, Nov 24, 2021 at 07:19:53PM +0200, Eli Cohen wrote:
> > > Increase the limit on the maximum number of supported virtqueues to 256
> > > to match hardware capabilities.
> >
> > Hmm and are we going to have to tweak it each time new hardware/firmware
> > is out? Can't this be queried in some way?
>
> I thought to make the allocation dynamic once we have support for
> setting max queues through vdpa tool.
Well this will make things a bit harder to figure out then,
right now you can assume no vdpa tool support -> max 16 VQs.
The patch breaks this. Is there a motivation to up this right now,
or should we just wait a bit for vdpa tool support?
> > In fact there's a suggestion in code to remove the limitation -
> > any plans to do this?
>
> Can you be more speicifc, where?
It's right there in the patch:
/* We will remove this limitation once mlx5_vdpa_alloc_resources()
* provides for driver space allocation
*/
>
> >
> > > Signed-off-by: Eli Cohen <elic@nvidia.com>
> >
> > typo in subject
> What typo?
virtuques. ispell is your friend.
> >
> > > ---
> > > drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > index ed7a63e48335..8f2918a8efc6 100644
> > > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > @@ -135,7 +135,7 @@ struct mlx5_vdpa_virtqueue {
> > > /* We will remove this limitation once mlx5_vdpa_alloc_resources()
> > > * provides for driver space allocation
> > > */
> > > -#define MLX5_MAX_SUPPORTED_VQS 16
> > > +#define MLX5_MAX_SUPPORTED_VQS 256
> > >
> > > static bool is_index_valid(struct mlx5_vdpa_dev *mvdev, u16 idx)
> > > {
> > > --
> > > 2.33.1
> >
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net/mlx5_vdpa: Increase the limit on the number of virtuques
2021-11-25 16:22 ` Michael S. Tsirkin
@ 2021-11-29 22:59 ` Si-Wei Liu
0 siblings, 0 replies; 6+ messages in thread
From: Si-Wei Liu @ 2021-11-29 22:59 UTC (permalink / raw)
To: Michael S. Tsirkin, Eli Cohen; +Cc: lvivier, virtualization, eperezma
On 11/25/2021 8:22 AM, Michael S. Tsirkin wrote:
> On Thu, Nov 25, 2021 at 09:29:53AM +0200, Eli Cohen wrote:
>> On Thu, Nov 25, 2021 at 02:21:43AM -0500, Michael S. Tsirkin wrote:
>>> On Wed, Nov 24, 2021 at 07:19:53PM +0200, Eli Cohen wrote:
>>>> Increase the limit on the maximum number of supported virtqueues to 256
>>>> to match hardware capabilities.
>>> Hmm and are we going to have to tweak it each time new hardware/firmware
>>> is out? Can't this be queried in some way?
>> I thought to make the allocation dynamic once we have support for
>> setting max queues through vdpa tool.
>
> Well this will make things a bit harder to figure out then,
> right now you can assume no vdpa tool support -> max 16 VQs.
> The patch breaks this. Is there a motivation to up this right now,
> or should we just wait a bit for vdpa tool support?
+1 on waiting for vdpa tool support.
-Siwei
>
>>> In fact there's a suggestion in code to remove the limitation -
>>> any plans to do this?
>> Can you be more speicifc, where?
> It's right there in the patch:
>
> /* We will remove this limitation once mlx5_vdpa_alloc_resources()
> * provides for driver space allocation
> */
>>>> Signed-off-by: Eli Cohen <elic@nvidia.com>
>>> typo in subject
>> What typo?
> virtuques. ispell is your friend.
>
>>>> ---
>>>> drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
>>>> index ed7a63e48335..8f2918a8efc6 100644
>>>> --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
>>>> +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
>>>> @@ -135,7 +135,7 @@ struct mlx5_vdpa_virtqueue {
>>>> /* We will remove this limitation once mlx5_vdpa_alloc_resources()
>>>> * provides for driver space allocation
>>>> */
>>>> -#define MLX5_MAX_SUPPORTED_VQS 16
>>>> +#define MLX5_MAX_SUPPORTED_VQS 256
>>>>
>>>> static bool is_index_valid(struct mlx5_vdpa_dev *mvdev, u16 idx)
>>>> {
>>>> --
>>>> 2.33.1
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-11-29 23:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20211124171953.57858-1-elic@nvidia.com>
2021-11-24 23:55 ` [PATCH] net/mlx5_vdpa: Increase the limit on the number of virtuques Si-Wei Liu
[not found] ` <20211125070126.GB211101@mtl-vdi-166.wap.labs.mlnx>
2021-11-25 7:22 ` Michael S. Tsirkin
2021-11-25 4:40 ` Jason Wang
2021-11-25 7:21 ` Michael S. Tsirkin
[not found] ` <20211125072953.GA213638@mtl-vdi-166.wap.labs.mlnx>
2021-11-25 16:22 ` Michael S. Tsirkin
2021-11-29 22:59 ` Si-Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).