From: Stefano Garzarella <sgarzare@redhat.com>
To: Wei Wang <wei.w.wang@intel.com>
Cc: linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, davem@davemloft.net,
stefanha@redhat.com, mst@redhat.com
Subject: Re: [PATCH v2] virtio/vsock: fix the transport to work with VMADDR_CID_ANY
Date: Fri, 26 Nov 2021 09:53:41 +0100 [thread overview]
Message-ID: <20211126085341.wiab2frkcbmkg4ca@steredhat> (raw)
In-Reply-To: <20211126011823.1760-1-wei.w.wang@intel.com>
On Thu, Nov 25, 2021 at 08:18:23PM -0500, Wei Wang wrote:
>The VMADDR_CID_ANY flag used by a socket means that the socket isn't bound
>to any specific CID. For example, a host vsock server may want to be bound
>with VMADDR_CID_ANY, so that a guest vsock client can connect to the host
>server with CID=VMADDR_CID_HOST (i.e. 2), and meanwhile, a host vsock
>client can connect to the same local server with CID=VMADDR_CID_LOCAL
>(i.e. 1).
>
>The current implementation sets the destination socket's svm_cid to a
>fixed CID value after the first client's connection, which isn't an
>expected operation. For example, if the guest client first connects to the
>host server, the server's svm_cid gets set to VMADDR_CID_HOST, then other
>host clients won't be able to connect to the server anymore.
>
>Reproduce steps:
>1. Run the host server:
> socat VSOCK-LISTEN:1234,fork -
>2. Run a guest client to connect to the host server:
> socat - VSOCK-CONNECT:2:1234
>3. Run a host client to connect to the host server:
> socat - VSOCK-CONNECT:1:1234
>
>Without this patch, step 3. above fails to connect, and socat complains
>"socat[1720] E connect(5, AF=40 cid:1 port:1234, 16): Connection
>reset by peer".
>With this patch, the above works well.
>
>Fixes: c0cfa2d8a788 ("vsock: add multi-transports support")
>Signed-off-by: Wei Wang <wei.w.wang@intel.com>
>---
> net/vmw_vsock/virtio_transport_common.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Usually fixes for net/vmw_vsock/* are applied through the net tree
(netdev@vger.kernel.org) that seems not CCed. Please use
./scripts/get_maintainer.pl next time.
Maybe this one can be queued by Michael, let's wait a bit, otherwise
please resend CCing netdev and using "net" tag.
Anyway the patch LGTM:
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-11-26 8:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 1:18 [PATCH v2] virtio/vsock: fix the transport to work with VMADDR_CID_ANY Wei Wang
2021-11-26 8:53 ` Stefano Garzarella [this message]
2021-11-30 1:34 ` Wang, Wei W
2021-11-30 23:21 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211126085341.wiab2frkcbmkg4ca@steredhat \
--to=sgarzare@redhat.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=wei.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox