* [PATCH v1] vdpa: Consider device id larger than 31
@ 2021-11-30 4:29 Parav Pandit via Virtualization
2021-11-30 23:34 ` Michael S. Tsirkin
0 siblings, 1 reply; 2+ messages in thread
From: Parav Pandit via Virtualization @ 2021-11-30 4:29 UTC (permalink / raw)
To: virtualization, mst, jasowang
Cc: kbuild-all, lkp, kbuild, linux-kernel, edumazet, elic,
dan.carpenter
virtio device id value can be more than 31. Hence, use BIT_ULL in
assignment.
Fixes: 33b347503f01 ("vdpa: Define vdpa mgmt device, ops and a netlink interface")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Parav Pandit <parav@nvidia.com>
Acked-by: Jason Wang <jasowang@redhat.com>
---
changelog:
v0->v1:
- supporting device id up to 63
---
drivers/vdpa/vdpa.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/vdpa/vdpa.c b/drivers/vdpa/vdpa.c
index 7332a74a4b00..09bbe53c3ac4 100644
--- a/drivers/vdpa/vdpa.c
+++ b/drivers/vdpa/vdpa.c
@@ -404,7 +404,8 @@ static int vdpa_mgmtdev_fill(const struct vdpa_mgmt_dev *mdev, struct sk_buff *m
goto msg_err;
while (mdev->id_table[i].device) {
- supported_classes |= BIT(mdev->id_table[i].device);
+ if (mdev->id_table[i].device <= 63)
+ supported_classes |= BIT_ULL(mdev->id_table[i].device);
i++;
}
--
2.26.2
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] vdpa: Consider device id larger than 31
2021-11-30 4:29 [PATCH v1] vdpa: Consider device id larger than 31 Parav Pandit via Virtualization
@ 2021-11-30 23:34 ` Michael S. Tsirkin
0 siblings, 0 replies; 2+ messages in thread
From: Michael S. Tsirkin @ 2021-11-30 23:34 UTC (permalink / raw)
To: Parav Pandit
Cc: kbuild-all, lkp, linux-kernel, virtualization, edumazet, elic,
kbuild, dan.carpenter
On Tue, Nov 30, 2021 at 06:29:49AM +0200, Parav Pandit wrote:
> virtio device id value can be more than 31. Hence, use BIT_ULL in
> assignment.
>
> Fixes: 33b347503f01 ("vdpa: Define vdpa mgmt device, ops and a netlink interface")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Parav Pandit <parav@nvidia.com>
> Acked-by: Jason Wang <jasowang@redhat.com>
> ---
> changelog:
> v0->v1:
> - supporting device id up to 63
> ---
> drivers/vdpa/vdpa.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/vdpa/vdpa.c b/drivers/vdpa/vdpa.c
> index 7332a74a4b00..09bbe53c3ac4 100644
> --- a/drivers/vdpa/vdpa.c
> +++ b/drivers/vdpa/vdpa.c
> @@ -404,7 +404,8 @@ static int vdpa_mgmtdev_fill(const struct vdpa_mgmt_dev *mdev, struct sk_buff *m
> goto msg_err;
>
> while (mdev->id_table[i].device) {
> - supported_classes |= BIT(mdev->id_table[i].device);
> + if (mdev->id_table[i].device <= 63)
> + supported_classes |= BIT_ULL(mdev->id_table[i].device);
> i++;
> }
Not for this release, but a for loop will be cleaner here.
> --
> 2.26.2
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-30 23:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-30 4:29 [PATCH v1] vdpa: Consider device id larger than 31 Parav Pandit via Virtualization
2021-11-30 23:34 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).