From: "Michael S. Tsirkin" <mst@redhat.com>
To: 李东升 <lidongsheng@dayudpu.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
virtualization <virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH] virtio_vdpa: Support surprise removal of virtio vdpa device
Date: Tue, 11 Jan 2022 06:52:17 -0500 [thread overview]
Message-ID: <20220111065033-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <tencent_7A45E1E967F13AE14B061269@qq.com>
On Tue, Jan 11, 2022 at 11:36:42AM +0800, 李东升 wrote:
> When virtio vdpa device removed, the abnormal damage of the device cannot be
> perceived normally, which will cause problems similar to:
>
> 43bb40c5b926
Should include the subject of the patch too.
> Hence, add the ability to abort the command on surprise removal
>
> Signed-off-by: dongsheng li <lidongsheng@dayudpu.com>
When removing gracefully,
I am not sure we should break device unconditionally like this
before giving drivers a chance to clean up.
Should we just do it for surprise removal?
> ---
> drivers/virtio/virtio_vdpa.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/virtio/virtio_vdpa.c b/drivers/virtio/virtio_vdpa.c
> index 4a9ddb44b2a7..fd930409d190 100644
> --- a/drivers/virtio/virtio_vdpa.c
> +++ b/drivers/virtio/virtio_vdpa.c
> @@ -374,6 +374,7 @@ static void virtio_vdpa_remove(struct vdpa_device *vdpa)
> {
> struct virtio_vdpa_device *vd_dev = vdpa_get_drvdata(vdpa);
>
> + virtio_break_device(vd_dev->vdev);
> unregister_virtio_device(&vd_dev->vdev);
> }
>
> --
> 2.17.1
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-01-11 11:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tencent_7A45E1E967F13AE14B061269@qq.com>
2022-01-11 4:37 ` [PATCH] virtio_vdpa: Support surprise removal of virtio vdpa device Jason Wang
2022-01-11 11:52 ` Michael S. Tsirkin [this message]
2022-01-12 2:23 ` Jason Wang
2022-01-12 6:30 ` Michael S. Tsirkin
2022-01-12 7:52 ` Jason Wang
2022-01-12 14:52 ` Michael S. Tsirkin
[not found] ` <tencent_18F8A88D22E327230EF313BE@qq.com>
2022-01-12 15:02 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220111065033-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=lidongsheng@dayudpu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).