From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gavin Shan <gshan@redhat.com>
Cc: Jonathan.Cameron@huawei.com, shan.gavin@gmail.com,
linux-arm-kernel@lists.infradead.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v3] drivers/virtio: Enable virtio mem for ARM64
Date: Wed, 19 Jan 2022 02:39:46 -0500 [thread overview]
Message-ID: <20220119022611-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20220119010551.181405-1-gshan@redhat.com>
On Wed, Jan 19, 2022 at 09:05:51AM +0800, Gavin Shan wrote:
> This enables virtio-mem device support by allowing to enable the
> corresponding kernel config option (CONFIG_VIRTIO_MEM) on the
> architecture.
>
> Signed-off-by: Gavin Shan <gshan@redhat.com>
> Acked-by: David Hildenbrand <david@redhat.com>
> Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> v3: Pick ack-by tags from Jonathan and Michael
> ---
> drivers/virtio/Kconfig | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
> index 34f80b7a8a64..74c8b0c7bc33 100644
> --- a/drivers/virtio/Kconfig
> +++ b/drivers/virtio/Kconfig
> @@ -106,7 +106,7 @@ config VIRTIO_BALLOON
> config VIRTIO_MEM
> tristate "Virtio mem driver"
> default m
> - depends on X86_64
> + depends on X86_64 || ARM64
> depends on VIRTIO
> depends on MEMORY_HOTPLUG
> depends on MEMORY_HOTREMOVE
> @@ -116,8 +116,9 @@ config VIRTIO_MEM
> This driver provides access to virtio-mem paravirtualized memory
> devices, allowing to hotplug and hotunplug memory.
>
> - This driver was only tested under x86-64, but should theoretically
> - work on all architectures that support memory hotplug and hotremove.
> + This driver was only tested under x86-64 and arm64, but should
> + theoretically work on all architectures that support memory hotplug
> + and hotremove.
>
BTW isn't there a symbol saying "memory hotplug" that we can depend on?
> If unsure, say M.
>
> --
> 2.23.0
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-01-19 7:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 1:05 [PATCH v3] drivers/virtio: Enable virtio mem for ARM64 Gavin Shan
2022-01-19 7:39 ` Michael S. Tsirkin [this message]
2022-01-19 7:46 ` Gavin Shan
2022-01-19 8:35 ` David Hildenbrand
2022-02-04 13:24 ` Michael S. Tsirkin
2022-02-04 13:29 ` David Hildenbrand
2022-02-04 14:04 ` Michael S. Tsirkin
2022-02-04 14:25 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220119022611-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=gshan@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=shan.gavin@gmail.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).