Linux virtualization list
 help / color / mirror / Atom feed
* [PATCH] virtio: drop default for virtio-mem
@ 2022-02-25 11:48 Michael S. Tsirkin
  2022-02-25 13:30 ` David Hildenbrand
  0 siblings, 1 reply; 2+ messages in thread
From: Michael S. Tsirkin @ 2022-02-25 11:48 UTC (permalink / raw)
  To: linux-kernel; +Cc: virtualization

There's no special reason why virtio-mem needs a default that's
different from what kconfig provides, any more than e.g. virtio blk.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 drivers/virtio/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
index 34f80b7a8a64..492fc26f0b65 100644
--- a/drivers/virtio/Kconfig
+++ b/drivers/virtio/Kconfig
@@ -105,7 +105,6 @@ config VIRTIO_BALLOON
 
 config VIRTIO_MEM
 	tristate "Virtio mem driver"
-	default m
 	depends on X86_64
 	depends on VIRTIO
 	depends on MEMORY_HOTPLUG
-- 
MST

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] virtio: drop default for virtio-mem
  2022-02-25 11:48 [PATCH] virtio: drop default for virtio-mem Michael S. Tsirkin
@ 2022-02-25 13:30 ` David Hildenbrand
  0 siblings, 0 replies; 2+ messages in thread
From: David Hildenbrand @ 2022-02-25 13:30 UTC (permalink / raw)
  To: Michael S. Tsirkin, linux-kernel; +Cc: virtualization

On 25.02.22 12:48, Michael S. Tsirkin wrote:
> There's no special reason why virtio-mem needs a default that's
> different from what kconfig provides, any more than e.g. virtio blk.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  drivers/virtio/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
> index 34f80b7a8a64..492fc26f0b65 100644
> --- a/drivers/virtio/Kconfig
> +++ b/drivers/virtio/Kconfig
> @@ -105,7 +105,6 @@ config VIRTIO_BALLOON
>  
>  config VIRTIO_MEM
>  	tristate "Virtio mem driver"
> -	default m
>  	depends on X86_64
>  	depends on VIRTIO
>  	depends on MEMORY_HOTPLUG

Yeah, why not

Acked-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-02-25 13:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-25 11:48 [PATCH] virtio: drop default for virtio-mem Michael S. Tsirkin
2022-02-25 13:30 ` David Hildenbrand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox