* Re: [PATCH v3 05/11] PCI: Use driver_set_override() instead of open-coding
[not found] <20220227135214.145599-6-krzysztof.kozlowski@canonical.com>
@ 2022-02-28 20:06 ` Bjorn Helgaas
0 siblings, 0 replies; only message in thread
From: Bjorn Helgaas @ 2022-02-28 20:06 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-hyperv, Stuart Yoder, Rafael J. Wysocki, linux-pci,
linux-remoteproc, alsa-devel, Bjorn Andersson,
Srinivas Kandagatla, Vineeth Vijayan, Alexander Gordeev,
Fabio Estevam, linux-clk, linux-s390, Wei Liu, Stephen Hemminger,
Abel Vesa, Michael S. Tsirkin, Dexuan Cui, Linus Torvalds,
Andy Gross, NXP Linux Team, Heiko Carstens, Vasily Gorbik,
linux-arm-msm, Sascha Hauer, linux-spi, Mark Brown,
Rasmus Villemoes, Bjorn Helgaas, virtualization, linux-arm-kernel,
Laurentiu Tudor, Mathieu Poirier, Greg Kroah-Hartman,
Haiyang Zhang, Peter Oberparleiter, linux-kernel, Sven Schnelle,
Shawn Guo
On Sun, Feb 27, 2022 at 02:52:08PM +0100, Krzysztof Kozlowski wrote:
> Use a helper for seting driver_override to reduce amount of duplicated
> code. Make the driver_override field const char, because it is not
> modified by the core and it matches other subsystems.
s/seting/setting/
or even better, s/for seting/to set/
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> - char *driver_override; /* Driver name to force a match */
> + /*
> + * Driver name to force a match.
> + * Do not set directly, because core frees it.
> + * Use driver_set_override() to set or clear it.
Wrap this comment to fill 78 columns or so.
> + */
> + const char *driver_override;
>
> unsigned long priv_flags; /* Private flags for the PCI driver */
>
> --
> 2.32.0
>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] only message in thread