From: "Michael S. Tsirkin" <mst@redhat.com>
To: kernel test robot <lkp@intel.com>
Cc: Andrew Melnychenko <andrew@daynix.com>,
kbuild-all@lists.01.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
yuri.benditovich@daynix.com, yan@daynix.com, kuba@kernel.org,
davem@davemloft.net
Subject: Re: [PATCH v4 3/4] drivers/net/virtio_net: Added RSS hash report.
Date: Fri, 4 Mar 2022 03:08:04 -0500 [thread overview]
Message-ID: <20220304030742-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <202202230342.HPYe6dHA-lkp@intel.com>
On Wed, Feb 23, 2022 at 03:15:28AM +0800, kernel test robot wrote:
> Hi Andrew,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on mst-vhost/linux-next]
> [also build test WARNING on net/master horms-ipvs/master net-next/master linus/master v5.17-rc5 next-20220217]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
Andrew,
do you plan to fix this?
> url: https://github.com/0day-ci/linux/commits/Andrew-Melnychenko/RSS-support-for-VirtioNet/20220222-200334
> base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
> config: i386-randconfig-s002-20220221 (https://download.01.org/0day-ci/archive/20220223/202202230342.HPYe6dHA-lkp@intel.com/config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> reproduce:
> # apt-get install sparse
> # sparse version: v0.6.4-dirty
> # https://github.com/0day-ci/linux/commit/4fda71c17afd24d8afb675baa0bb14dbbc6cd23c
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review Andrew-Melnychenko/RSS-support-for-VirtioNet/20220222-200334
> git checkout 4fda71c17afd24d8afb675baa0bb14dbbc6cd23c
> # save the config file to linux build tree
> mkdir build_dir
> make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
>
> sparse warnings: (new ones prefixed by >>)
> drivers/net/virtio_net.c:1160:25: sparse: sparse: restricted __le16 degrades to integer
> drivers/net/virtio_net.c:1160:25: sparse: sparse: restricted __le16 degrades to integer
> drivers/net/virtio_net.c:1160:25: sparse: sparse: restricted __le16 degrades to integer
> drivers/net/virtio_net.c:1160:25: sparse: sparse: restricted __le16 degrades to integer
> drivers/net/virtio_net.c:1160:25: sparse: sparse: restricted __le16 degrades to integer
> drivers/net/virtio_net.c:1160:25: sparse: sparse: restricted __le16 degrades to integer
> drivers/net/virtio_net.c:1160:25: sparse: sparse: restricted __le16 degrades to integer
> drivers/net/virtio_net.c:1160:25: sparse: sparse: restricted __le16 degrades to integer
> drivers/net/virtio_net.c:1160:25: sparse: sparse: restricted __le16 degrades to integer
> >> drivers/net/virtio_net.c:1178:35: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected unsigned int [usertype] hash @@ got restricted __le32 const [usertype] hash_value @@
> drivers/net/virtio_net.c:1178:35: sparse: expected unsigned int [usertype] hash
> drivers/net/virtio_net.c:1178:35: sparse: got restricted __le32 const [usertype] hash_value
>
> vim +1178 drivers/net/virtio_net.c
>
> 1151
> 1152 static void virtio_skb_set_hash(const struct virtio_net_hdr_v1_hash *hdr_hash,
> 1153 struct sk_buff *skb)
> 1154 {
> 1155 enum pkt_hash_types rss_hash_type;
> 1156
> 1157 if (!hdr_hash || !skb)
> 1158 return;
> 1159
> 1160 switch (hdr_hash->hash_report) {
> 1161 case VIRTIO_NET_HASH_REPORT_TCPv4:
> 1162 case VIRTIO_NET_HASH_REPORT_UDPv4:
> 1163 case VIRTIO_NET_HASH_REPORT_TCPv6:
> 1164 case VIRTIO_NET_HASH_REPORT_UDPv6:
> 1165 case VIRTIO_NET_HASH_REPORT_TCPv6_EX:
> 1166 case VIRTIO_NET_HASH_REPORT_UDPv6_EX:
> 1167 rss_hash_type = PKT_HASH_TYPE_L4;
> 1168 break;
> 1169 case VIRTIO_NET_HASH_REPORT_IPv4:
> 1170 case VIRTIO_NET_HASH_REPORT_IPv6:
> 1171 case VIRTIO_NET_HASH_REPORT_IPv6_EX:
> 1172 rss_hash_type = PKT_HASH_TYPE_L3;
> 1173 break;
> 1174 case VIRTIO_NET_HASH_REPORT_NONE:
> 1175 default:
> 1176 rss_hash_type = PKT_HASH_TYPE_NONE;
> 1177 }
> > 1178 skb_set_hash(skb, hdr_hash->hash_value, rss_hash_type);
> 1179 }
> 1180
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-03-04 8:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 12:00 [PATCH v4 0/4] RSS support for VirtioNet Andrew Melnychenko
2022-02-22 12:00 ` [PATCH v4 1/4] drivers/net/virtio_net: Fixed padded vheader to use v1 with hash Andrew Melnychenko
2022-02-22 12:00 ` [PATCH v4 2/4] drivers/net/virtio_net: Added basic RSS support Andrew Melnychenko
2022-02-22 12:00 ` [PATCH v4 3/4] drivers/net/virtio_net: Added RSS hash report Andrew Melnychenko
2022-02-22 19:15 ` kernel test robot
2022-03-04 8:08 ` Michael S. Tsirkin [this message]
2022-03-04 13:09 ` Andrew Melnichenko
2022-02-22 12:00 ` [PATCH v4 4/4] drivers/net/virtio_net: Added RSS hash report control Andrew Melnychenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220304030742-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=andrew@daynix.com \
--cc=davem@davemloft.net \
--cc=kbuild-all@lists.01.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=yan@daynix.com \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).