virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Eli Cohen <elic@nvidia.com>
Cc: lvivier@redhat.com, virtualization@lists.linux-foundation.org,
	eperezma@redhat.com, si-wei.liu@oracle.com
Subject: Re: [PATCH v1 0/2] Show statistics for a vdpa device
Date: Fri, 4 Mar 2022 11:06:13 -0500	[thread overview]
Message-ID: <20220304110555-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20220216080022.56707-1-elic@nvidia.com>

On Wed, Feb 16, 2022 at 10:00:20AM +0200, Eli Cohen wrote:
> The following two patch series adds support to read vendor statistics
> for a vdpa device.
> 
> The first patch lays the ground to allow an upstream driver to provide
> statistics in the form of an attribute name/attribute value pairs.
> 
> The second patch implements this for mlx5_vdpa which gives received
> descriptors and completed descriptors information for all the
> virtqueues. 
> 
> V0 -> V1:
> 1. Function name changes to emphasize the fact that this is for vendor
> statistics.
> 2. Increase the size of VDPA_ATTR_DEV_QUEUE_INDEX to U32 so it can
> handle the entire range of virtqueue indices. 
> 3. Change output string names to avoid abbreviations.

Jason had a minor comment. Were you goint to address it?

> Eli Cohen (2):
>   vdpa: Add support for querying vendor statistics
>   vdpa/mlx5: Add support for reading descriptor statistics
> 
>  drivers/vdpa/mlx5/core/mlx5_vdpa.h |   2 +
>  drivers/vdpa/mlx5/net/mlx5_vnet.c  | 156 +++++++++++++++++++++++++++++
>  drivers/vdpa/vdpa.c                | 129 ++++++++++++++++++++++++
>  include/linux/mlx5/mlx5_ifc.h      |   1 +
>  include/linux/mlx5/mlx5_ifc_vdpa.h |  39 ++++++++
>  include/linux/vdpa.h               |   5 +
>  include/uapi/linux/vdpa.h          |   7 ++
>  7 files changed, 339 insertions(+)
> 
> -- 
> 2.34.1

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

      parent reply	other threads:[~2022-03-04 16:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220216080022.56707-1-elic@nvidia.com>
     [not found] ` <20220216080022.56707-2-elic@nvidia.com>
2022-02-16 18:49   ` [PATCH v1 1/2] vdpa: Add support for querying vendor statistics Si-Wei Liu
     [not found]     ` <20220217064619.GB86497@mtl-vdi-166.wap.labs.mlnx>
2022-03-04 22:34       ` Si-Wei Liu
     [not found]         ` <DM8PR12MB5400E80073521E898056578BAB089@DM8PR12MB5400.namprd12.prod.outlook.com>
2022-03-08  6:15           ` Si-Wei Liu
     [not found]             ` <DM8PR12MB5400E03D7AD7833CEBF8DF9DAB099@DM8PR12MB5400.namprd12.prod.outlook.com>
2022-03-09  2:39               ` Jason Wang
2022-03-09  3:32               ` Si-Wei Liu
     [not found]                 ` <DM8PR12MB540086CCD1F535668D05E546AB0A9@DM8PR12MB5400.namprd12.prod.outlook.com>
2022-03-10  1:45                   ` Si-Wei Liu
     [not found]                     ` <DM8PR12MB54000042A48FDFA446EFE792AB0E9@DM8PR12MB5400.namprd12.prod.outlook.com>
2022-03-14  6:25                       ` Jason Wang
2022-03-15  8:11                         ` Si-Wei Liu
2022-03-15  7:53                       ` Si-Wei Liu
     [not found]                         ` <DM8PR12MB540054565515158F9209723EAB109@DM8PR12MB5400.namprd12.prod.outlook.com>
2022-03-16  6:52                           ` Si-Wei Liu
     [not found]                             ` <DM8PR12MB5400E7B2359FE4797F190AC5AB119@DM8PR12MB5400.namprd12.prod.outlook.com>
2022-03-16 22:00                               ` Si-Wei Liu
2022-03-17  2:32                                 ` Jason Wang
2022-03-18  0:58                                   ` Si-Wei Liu
2022-03-18  2:27                                     ` Jason Wang
2022-03-19  5:18                                       ` Si-Wei Liu
2022-03-22  3:51                                         ` Jason Wang
2022-03-03  7:53   ` Jason Wang
2022-03-07 11:03   ` Parav Pandit via Virtualization
     [not found] ` <20220216080022.56707-3-elic@nvidia.com>
2022-03-03  7:55   ` [PATCH v1 2/2] vdpa/mlx5: Add support for reading descriptor statistics Jason Wang
2022-03-04 16:06 ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220304110555-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=elic@nvidia.com \
    --cc=eperezma@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=si-wei.liu@oracle.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).