From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jiyong Park <jiyong@google.com>
Cc: adelva@google.com, kvm@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, stefanha@redhat.com,
kuba@kernel.org, davem@davemloft.net
Subject: Re: [PATCH 0/2] vsock: cycle only on its own socket
Date: Thu, 10 Mar 2022 07:59:15 -0500 [thread overview]
Message-ID: <20220310075854-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20220310075554-mutt-send-email-mst@kernel.org>
On Thu, Mar 10, 2022 at 07:57:58AM -0500, Michael S. Tsirkin wrote:
> On Thu, Mar 10, 2022 at 09:54:23PM +0900, Jiyong Park wrote:
> > Hi Stefano,
> >
> > As suggested [1], I've made two patches for easier backporting without
> > breaking KMI.
> >
> > PATCH 1 fixes the very issue of cycling all vsocks regardless of the
> > transport and shall be backported.
> >
> > PATCH 2 is a refactor of PATCH 1 that forces the filtering to all
> > (including future) uses of vsock_for_each_connected_socket.
> >
> > Thanks,
> >
> > [1] https://lore.kernel.org/lkml/20220310110036.fgy323c4hvk3mziq@sgarzare-redhat/
>
>
> OK that's better. Pls do include changelog in the future.
>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
Hmm actually I think I have a better idea. Hang on.
>
>
> > Jiyong Park (2):
> > vsock: each transport cycles only on its own sockets
> > vsock: refactor vsock_for_each_connected_socket
> >
> > drivers/vhost/vsock.c | 3 ++-
> > include/net/af_vsock.h | 3 ++-
> > net/vmw_vsock/af_vsock.c | 9 +++++++--
> > net/vmw_vsock/virtio_transport.c | 7 +++++--
> > net/vmw_vsock/vmci_transport.c | 3 ++-
> > 5 files changed, 18 insertions(+), 7 deletions(-)
> >
> >
> > base-commit: 3bf7edc84a9eb4007dd9a0cb8878a7e1d5ec6a3b
> > --
> > 2.35.1.723.g4982287a31-goog
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-03-10 12:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220310125425.4193879-1-jiyong@google.com>
2022-03-10 12:57 ` [PATCH 0/2] vsock: cycle only on its own socket Michael S. Tsirkin
2022-03-10 12:59 ` Michael S. Tsirkin [this message]
[not found] ` <20220310125425.4193879-2-jiyong@google.com>
2022-03-10 13:01 ` [PATCH 1/2] vsock: each transport cycles only on its own sockets Michael S. Tsirkin
[not found] ` <CALeUXe4V=6WhavV5d0XN_EjtZ9=0_5rD9ZfvQ77M1W4HpYh_2Q@mail.gmail.com>
2022-03-10 13:16 ` Michael S. Tsirkin
2022-03-10 13:18 ` Stefano Garzarella
2022-03-11 2:55 ` kernel test robot
[not found] ` <20220310125425.4193879-3-jiyong@google.com>
2022-03-10 13:09 ` [PATCH 2/2] vsock: refactor vsock_for_each_connected_socket Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220310075854-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=adelva@google.com \
--cc=davem@davemloft.net \
--cc=jiyong@google.com \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).