From: "Michael S. Tsirkin" <mst@redhat.com>
To: Suwan Kim <suwan.kim027@gmail.com>
Cc: linux-block@vger.kernel.org, pbonzini@redhat.com,
stefanha@redhat.com, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio-blk: support polling I/O
Date: Fri, 11 Mar 2022 10:38:07 -0500 [thread overview]
Message-ID: <20220311103549-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20220311152832.17703-1-suwan.kim027@gmail.com>
On Sat, Mar 12, 2022 at 12:28:32AM +0900, Suwan Kim wrote:
> diff --git a/include/uapi/linux/virtio_blk.h b/include/uapi/linux/virtio_blk.h
> index d888f013d9ff..3fcaf937afe1 100644
> --- a/include/uapi/linux/virtio_blk.h
> +++ b/include/uapi/linux/virtio_blk.h
> @@ -119,8 +119,9 @@ struct virtio_blk_config {
> * deallocation of one or more of the sectors.
> */
> __u8 write_zeroes_may_unmap;
> + __u8 unused1;
>
> - __u8 unused1[3];
> + __virtio16 num_poll_queues;
> } __attribute__((packed));
Same as any virtio UAPI change, this has to go through the virtio TC.
In particular I don't think gating a new config field on
an existing feature flag is a good idea.
> /*
> --
> 2.26.3
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next parent reply other threads:[~2022-03-11 15:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220311152832.17703-1-suwan.kim027@gmail.com>
2022-03-11 15:38 ` Michael S. Tsirkin [this message]
[not found] ` <YitzuxYHywdCRKVO@localhost.localdomain>
2022-03-11 16:18 ` [PATCH] virtio-blk: support polling I/O Michael S. Tsirkin
[not found] ` <c91ad1e9-8c5b-ff1e-7e7f-8590ea6c67e8@nvidia.com>
[not found] ` <Yi8OSE2hYoS8rSEo@localhost.localdomain>
[not found] ` <e441429b-90ef-a2e4-1365-3f55c7ff21d0@nvidia.com>
2022-03-14 11:15 ` Michael S. Tsirkin
[not found] ` <Yi9BeVK3GbFrxIgB@localhost.localdomain>
2022-03-14 15:12 ` Michael S. Tsirkin
[not found] ` <d9121e3c-abe5-fe4d-8088-8339c418c7a8@nvidia.com>
2022-03-14 15:15 ` Michael S. Tsirkin
[not found] ` <332c35ec-734b-d2bd-dd0f-c577b1c6174b@nvidia.com>
2022-03-14 22:22 ` Michael S. Tsirkin
2022-03-14 6:14 ` Jason Wang
[not found] ` <Yi82BL9KecQsVfgX@localhost.localdomain>
2022-03-14 14:48 ` Stefan Hajnoczi
2022-03-15 8:59 ` Jason Wang
[not found] ` <YjCmBkjgtQZffiXw@localhost.localdomain>
2022-03-15 14:53 ` Michael S. Tsirkin
2022-03-16 2:02 ` Jason Wang
[not found] ` <YjIDIjUwuwkfRS2d@localhost.localdomain>
[not found] ` <96836799-8d1f-3865-e2e7-721150445e6a@nvidia.com>
2022-03-16 16:00 ` Stefan Hajnoczi
2022-03-17 2:20 ` Jason Wang
2022-03-14 15:19 ` Stefan Hajnoczi
[not found] ` <YjCauO0lb2mzQENJ@localhost.localdomain>
2022-03-16 12:20 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220311103549-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=stefanha@redhat.com \
--cc=suwan.kim027@gmail.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).