From: "Michael S. Tsirkin" <mst@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v8 01/16] virtio: add helper virtqueue_get_vring_max_size()
Date: Mon, 14 Mar 2022 07:18:27 -0400 [thread overview]
Message-ID: <20220314071819-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <87cziohnhr.fsf@redhat.com>
On Mon, Mar 14, 2022 at 10:50:08AM +0100, Cornelia Huck wrote:
> On Mon, Mar 14 2022, Xuan Zhuo <xuanzhuo@linux.alibaba.com> wrote:
>
> > Record the maximum queue num supported by the device.
> >
> > virtio-net can display the maximum (supported by hardware) ring size in
> > ethtool -g eth0.
> >
> > When the subsequent patch implements vring reset, it can judge whether
> > the ring size passed by the driver is legal based on this.
> >
> > Signed-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
> > Acked-by: Jason Wang <jasowang@redhat.com>
> > ---
> > drivers/virtio/virtio_mmio.c | 2 ++
> > drivers/virtio/virtio_pci_legacy.c | 2 ++
> > drivers/virtio/virtio_pci_modern.c | 2 ++
> > drivers/virtio/virtio_ring.c | 14 ++++++++++++++
> > include/linux/virtio.h | 2 ++
> > 5 files changed, 22 insertions(+)
>
> Don't you also need to init this for ccw (even though we won't do ring
> reset there), just for completeness? (Any other transports?)
rpmsg?
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-03-14 11:18 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 9:34 [PATCH v8 00/16] virtio pci support VIRTIO_F_RING_RESET (refactor vring) Xuan Zhuo
2022-03-14 9:34 ` [PATCH v8 01/16] virtio: add helper virtqueue_get_vring_max_size() Xuan Zhuo
2022-03-14 9:50 ` Cornelia Huck
2022-03-14 11:18 ` Michael S. Tsirkin [this message]
2022-03-14 11:21 ` Xuan Zhuo
2022-03-22 6:24 ` Michael S. Tsirkin
2022-03-14 9:34 ` [PATCH v8 02/16] virtio: struct virtio_config_ops add callbacks for queue_reset Xuan Zhuo
2022-03-14 9:34 ` [PATCH v8 03/16] virtio_ring: update the document of the virtqueue_detach_unused_buf for queue reset Xuan Zhuo
2022-03-14 9:34 ` [PATCH v8 04/16] virtio_ring: remove the arg vq of vring_alloc_desc_extra() Xuan Zhuo
2022-03-22 5:49 ` Jason Wang
2022-03-14 9:34 ` [PATCH v8 05/16] virtio_ring: extract the logic of freeing vring Xuan Zhuo
2022-03-14 9:34 ` [PATCH v8 06/16] virtio_ring: split: extract the logic of alloc queue Xuan Zhuo
2022-03-14 9:34 ` [PATCH v8 07/16] virtio_ring: split: extract the logic of alloc state and extra Xuan Zhuo
2022-03-22 6:33 ` Jason Wang
2022-03-24 8:28 ` Xuan Zhuo
2022-03-14 9:34 ` [PATCH v8 08/16] virtio_ring: split: extract the logic of attach vring Xuan Zhuo
2022-03-14 9:34 ` [PATCH v8 09/16] virtio_ring: split: extract the logic of vq init Xuan Zhuo
2022-03-14 9:34 ` [PATCH v8 10/16] virtio_ring: split: implement virtqueue_resize_split() Xuan Zhuo
2022-03-22 6:30 ` Jason Wang
2022-03-24 8:44 ` Xuan Zhuo
2022-03-30 3:48 ` Jason Wang
2022-03-30 6:13 ` Xuan Zhuo
2022-03-30 6:57 ` Jason Wang
2022-03-14 9:34 ` [PATCH v8 11/16] virtio_ring: packed: extract the logic of alloc queue Xuan Zhuo
2022-03-22 6:38 ` Jason Wang
2022-03-24 8:28 ` Xuan Zhuo
2022-03-30 3:50 ` Jason Wang
2022-03-30 6:07 ` Xuan Zhuo
2022-03-30 6:58 ` Jason Wang
2022-03-14 9:34 ` [PATCH v8 12/16] virtio_ring: packed: extract the logic of alloc state and extra Xuan Zhuo
2022-03-14 9:34 ` [PATCH v8 13/16] virtio_ring: packed: extract the logic of attach vring Xuan Zhuo
2022-03-14 9:34 ` [PATCH v8 14/16] virtio_ring: packed: extract the logic of vq init Xuan Zhuo
2022-03-14 9:34 ` [PATCH v8 15/16] virtio_ring: packed: implement virtqueue_resize_packed() Xuan Zhuo
2022-03-14 9:34 ` [PATCH v8 16/16] virtio_ring: introduce virtqueue_resize() Xuan Zhuo
2022-03-22 6:02 ` Jason Wang
2022-03-24 8:34 ` Xuan Zhuo
2022-03-24 10:41 ` Michael S. Tsirkin
2022-03-25 7:37 ` Jason Wang
2022-03-25 10:33 ` Michael S. Tsirkin
2022-03-25 22:31 ` Xuan Zhuo
2022-03-22 6:40 ` [PATCH v8 00/16] virtio pci support VIRTIO_F_RING_RESET (refactor vring) Jason Wang
2022-03-24 8:52 ` Xuan Zhuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220314071819-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=cohuck@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).