Re: [PATCH v2 1/2] dt-bindings: virtio: mmio: add optional wakeup-source property

* Re: [PATCH v2 1/2] dt-bindings: virtio: mmio: add optional wakeup-source property
       [not found] <20220325015945.GA17578@mingxue-gv.qualcomm.com>
@ 2022-03-28 20:42 ` Michael S. Tsirkin
       [not found]   ` <20220329074610.GA20342@mingxue-gv.qualcomm.com>
  0 siblings, 1 reply; 2+ messages in thread
From: Michael S. Tsirkin @ 2022-03-28 20:42 UTC (permalink / raw)
  To: Minghao Xue
  Cc: jean-philippe, devicetree, linux-kernel, virtualization, robh+dt,
	quic_ztu

On Fri, Mar 25, 2022 at 09:59:45AM +0800, Minghao Xue wrote:
> Some systems want to set the interrupt of virtio_mmio device
> as a wakeup source. On such systems, we'll use the existence
> of the "wakeup-source" property as a signal of requirement.
> 
> Signed-off-by: Minghao Xue <quic_mingxue@quicinc.com>

I don't have enough of a clue about dt to review this.
Pls get some acks from people with DT expertise.

> ---
> v1 -> v2: rename property from "virtio,wakeup" to "wakeup-source"
> 
>  Documentation/devicetree/bindings/virtio/mmio.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/virtio/mmio.yaml b/Documentation/devicetree/bindings/virtio/mmio.yaml
> index 4b7a027..160b21b 100644
> --- a/Documentation/devicetree/bindings/virtio/mmio.yaml
> +++ b/Documentation/devicetree/bindings/virtio/mmio.yaml
> @@ -31,6 +31,10 @@ properties:
>      description: Required for devices making accesses thru an IOMMU.
>      maxItems: 1
>  
> +  wakeup-source:
> +    type: boolean
> +    description: Required for setting irq of a virtio_mmio device as wakeup source.
> +
>  required:
>    - compatible
>    - reg
> -- 
> 2.7.4

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

^ permalink raw reply	[flat|nested] 2+ messages in thread