From: Mike Christie <michael.christie@oracle.com>
To: stefanha@redhat.com, jasowang@redhat.com, mst@redhat.com,
sgarzare@redhat.com, virtualization@lists.linux-foundation.org,
arbn@yandex-team.com
Subject: [PATCH V3 7/8] vhost-test: drop flush after vhost_dev_cleanup
Date: Tue, 17 May 2022 13:08:49 -0500 [thread overview]
Message-ID: <20220517180850.198915-8-michael.christie@oracle.com> (raw)
In-Reply-To: <20220517180850.198915-1-michael.christie@oracle.com>
The flush after vhost_dev_cleanup is not needed because:
1. It doesn't do anything. vhost_dev_cleanup will stop the worker thread
so the flush call will just return since the worker has not device.
2. It's not needed. The comment about jobs re-queueing themselves does
not look correct because handle_vq does not requeue work.
Signed-off-by: Mike Christie <michael.christie@oracle.com>
Acked-by: Jason Wang <jasowang@redhat.com>
---
drivers/vhost/test.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/vhost/test.c b/drivers/vhost/test.c
index de39151366c5..6c139f18bc54 100644
--- a/drivers/vhost/test.c
+++ b/drivers/vhost/test.c
@@ -158,9 +158,6 @@ static int vhost_test_release(struct inode *inode, struct file *f)
vhost_test_flush(n);
vhost_dev_stop(&n->dev);
vhost_dev_cleanup(&n->dev);
- /* We do an extra flush before freeing memory,
- * since jobs can re-queue themselves. */
- vhost_test_flush(n);
kfree(n->dev.vqs);
kfree(n);
return 0;
--
2.25.1
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-05-17 18:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 18:08 [PATCH V3 0/8] vhost flush cleanups Mike Christie
2022-05-17 18:08 ` [PATCH V3 1/8] vhost: get rid of vhost_poll_flush() wrapper Mike Christie
2022-05-17 18:08 ` [PATCH V3 2/8] vhost: flush dev once during vhost_dev_stop Mike Christie
2022-05-17 18:08 ` [PATCH V3 3/8] vhost_net: get rid of vhost_net_flush_vq() and extra flush calls Mike Christie
2022-05-17 18:08 ` [PATCH V3 4/8] vhost_test: remove vhost_test_flush_vq() Mike Christie
2022-05-18 7:27 ` Stefano Garzarella
2022-05-17 18:08 ` [PATCH V3 5/8] vhost_vsock: simplify vhost_vsock_flush() Mike Christie
2022-05-17 18:08 ` [PATCH V3 6/8] vhost-scsi: drop flush after vhost_dev_cleanup Mike Christie
2022-05-17 18:08 ` Mike Christie [this message]
2022-05-17 18:08 ` [PATCH V3 8/8] vhost: rename vhost_work_dev_flush Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220517180850.198915-8-michael.christie@oracle.com \
--to=michael.christie@oracle.com \
--cc=arbn@yandex-team.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).