From: Jason Wang <jasowang@redhat.com>
To: mst@redhat.com, jasowang@redhat.com,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Cc: lulu@redhat.com, paulmck@kernel.org, linux-s390@vger.kernel.org,
peterz@infradead.org, maz@kernel.org, cohuck@redhat.com,
Peter Oberparleiter <oberpar@linux.ibm.com>,
pasic@linux.ibm.com, eperezma@redhat.com,
Vineeth Vijayan <vneethv@linux.ibm.com>,
tglx@linutronix.de
Subject: [PATCH V5 1/9] virtio: use virtio_device_ready() in virtio_device_restore()
Date: Wed, 18 May 2022 11:59:43 +0800 [thread overview]
Message-ID: <20220518035951.94220-2-jasowang@redhat.com> (raw)
In-Reply-To: <20220518035951.94220-1-jasowang@redhat.com>
From: Stefano Garzarella <sgarzare@redhat.com>
It will allow us to do extension on virtio_device_ready() without
duplicating code.
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: "Paul E. McKenney" <paulmck@kernel.org>
Cc: Marc Zyngier <maz@kernel.org>
Cc: Halil Pasic <pasic@linux.ibm.com>
Cc: Cornelia Huck <cohuck@redhat.com>
Cc: Vineeth Vijayan <vneethv@linux.ibm.com>
Cc: Peter Oberparleiter <oberpar@linux.ibm.com>
Cc: linux-s390@vger.kernel.org
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
drivers/virtio/virtio.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
index 22f15f444f75..75c8d560bbd3 100644
--- a/drivers/virtio/virtio.c
+++ b/drivers/virtio/virtio.c
@@ -526,8 +526,9 @@ int virtio_device_restore(struct virtio_device *dev)
goto err;
}
- /* Finally, tell the device we're all set */
- virtio_add_status(dev, VIRTIO_CONFIG_S_DRIVER_OK);
+ /* If restore didn't do it, mark device DRIVER_OK ourselves. */
+ if (!(dev->config->get_status(dev) & VIRTIO_CONFIG_S_DRIVER_OK))
+ virtio_device_ready(dev);
virtio_config_enable(dev);
--
2.25.1
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-05-18 4:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 3:59 [PATCH V5 0/9] rework on the IRQ hardening of virtio Jason Wang
2022-05-18 3:59 ` Jason Wang [this message]
2022-05-18 3:59 ` [PATCH V5 2/9] virtio: use virtio_reset_device() when possible Jason Wang
2022-05-19 8:32 ` Stefano Garzarella
2022-05-18 3:59 ` [PATCH V5 3/9] virtio: introduce config op to synchronize vring callbacks Jason Wang
2022-05-19 8:34 ` Stefano Garzarella
2022-05-18 3:59 ` [PATCH V5 4/9] virtio-pci: implement synchronize_cbs() Jason Wang
2022-05-18 3:59 ` [PATCH V5 5/9] virtio-mmio: " Jason Wang
2022-05-18 3:59 ` [PATCH V5 6/9] virtio-ccw: " Jason Wang
2022-05-18 9:32 ` Cornelia Huck
2022-05-19 8:02 ` Jason Wang
2022-05-24 16:29 ` Halil Pasic
2022-05-18 3:59 ` [PATCH V5 7/9] virtio: allow to unbreak virtqueue Jason Wang
2022-05-18 10:03 ` Cornelia Huck
2022-05-19 8:08 ` Jason Wang
2022-05-18 3:59 ` [PATCH V5 8/9] virtio: harden vring IRQ Jason Wang
2022-05-18 3:59 ` [PATCH V5 9/9] virtio: use WARN_ON() to warn illegal status value Jason Wang
2022-05-19 8:34 ` Stefano Garzarella
2022-05-23 8:53 ` [PATCH V5 0/9] rework on the IRQ hardening of virtio Halil Pasic
2022-05-24 16:27 ` Halil Pasic
2022-05-25 2:33 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220518035951.94220-2-jasowang@redhat.com \
--to=jasowang@redhat.com \
--cc=cohuck@redhat.com \
--cc=eperezma@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=maz@kernel.org \
--cc=mst@redhat.com \
--cc=oberpar@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=virtualization@lists.linux-foundation.org \
--cc=vneethv@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).