virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: mst@redhat.com, jasowang@redhat.com,
	virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org
Cc: lulu@redhat.com, paulmck@kernel.org, linux-s390@vger.kernel.org,
	peterz@infradead.org, maz@kernel.org, cohuck@redhat.com,
	Peter Oberparleiter <oberpar@linux.ibm.com>,
	pasic@linux.ibm.com, eperezma@redhat.com,
	Vineeth Vijayan <vneethv@linux.ibm.com>,
	tglx@linutronix.de
Subject: [PATCH V6 2/9] virtio: use virtio_reset_device() when possible
Date: Fri, 27 May 2022 14:01:13 +0800	[thread overview]
Message-ID: <20220527060120.20964-3-jasowang@redhat.com> (raw)
In-Reply-To: <20220527060120.20964-1-jasowang@redhat.com>

This allows us to do common extension without duplicating code.

Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: "Paul E. McKenney" <paulmck@kernel.org>
Cc: Marc Zyngier <maz@kernel.org>
Cc: Halil Pasic <pasic@linux.ibm.com>
Cc: Cornelia Huck <cohuck@redhat.com>
Cc: Vineeth Vijayan <vneethv@linux.ibm.com>
Cc: Peter Oberparleiter <oberpar@linux.ibm.com>
Cc: linux-s390@vger.kernel.org
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
 drivers/virtio/virtio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
index 938e975029d4..aa1eb5132767 100644
--- a/drivers/virtio/virtio.c
+++ b/drivers/virtio/virtio.c
@@ -430,7 +430,7 @@ int register_virtio_device(struct virtio_device *dev)
 
 	/* We always start by resetting the device, in case a previous
 	 * driver messed it up.  This also tests that code path a little. */
-	dev->config->reset(dev);
+	virtio_reset_device(dev);
 
 	/* Acknowledge that we've seen the device. */
 	virtio_add_status(dev, VIRTIO_CONFIG_S_ACKNOWLEDGE);
@@ -496,7 +496,7 @@ int virtio_device_restore(struct virtio_device *dev)
 
 	/* We always start by resetting the device, in case a previous
 	 * driver messed it up. */
-	dev->config->reset(dev);
+	virtio_reset_device(dev);
 
 	/* Acknowledge that we've seen the device. */
 	virtio_add_status(dev, VIRTIO_CONFIG_S_ACKNOWLEDGE);
-- 
2.25.1

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  parent reply	other threads:[~2022-05-27  6:01 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-27  6:01 [PATCH V6 0/9] rework on the IRQ hardening of virtio Jason Wang
2022-05-27  6:01 ` [PATCH V6 1/9] virtio: use virtio_device_ready() in virtio_device_restore() Jason Wang
2022-05-27  7:29   ` Xuan Zhuo
2022-05-27  6:01 ` Jason Wang [this message]
2022-05-27  7:30   ` [PATCH V6 2/9] virtio: use virtio_reset_device() when possible Xuan Zhuo
2022-05-27 10:34   ` Stefano Garzarella
2022-05-27  6:01 ` [PATCH V6 3/9] virtio: introduce config op to synchronize vring callbacks Jason Wang
2022-05-27  7:30   ` Xuan Zhuo
2022-05-27 10:36   ` Stefano Garzarella
2022-05-27  6:01 ` [PATCH V6 4/9] virtio-pci: implement synchronize_cbs() Jason Wang
2022-05-27  7:31   ` Xuan Zhuo
2022-05-27  6:01 ` [PATCH V6 5/9] virtio-mmio: " Jason Wang
2022-05-27  7:32   ` Xuan Zhuo
2022-05-27  6:01 ` [PATCH V6 6/9] virtio-ccw: " Jason Wang
2022-05-30 15:12   ` Cornelia Huck
2022-05-27  6:01 ` [PATCH V6 7/9] virtio: allow to unbreak virtqueue Jason Wang
2022-05-27  7:33   ` Xuan Zhuo
2022-05-30 15:15   ` Cornelia Huck
2022-05-27  6:01 ` [PATCH V6 8/9] virtio: harden vring IRQ Jason Wang
2022-05-27  7:49   ` Xuan Zhuo
2022-05-30 15:18   ` Cornelia Huck
2022-06-11  5:12   ` Michael S. Tsirkin
2022-06-13  5:26     ` Jason Wang
2022-06-13  7:23       ` Michael S. Tsirkin
2022-06-13  8:07         ` Jason Wang
2022-06-13  8:19           ` Michael S. Tsirkin
2022-06-13  8:51             ` Jason Wang
2022-06-13  8:59               ` Michael S. Tsirkin
2022-06-13  9:08                 ` Jason Wang
2022-06-13  9:14                   ` Jason Wang
2022-06-13  9:27                     ` Michael S. Tsirkin
2022-06-14  7:40                       ` Jason Wang
2022-06-14 13:50                         ` Michael S. Tsirkin
2022-06-15  1:32                           ` Jason Wang
2022-06-14 15:49                         ` Michael S. Tsirkin
2022-06-15  1:38                           ` Jason Wang
2022-06-16 17:11                             ` Michael S. Tsirkin
2022-06-17  1:24                               ` Jason Wang
2022-06-17  5:36                                 ` Michael S. Tsirkin
2022-06-17  7:26                                   ` Jason Wang
2022-06-17 14:33                                     ` Peter Zijlstra
     [not found]                         ` <Yqi7UhasBDPKCpuV@e120937-lin>
2022-06-15  1:41                           ` Jason Wang
     [not found]                             ` <YqojyHuocSoZ0v/Y@e120937-lin>
2022-06-17  3:14                               ` Jason Wang
2022-06-13  9:26                   ` Michael S. Tsirkin
2022-06-14  7:19                     ` Jason Wang
     [not found]   ` <df5a9628-3a00-d18c-9cac-ae6460695cb3@hisilicon.com>
2022-07-05 12:56     ` Jason Wang
2022-05-27  6:01 ` [PATCH V6 9/9] virtio: use WARN_ON() to warning illegal status value Jason Wang
2022-05-27  7:49   ` Xuan Zhuo
2022-05-27 10:35   ` Stefano Garzarella
2022-05-27 10:50   ` Michael S. Tsirkin
2022-05-30  3:48     ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220527060120.20964-3-jasowang@redhat.com \
    --to=jasowang@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=eperezma@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=lulu@redhat.com \
    --cc=maz@kernel.org \
    --cc=mst@redhat.com \
    --cc=oberpar@linux.ibm.com \
    --cc=pasic@linux.ibm.com \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=vneethv@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).