* Re: [PATCH 4/4] virtio-blk: remove deprecated ida_simple_XXX() [not found] <fa54e172-ef9d-fba5-ad37-72a6698c7cb8@wanadoo.fr> @ 2022-05-27 10:19 ` Michael S. Tsirkin 0 siblings, 0 replies; 2+ messages in thread From: Michael S. Tsirkin @ 2022-05-27 10:19 UTC (permalink / raw) To: Christophe JAILLET Cc: keliu, linux-kernel@vger.kernel.org, virtualization, linux-block, stefanha, pbonzini On Fri, May 27, 2022 at 10:04:46AM +0200, Christophe JAILLET wrote: > (Resend, my email client sent it as HTML. So sorry for the duplicate) > > > Hi, > > > diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c > > index 74c3a48cd1e5..e05748337dd1 100644 > > --- a/drivers/block/virtio_blk.c > > +++ b/drivers/block/virtio_blk.c > > @@ -720,8 +720,8 @@ static int virtblk_probe(struct virtio_device *vdev) > > return -EINVAL; > > } > > > >- err = ida_simple_get(&vd_index_ida, 0, minor_to_index(1 << MINORBITS), > >- GFP_KERNEL); > >+ err = ida_alloc_max(&vd_index_ida, minor_to_index(1 << MINORBITS), > >+ GFP_KERNEL); > > if (err < 0) > > goto out; > > index = err; > > > this patch, already applied to -next, is wrong. > > > The upper bound of ida_simple_get() is exlcusive, while the one of > ida_alloc_max() is inclusive. > > So, 'minor_to_index(1 << MINORBITS)' should be 'minor_to_index(1 << > MINORBITS) - 1' here. > > > (adding keliu in cc: because he is proposing the same kind of patches, so he > will see how to to these changes that are slighly tricky) > > > CJ I will drop this for now, please resend with either a corrected version or a comment explaining why it's correct. Thanks! -- MST _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization ^ permalink raw reply [flat|nested] 2+ messages in thread
[parent not found: <20220420041053.7927-1-kch@nvidia.com>]
[parent not found: <20220420041053.7927-5-kch@nvidia.com>]
* Re: [PATCH 4/4] virtio-blk: remove deprecated ida_simple_XXX() [not found] ` <20220420041053.7927-5-kch@nvidia.com> @ 2022-04-20 15:19 ` Stefan Hajnoczi 0 siblings, 0 replies; 2+ messages in thread From: Stefan Hajnoczi @ 2022-04-20 15:19 UTC (permalink / raw) To: Chaitanya Kulkarni; +Cc: linux-block, pbonzini, virtualization, mst [-- Attachment #1.1: Type: text/plain, Size: 387 bytes --] On Tue, Apr 19, 2022 at 09:10:53PM -0700, Chaitanya Kulkarni wrote: > Replace deprecated ida_simple_get() and ida_simple_remove() with > ida_alloc_max() and ida_free(). > > Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com> > --- > drivers/block/virtio_blk.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 183 bytes --] _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-27 10:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <fa54e172-ef9d-fba5-ad37-72a6698c7cb8@wanadoo.fr>
2022-05-27 10:19 ` [PATCH 4/4] virtio-blk: remove deprecated ida_simple_XXX() Michael S. Tsirkin
[not found] <20220420041053.7927-1-kch@nvidia.com>
[not found] ` <20220420041053.7927-5-kch@nvidia.com>
2022-04-20 15:19 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).