Re: [PATCH v4 0/4] Implement vdpasim stop operation

From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Eugenio Pérez" <eperezma@redhat.com>
Cc: tanuj.kamde@amd.com, kvm@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	Wu Zongyong <wuzongyong@linux.alibaba.com>,
	Si-Wei Liu <si-wei.liu@oracle.com>,
	pabloc@xilinx.com, Eli Cohen <elic@nvidia.com>,
	Zhang Min <zhang.min9@zte.com.cn>,
	lulu@redhat.com, Piotr.Uminski@intel.com, martinh@xilinx.com,
	Xie Yongji <xieyongji@bytedance.com>,
	dinang@xilinx.com, habetsm.xilinx@gmail.com,
	Longpeng <longpeng2@huawei.com>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	lvivier@redhat.com,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	ecree.xilinx@gmail.com, hanand@xilinx.com, martinpo@xilinx.com,
	gautam.dawar@amd.com, Zhu Lingshan <lingshan.zhu@intel.com>
Subject: Re: [PATCH v4 0/4] Implement vdpasim stop operation
Date: Tue, 31 May 2022 01:42:06 -0400	[thread overview]
Message-ID: <20220531014108-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20220526124338.36247-1-eperezma@redhat.com>

On Thu, May 26, 2022 at 02:43:34PM +0200, Eugenio Pérez wrote:
> Implement stop operation for vdpa_sim devices, so vhost-vdpa will offer
> that backend feature and userspace can effectively stop the device.
> 
> This is a must before get virtqueue indexes (base) for live migration,
> since the device could modify them after userland gets them. There are
> individual ways to perform that action for some devices
> (VHOST_NET_SET_BACKEND, VHOST_VSOCK_SET_RUNNING, ...) but there was no
> way to perform it for any vhost device (and, in particular, vhost-vdpa).
> 
> After the return of ioctl with stop != 0, the device MUST finish any
> pending operations like in flight requests. It must also preserve all
> the necessary state (the virtqueue vring base plus the possible device
> specific states) that is required for restoring in the future. The
> device must not change its configuration after that point.
> 
> After the return of ioctl with stop == 0, the device can continue
> processing buffers as long as typical conditions are met (vq is enabled,
> DRIVER_OK status bit is enabled, etc).
> 
> In the future, we will provide features similar to VHOST_USER_GET_INFLIGHT_FD
> so the device can save pending operations.
> 
> Comments are welcome.

So given this is just for simulator and affects UAPI I think it's fine
to make it wait for the next merge window, until there's a consensus.
Right?

> v4:
> * Replace VHOST_STOP to VHOST_VDPA_STOP in vhost ioctl switch case too.
> 
> v3:
> * s/VHOST_STOP/VHOST_VDPA_STOP/
> * Add documentation and requirements of the ioctl above its definition.
> 
> v2:
> * Replace raw _F_STOP with BIT_ULL(_F_STOP).
> * Fix obtaining of stop ioctl arg (it was not obtained but written).
> * Add stop to vdpa_sim_blk.
> 
> Eugenio Pérez (4):
>   vdpa: Add stop operation
>   vhost-vdpa: introduce STOP backend feature bit
>   vhost-vdpa: uAPI to stop the device
>   vdpa_sim: Implement stop vdpa op
> 
>  drivers/vdpa/vdpa_sim/vdpa_sim.c     | 21 +++++++++++++++++
>  drivers/vdpa/vdpa_sim/vdpa_sim.h     |  1 +
>  drivers/vdpa/vdpa_sim/vdpa_sim_blk.c |  3 +++
>  drivers/vdpa/vdpa_sim/vdpa_sim_net.c |  3 +++
>  drivers/vhost/vdpa.c                 | 34 +++++++++++++++++++++++++++-
>  include/linux/vdpa.h                 |  6 +++++
>  include/uapi/linux/vhost.h           | 14 ++++++++++++
>  include/uapi/linux/vhost_types.h     |  2 ++
>  8 files changed, 83 insertions(+), 1 deletion(-)
> 
> -- 
> 2.31.1
> 

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization