From: "Michael S. Tsirkin" <mst@redhat.com>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: debian-kernel@lists.debian.org,
virtualization <virtualization@lists.linux-foundation.org>,
"regressions@lists.linux.dev" <regressions@lists.linux.dev>
Subject: Re: virtio_balloon regression in 5.19-rc3
Date: Fri, 24 Jun 2022 05:14:00 -0400 [thread overview]
Message-ID: <20220624051309-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <a1a127d144d65937c5543c142e69213c9b8d2d40.camel@decadent.org.uk>
On Tue, Jun 21, 2022 at 06:10:00PM +0200, Ben Hutchings wrote:
> On Tue, 2022-06-21 at 17:34 +0800, Jason Wang wrote:
> > On Tue, Jun 21, 2022 at 5:24 PM David Hildenbrand <david@redhat.com> wrote:
> > >
> > > On 20.06.22 20:49, Ben Hutchings wrote:
> > > > I've tested a 5.19-rc3 kernel on top of QEMU/KVM with machine type
> > > > pc-q35-5.2. It has a virtio balloon device defined in libvirt as:
> > > >
> > > > <memballoon model="virtio">
> > > > <address type="pci" domain="0x0000" bus="0x05" slot="0x00" function="0x0"/>
> > > > </memballoon>
> > > >
> > > > but the virtio_balloon driver fails to bind to it:
> > > >
> > > > virtio_balloon virtio4: init_vqs: add stat_vq failed
> > > > virtio_balloon: probe of virtio4 failed with error -5
> > > >
> > >
> > > Hmm, I don't see any recent changes to drivers/virtio/virtio_balloon.c
> > >
> > > virtqueue_add_outbuf() fails with -EIO if I'm not wrong. That's the
> > > first call of virtqueue_add_outbuf() when virtio_balloon initializes.
> > >
> > >
> > > Maybe something in generic virtio code changed?
> >
> > Yes, we introduced the IRQ hardening. That could be the root cause and
> > we've received lots of reports so we decide to disable it by default.
> >
> > Ben, could you please try this patch: (and make sure
> > CONFIG_VIRTIO_HARDEN_NOTIFICATION is not set)
> >
> > https://lore.kernel.org/lkml/20220620024158.2505-1-jasowang@redhat.com/T/
>
> Yes, that patch fixes the regression for me.
>
> Ben.
Jason are you going to fix balloon to call device_ready before
registering device with linux?
> --
> Ben Hutchings
> Any smoothly functioning technology is indistinguishable
> from a rigged demo.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-06-24 9:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 18:49 virtio_balloon regression in 5.19-rc3 Ben Hutchings
2022-06-21 9:24 ` David Hildenbrand
2022-06-21 9:34 ` Jason Wang
2022-06-21 16:10 ` Ben Hutchings
2022-06-24 9:14 ` Michael S. Tsirkin [this message]
2022-06-27 2:30 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220624051309-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=ben@decadent.org.uk \
--cc=debian-kernel@lists.debian.org \
--cc=regressions@lists.linux.dev \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).