public inbox for virtualization@lists.linux-foundation.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Martin Habets <habetsm.xilinx@gmail.com>
Cc: netdev@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	ecree.xilinx@gmail.com, edumazet@google.com,
	linux-pci@vger.kernel.org, kuba@kernel.org, pabeni@redhat.com,
	davem@davemloft.net
Subject: Re: [PATCH net-next v2 0/2] sfc: Add EF100 BAR config support
Date: Thu, 7 Jul 2022 10:55:00 -0500	[thread overview]
Message-ID: <20220707155500.GA305857@bhelgaas> (raw)
In-Reply-To: <165719918216.28149.7678451615870416505.stgit@palantir17.mph.net>

On Thu, Jul 07, 2022 at 02:07:07PM +0100, Martin Habets wrote:
> The EF100 NICs allow for different register layouts of a PCI memory BAR.
> This series provides the framework to switch this layout at runtime.
> 
> Subsequent patch series will use this to add support for vDPA.

Normally drivers rely on the PCI Vendor and Device ID to learn the
number of BARs and their layouts.  I guess this series implies that
doesn't work on this device?  And the user needs to manually specify
what kind of device this is?

I'm confused about how this is supposed to work.  What if the driver
is built-in and claims a device before the user can specify the
register layout?  What if the user specifies the wrong layout and the
driver writes to the wrong registers?

> ---
> 
> Martin Habets (2):
>       sfc: Add EF100 BAR config support
>       sfc: Implement change of BAR configuration
> 
> 
>  drivers/net/ethernet/sfc/ef100_nic.c |   80 ++++++++++++++++++++++++++++++++++
>  drivers/net/ethernet/sfc/ef100_nic.h |    6 +++
>  2 files changed, 86 insertions(+)
> 
> --
> Martin Habets <habetsm.xilinx@gmail.com>
> 
> 
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

       reply	other threads:[~2022-07-07 15:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <165719918216.28149.7678451615870416505.stgit@palantir17.mph.net>
2022-07-07 15:55 ` Bjorn Helgaas [this message]
     [not found]   ` <Yswn7p+OWODbT7AR@gmail.com>
2022-07-11 22:00     ` [PATCH net-next v2 0/2] sfc: Add EF100 BAR config support Bjorn Helgaas
     [not found]     ` <20220711114806.2724b349@kernel.org>
     [not found]       ` <Ys6E4fvoufokIFqk@gmail.com>
     [not found]         ` <20220713114804.11c7517e@kernel.org>
     [not found]           ` <Ys/+vCNAfh/AKuJv@gmail.com>
     [not found]             ` <20220714090500.356846ea@kernel.org>
2022-08-03  7:57               ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220707155500.GA305857@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=davem@davemloft.net \
    --cc=ecree.xilinx@gmail.com \
    --cc=edumazet@google.com \
    --cc=habetsm.xilinx@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox