From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D0DBC43334 for ; Fri, 8 Jul 2022 01:14:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id A2FA0840F9; Fri, 8 Jul 2022 01:14:24 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org A2FA0840F9 Authentication-Results: smtp1.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=dor+TBRo X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JmK8Os6TLfqV; Fri, 8 Jul 2022 01:14:23 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTPS id E929E84615; Fri, 8 Jul 2022 01:14:22 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org E929E84615 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id BC921C0033; Fri, 8 Jul 2022 01:14:22 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 74544C002D for ; Fri, 8 Jul 2022 01:14:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 568B284615 for ; Fri, 8 Jul 2022 01:14:21 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 568B284615 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mns5oCueyrdf for ; Fri, 8 Jul 2022 01:14:20 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 1F02D840F9 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by smtp1.osuosl.org (Postfix) with ESMTPS id 1F02D840F9 for ; Fri, 8 Jul 2022 01:14:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657242860; x=1688778860; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=wxI3VmblkWkttFlRKDyLAHaqzg9O9oOsJXYXSJn1xFc=; b=dor+TBRoxuxwpaCUO+jiPwLHBpKJOjdH+5w/N/9iFrN9/yKfrpjTvlDh DwcpiW/nB3vaGrZPzKqsECUz7BW71e6TdhSBeBwS5e2A9316EcluSwH4X kcJyjqdwLGo+yGEVSXMyjZSW57sDBFBA6oaBYKodpWS5pKtjQVUBWRb4Z Y6ayu5+6QpUSaM/rRT600rAl/14KBk2Ih1a7J4HVfjAahjPdOqQdU4L7B R6f378uPyUVBiB4cSZ71d/NadcWBhh6clqXRn6uZcEyBdQEoZ9XohoYyZ JprTR/gw+L8ZkJWTBx3oG5kqj6qZOBMSQeruQw4vNkfP/A6g3APtE9bEQ A==; X-IronPort-AV: E=McAfee;i="6400,9594,10401"; a="263940564" X-IronPort-AV: E=Sophos;i="5.92,254,1650956400"; d="scan'208";a="263940564" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2022 18:14:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,253,1650956400"; d="scan'208";a="626529390" Received: from lkp-server01.sh.intel.com (HELO 68b931ab7ac1) ([10.239.97.150]) by orsmga001.jf.intel.com with ESMTP; 07 Jul 2022 18:14:16 -0700 Received: from kbuild by 68b931ab7ac1 with local (Exim 4.95) (envelope-from ) id 1o9cZT-000Mi1-CM; Fri, 08 Jul 2022 01:14:15 +0000 Date: Fri, 8 Jul 2022 09:14:08 +0800 From: kernel test robot To: Xie Yongji , mst@redhat.com, jasowang@redhat.com, xiaodong.liu@intel.com, maxime.coquelin@redhat.com, stefanha@redhat.com Subject: Re: [PATCH v2 5/5] vduse: Support registering userspace memory for IOTLB Message-ID: <202207080910.VfMFrTtN-lkp@intel.com> References: <20220706050503.171-6-xieyongji@bytedance.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220706050503.171-6-xieyongji@bytedance.com> Cc: virtualization@lists.linux-foundation.org, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, songmuchun@bytedance.com X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" Hi Xie, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.19-rc5 next-20220707] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Xie-Yongji/VDUSE-Support-registering-userspace-memory-as-bounce-buffer/20220706-130802 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git e35e5b6f695d241ffb1d223207da58a1fbcdff4b config: parisc-randconfig-r003-20220707 (https://download.01.org/0day-ci/archive/20220708/202207080910.VfMFrTtN-lkp@intel.com/config) compiler: hppa-linux-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/9be699264e4fede9c3be913b2d1003c260d9fa05 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Xie-Yongji/VDUSE-Support-registering-userspace-memory-as-bounce-buffer/20220706-130802 git checkout 9be699264e4fede9c3be913b2d1003c260d9fa05 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=parisc SHELL=/bin/bash drivers/vdpa/vdpa_user/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All error/warnings (new ones prefixed by >>): drivers/vdpa/vdpa_user/vduse_dev.c: In function 'vduse_dev_dereg_iotlb_mem': >> drivers/vdpa/vdpa_user/vduse_dev.c:949:9: error: implicit declaration of function 'vfree'; did you mean 'kvfree'? [-Werror=implicit-function-declaration] 949 | vfree(dev->iotlb_mem->pages); | ^~~~~ | kvfree drivers/vdpa/vdpa_user/vduse_dev.c: In function 'vduse_dev_reg_iotlb_mem': >> drivers/vdpa/vdpa_user/vduse_dev.c:978:21: error: implicit declaration of function '__vmalloc'; did you mean '__kmalloc'? [-Werror=implicit-function-declaration] 978 | page_list = __vmalloc(array_size(npages, sizeof(struct page *)), | ^~~~~~~~~ | __kmalloc >> drivers/vdpa/vdpa_user/vduse_dev.c:978:19: warning: assignment to 'struct page **' from 'int' makes pointer from integer without a cast [-Wint-conversion] 978 | page_list = __vmalloc(array_size(npages, sizeof(struct page *)), | ^ cc1: some warnings being treated as errors Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for DRM_DP_AUX_BUS Depends on HAS_IOMEM && DRM && OF Selected by - DRM_MSM && HAS_IOMEM && DRM && (ARCH_QCOM || SOC_IMX5 || COMPILE_TEST && COMMON_CLK && IOMMU_SUPPORT && (QCOM_OCMEM || QCOM_OCMEM && (QCOM_LLCC || QCOM_LLCC && (QCOM_COMMAND_DB || QCOM_COMMAND_DB vim +949 drivers/vdpa/vdpa_user/vduse_dev.c 929 930 static int vduse_dev_dereg_iotlb_mem(struct vduse_dev *dev, 931 u64 iova, u64 size) 932 { 933 int ret; 934 935 mutex_lock(&dev->mem_lock); 936 ret = -ENOENT; 937 if (!dev->iotlb_mem) 938 goto unlock; 939 940 ret = -EINVAL; 941 if (dev->iotlb_mem->iova != iova || size != dev->domain->bounce_size) 942 goto unlock; 943 944 vduse_domain_remove_user_bounce_pages(dev->domain); 945 unpin_user_pages_dirty_lock(dev->iotlb_mem->pages, 946 dev->iotlb_mem->npages, true); 947 atomic64_sub(dev->iotlb_mem->npages, &dev->iotlb_mem->mm->pinned_vm); 948 mmdrop(dev->iotlb_mem->mm); > 949 vfree(dev->iotlb_mem->pages); 950 kfree(dev->iotlb_mem); 951 dev->iotlb_mem = NULL; 952 ret = 0; 953 unlock: 954 mutex_unlock(&dev->mem_lock); 955 return ret; 956 } 957 958 static int vduse_dev_reg_iotlb_mem(struct vduse_dev *dev, 959 u64 iova, u64 uaddr, u64 size) 960 { 961 struct page **page_list = NULL; 962 struct vduse_iotlb_mem *mem = NULL; 963 long pinned = 0; 964 unsigned long npages, lock_limit; 965 int ret; 966 967 if (size != dev->domain->bounce_size || 968 iova != 0 || uaddr & ~PAGE_MASK) 969 return -EINVAL; 970 971 mutex_lock(&dev->mem_lock); 972 ret = -EEXIST; 973 if (dev->iotlb_mem) 974 goto unlock; 975 976 ret = -ENOMEM; 977 npages = size >> PAGE_SHIFT; > 978 page_list = __vmalloc(array_size(npages, sizeof(struct page *)), 979 GFP_KERNEL_ACCOUNT); 980 mem = kzalloc(sizeof(*mem), GFP_KERNEL); 981 if (!page_list || !mem) 982 goto unlock; 983 984 mmap_read_lock(current->mm); 985 986 lock_limit = PFN_DOWN(rlimit(RLIMIT_MEMLOCK)); 987 if (npages + atomic64_read(¤t->mm->pinned_vm) > lock_limit) 988 goto out; 989 990 pinned = pin_user_pages(uaddr, npages, FOLL_LONGTERM | FOLL_WRITE, 991 page_list, NULL); 992 if (pinned != npages) { 993 ret = pinned < 0 ? pinned : -ENOMEM; 994 goto out; 995 } 996 997 ret = vduse_domain_add_user_bounce_pages(dev->domain, 998 page_list, pinned); 999 if (ret) 1000 goto out; 1001 1002 atomic64_add(npages, ¤t->mm->pinned_vm); 1003 1004 mem->pages = page_list; 1005 mem->npages = pinned; 1006 mem->iova = iova; 1007 mem->mm = current->mm; 1008 mmgrab(current->mm); 1009 1010 dev->iotlb_mem = mem; 1011 out: 1012 if (ret && pinned > 0) 1013 unpin_user_pages(page_list, pinned); 1014 1015 mmap_read_unlock(current->mm); 1016 unlock: 1017 if (ret) { 1018 vfree(page_list); 1019 kfree(mem); 1020 } 1021 mutex_unlock(&dev->mem_lock); 1022 return ret; 1023 } 1024 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization