* Re: [PATCH v2 1/4] Make place for common balloon code [not found] ` <20220816094117.3144881-2-alexander.atanasov@virtuozzo.com> @ 2022-08-16 9:49 ` Greg Kroah-Hartman [not found] ` <f88fe469-d4a4-3240-b325-a745255bf01c@virtuozzo.com> 0 siblings, 1 reply; 3+ messages in thread From: Greg Kroah-Hartman @ 2022-08-16 9:49 UTC (permalink / raw) To: Alexander Atanasov Cc: Arnd Bergmann, Michael S. Tsirkin, VMware PV-Drivers Reviewers, Michael Ellerman, linux-kernel, Christophe Leroy, virtualization, linux-mm, Nadav Amit, Nicholas Piggin, kernel, Andrew Morton, linuxppc-dev On Tue, Aug 16, 2022 at 12:41:14PM +0300, Alexander Atanasov wrote: > File already contains code that is common along balloon > drivers so rename it to reflect its contents. > mm/balloon_compaction.c -> mm/balloon_common.c > > Signed-off-by: Alexander Atanasov <alexander.atanasov@virtuozzo.com> > --- > MAINTAINERS | 4 ++-- > arch/powerpc/platforms/pseries/cmm.c | 2 +- > drivers/misc/vmw_balloon.c | 2 +- > drivers/virtio/virtio_balloon.c | 2 +- > include/linux/{balloon_compaction.h => balloon_common.h} | 2 +- > mm/Makefile | 2 +- > mm/{balloon_compaction.c => balloon_common.c} | 4 ++-- > mm/migrate.c | 2 +- > mm/vmscan.c | 2 +- > 9 files changed, 11 insertions(+), 11 deletions(-) > rename include/linux/{balloon_compaction.h => balloon_common.h} (99%) Why rename the .h file? It still handles the "balloon compaction" logic. thanks, greg k-h _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <f88fe469-d4a4-3240-b325-a745255bf01c@virtuozzo.com>]
* Re: [PATCH v2 1/4] Make place for common balloon code [not found] ` <f88fe469-d4a4-3240-b325-a745255bf01c@virtuozzo.com> @ 2022-08-16 11:56 ` Greg Kroah-Hartman 2022-08-16 12:00 ` Michael S. Tsirkin 0 siblings, 1 reply; 3+ messages in thread From: Greg Kroah-Hartman @ 2022-08-16 11:56 UTC (permalink / raw) To: Alexander Atanasov Cc: Arnd Bergmann, Michael S. Tsirkin, VMware PV-Drivers Reviewers, Michael Ellerman, linux-kernel, Christophe Leroy, virtualization, linux-mm, Nadav Amit, Nicholas Piggin, kernel, Andrew Morton, linuxppc-dev On Tue, Aug 16, 2022 at 02:47:22PM +0300, Alexander Atanasov wrote: > Hello, > > On 16.08.22 12:49, Greg Kroah-Hartman wrote: > > On Tue, Aug 16, 2022 at 12:41:14PM +0300, Alexander Atanasov wrote: > > > > rename include/linux/{balloon_compaction.h => balloon_common.h} (99%) > > > > Why rename the .h file? It still handles the "balloon compaction" > > logic. > > File contains code that is common to balloon drivers, > compaction is only part of it. Series add more code to it. > Since it was suggested to use it for such common code. > I find that common becomes a better name for it so the rename. > I can drop the rename easy on next iteration if you suggest to. "balloon_common.h" is very vague, you should only need one balloon.h file in the include/linux/ directory, right, so of course it is "common" :) thanks, greg "naming is hard" k-h _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/4] Make place for common balloon code 2022-08-16 11:56 ` Greg Kroah-Hartman @ 2022-08-16 12:00 ` Michael S. Tsirkin 0 siblings, 0 replies; 3+ messages in thread From: Michael S. Tsirkin @ 2022-08-16 12:00 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Arnd Bergmann, VMware PV-Drivers Reviewers, Michael Ellerman, Alexander Atanasov, linux-kernel, Christophe Leroy, virtualization, linux-mm, Nadav Amit, Nicholas Piggin, kernel, Andrew Morton, linuxppc-dev On Tue, Aug 16, 2022 at 01:56:32PM +0200, Greg Kroah-Hartman wrote: > On Tue, Aug 16, 2022 at 02:47:22PM +0300, Alexander Atanasov wrote: > > Hello, > > > > On 16.08.22 12:49, Greg Kroah-Hartman wrote: > > > On Tue, Aug 16, 2022 at 12:41:14PM +0300, Alexander Atanasov wrote: > > > > > > rename include/linux/{balloon_compaction.h => balloon_common.h} (99%) > > > > > > Why rename the .h file? It still handles the "balloon compaction" > > > logic. > > > > File contains code that is common to balloon drivers, > > compaction is only part of it. Series add more code to it. > > Since it was suggested to use it for such common code. > > I find that common becomes a better name for it so the rename. > > I can drop the rename easy on next iteration if you suggest to. > > "balloon_common.h" is very vague, you should only need one balloon.h > file in the include/linux/ directory, right, so of course it is "common" > :) > > thanks, > > greg "naming is hard" k-h Yea, just call it balloon.h and balloon.c then. -- MST _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-16 12:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20220816094117.3144881-1-alexander.atanasov@virtuozzo.com>
[not found] ` <20220816094117.3144881-2-alexander.atanasov@virtuozzo.com>
2022-08-16 9:49 ` [PATCH v2 1/4] Make place for common balloon code Greg Kroah-Hartman
[not found] ` <f88fe469-d4a4-3240-b325-a745255bf01c@virtuozzo.com>
2022-08-16 11:56 ` Greg Kroah-Hartman
2022-08-16 12:00 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).