virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Eli Cohen <elic@nvidia.com>
Cc: "eperezma@redhat.com" <eperezma@redhat.com>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>
Subject: Re: RFC: control virtqueue size by the vdpa tool
Date: Tue, 30 Aug 2022 15:58:28 -0400	[thread overview]
Message-ID: <20220830154938-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <DM8PR12MB5400FEB0322A9FD6B3271D45AB799@DM8PR12MB5400.namprd12.prod.outlook.com>

On Tue, Aug 30, 2022 at 06:22:31AM +0000, Eli Cohen wrote:
>  
> 
> Hi,
> 
>  
> 
> I have been experimenting with different queue sizes with mlx5_vdpa and noticed
> that queue size can affect performance.
> 
> I would like to propose an extension to vdpa tool to allow to specify the queue
> size. Valid values will conform to the max of 32768 specified by the spec.
> 
>  
> 
> “vdpa mgmtdev show” will have another line specifying the valid range for a
> management device which could be narrower than the spec allows. This range will
> be valid for data queues only (not for control VQ).
> 
> Another line will display the default queue size
> 
>  
> 
> Example:
> 
> $ vdpa mgmtdev show
> 
> auxiliary/mlx5_core.sf.6:
> 
>   supported_classes net
> 
>   max_supported_vqs 65
> 
>   dev_features CSUM GUEST_CSUM MTU HOST_TSO4 HOST_TSO6 STATUS CTRL_VQ CTRL_VLAN
> MQ CTRL_MAC_ADDR VERSION_1 ACCESS_PLATFORM
> 
>   data queue range 256-4096
> 
>   default queue size 256
> 
>  
> 
> When you create the vdpa device you can specify the requested value:
> 
> $ vdpa dev add name vdpa-a mgmtdev auxiliary/mlx5_core.sf.6 max_vqp 1 mtu 9000
> queue_size 1024
> 
>  


A follow up question: isn't it enough to control the size
from qemu? do we need ability to control it at the kernel level?

-- 
MST

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  parent reply	other threads:[~2022-08-30 19:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <DM8PR12MB5400FEB0322A9FD6B3271D45AB799@DM8PR12MB5400.namprd12.prod.outlook.com>
2022-08-30  8:21 ` RFC: control virtqueue size by the vdpa tool Michael S. Tsirkin
2022-08-30 19:58 ` Michael S. Tsirkin [this message]
2022-08-30 21:04   ` Si-Wei Liu
2022-08-30 22:01     ` Michael S. Tsirkin
2022-08-30 23:22       ` Si-Wei Liu
     [not found]         ` <DM8PR12MB54006D58A2ACA88CC786B9A8AB789@DM8PR12MB5400.namprd12.prod.outlook.com>
2022-08-31 22:22           ` Si-Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220830154938-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=elic@nvidia.com \
    --cc=eperezma@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).