Re: 答复: [PATCH] vDPA/ifcvf: fix the Calculation of queuepair

["Michael S. Tsirkin" <mst@redhat.com>]

On Thu, Sep 22, 2022 at 10:52:05AM +0000, Angus Chen wrote:
> 
> 
> 
> On 9/22/2022 6:17 PM, Michael S. Tsirkin wrote:
> > On Thu, Sep 22, 2022 at 06:07:58PM +0800, Zhu, Lingshan wrote:
> >>
> >> On 9/22/2022 5:06 PM, Michael S. Tsirkin wrote:
> >>> On Thu, Sep 22, 2022 at 08:55:26AM +0000, Angus Chen wrote:
> >>>> >From 4f65eae86ab15d7abb8bd30401187cb195dfd27b Mon Sep 17 00:00:00 
> >>>> >2001
> >>>> From: "angus.chen" <angus.chen@jaguarmicro.com>
> >>>> Date: Thu, 22 Sep 2022 14:47:28 +0800
> >>>> Subject: [PATCH]     vDPA/ifcvf: fix the Calculation of queuepair
> >>>>
> >>>>           The queuepair should be divided by 2
> >>> this is just repeating what the patch does.
> >>> can you include more info pls?
> >>>
> >>> Documentation/process/5.Posting.rst says among other things:
> >>>
> >>> To that end, the summary line should describe the effects of and 
> >>> motivation for the change as well as possible given the one-line 
> >>> constraint.  The detailed description can then amplify on those 
> >>> topics and provide any needed additional information.  If the patch 
> >>> fixes a bug, cite the commit which introduced the bug if possible 
> >>> (and please provide both the commit ID and the title when citing 
> >>> commits).  If a problem is associated with specific log or compiler 
> >>> output, include that output to help others searching for a solution 
> >>> to the same problem.  If the change is meant to support other 
> >>> changes coming in later patch, say so.  If internal APIs are 
> >>> changed, detail those changes and how other developers should 
> >>> respond.  In general, the more you can put yourself into the shoes 
> >>> of everybody who will be reading your changelog, the better that 
> >>> changelog (and the kernel as a
> >>> whole) will be.
> >>>
> >>>
> >>>> Signed-off-by: angus.chen <angus.chen@jaguarmicro.com>
> >>> Format should be
> >>>
> >>> Angus Chen <angus.chen@jaguarmicro.com>
> >>>
> >>> Also pls drop leading space.
> >>>
> >>>
> >>>> ---
> >>>> drivers/vdpa/ifcvf/ifcvf_base.c | 4 ++--
> >>>> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>>>
> >>>> diff --git a/drivers/vdpa/ifcvf/ifcvf_base.c 
> >>>> b/drivers/vdpa/ifcvf/ifcvf_base.c index 75a703b803a2..3e4486bfa0b7 
> >>>> 100644
> >>>> --- a/drivers/vdpa/ifcvf/ifcvf_base.c
> >>>> +++ b/drivers/vdpa/ifcvf/ifcvf_base.c
> >>>> @@ -323,7 +323,7 @@ u16 ifcvf_get_vq_state(struct ifcvf_hw *hw, u16 qid)
> >>>>           u32 q_pair_id;
> >>>>
> >>>>           ifcvf_lm = (struct ifcvf_lm_cfg __iomem *)hw->lm_cfg;
> >>>> -       q_pair_id = qid / hw->nr_vring;
> >>>> +       q_pair_id = qid / 2;
> >> Yes, this should be 2 and actually this cap never work as expected, 
> >> we are re-designing this.
> > Do you ack this patch then?
> Yes,
> 
> Thank you ,should I resend a patch again without style problem?

If you have the time - it's easier for me if you do, yes.

-- 
MST

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization