From: "Michael S. Tsirkin" <mst@redhat.com>
To: Alvaro Karsz <alvaro.karsz@solid-run.com>
Cc: Jens Axboe <axboe@kernel.dk>, Paolo Bonzini <pbonzini@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v3] virtio_blk: add SECURE ERASE command support
Date: Wed, 28 Sep 2022 09:15:33 -0400 [thread overview]
Message-ID: <20220928091512-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAJs=3_BXGpu-kDq1_bJSanh-iY63uwpc2tZtH6jOYcqBUptsNA@mail.gmail.com>
On Wed, Sep 28, 2022 at 01:48:43PM +0300, Alvaro Karsz wrote:
> > What I worry about is that down the road we might want to add
> > special meaning to currently unused values.
> > If doing that just clears VIRTIO_BLK_F_SECURE_ERASE then
> > we have forward compatibility. If it fails probe then we
> > won't be able to do use these values.
>
>
> They are not exactly unused, we are using them to calculate the
> "discard sector alignment" and the "max discard sectors" values.
> The values are even used directly if VIRTIO_BLK_F_DISCARD is not negotiated.
Could you explain this last part? Why are they used without
VIRTIO_BLK_F_DISCARD?
--
MST
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-09-28 13:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 8:27 [PATCH v3] virtio_blk: add SECURE ERASE command support Alvaro Karsz
2022-09-22 17:45 ` Stefan Hajnoczi
2022-09-28 10:48 ` Alvaro Karsz
2022-09-28 13:15 ` Michael S. Tsirkin [this message]
2022-09-29 7:13 ` Alvaro Karsz
2022-09-29 7:20 ` Michael S. Tsirkin
2022-09-29 7:29 ` Alvaro Karsz
2022-09-29 7:45 ` Michael S. Tsirkin
2022-09-29 8:51 ` Alvaro Karsz
2022-10-07 13:12 ` Michael S. Tsirkin
2022-10-08 4:48 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220928091512-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alvaro.karsz@solid-run.com \
--cc=axboe@kernel.dk \
--cc=pbonzini@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).