From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB2D8C6FA82 for ; Wed, 28 Sep 2022 20:02:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 64F4740C1C; Wed, 28 Sep 2022 20:02:30 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 64F4740C1C Authentication-Results: smtp2.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=H7US+pfw X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9-gUHqgox7ny; Wed, 28 Sep 2022 20:02:29 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTPS id A2AFC403B8; Wed, 28 Sep 2022 20:02:28 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org A2AFC403B8 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 6B745C0033; Wed, 28 Sep 2022 20:02:28 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id BCA1EC002D for ; Wed, 28 Sep 2022 20:02:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 8970B60E6B for ; Wed, 28 Sep 2022 20:02:25 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 8970B60E6B Authentication-Results: smtp3.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=H7US+pfw X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id I4cWB3GA-KnL for ; Wed, 28 Sep 2022 20:02:22 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 931BB60E50 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by smtp3.osuosl.org (Postfix) with ESMTPS id 931BB60E50 for ; Wed, 28 Sep 2022 20:02:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664395341; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=d3cN46yR7NWOicCiy/yGPpGpvzjMsqsVRHSBsY1m+T4=; b=H7US+pfw09WVCMRJbil145gUdZBkjzlNZKOdHiq0hU8NoKek4g//cG16rrSn0UENkgyBWC exvGpE4uVqnVhvGpHs2WzHxb/nyK0QT+iTfe2O1DC4Lr/VRvKgg0yCq8lcvviRtiMaSl9N /3vqaa8a/ISdvU8px+v09cNrner43Tc= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-659-5xs5W_GKPYiDpfBB4C11Zg-1; Wed, 28 Sep 2022 16:02:20 -0400 X-MC-Unique: 5xs5W_GKPYiDpfBB4C11Zg-1 Received: by mail-wr1-f71.google.com with SMTP id r22-20020adfa156000000b0022cc3018fbaso1411697wrr.2 for ; Wed, 28 Sep 2022 13:02:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=d3cN46yR7NWOicCiy/yGPpGpvzjMsqsVRHSBsY1m+T4=; b=ssTXiiHHQmvjVr+zmu6ce+sKp3a7ZZu2W4PZGkUBLdLYwujyKl1N59fOCHVCED+zsu +e2U9EV4STCTa1Igc5kzhVNl+9VVQ1YLHN5b/G4wgZKogP9/7AsZWAgxx1PVAekbj6dT YjZi0iGVMaO037Mc8Wa8uM55HdcT5XFs2OpzG6K5HK6a8xgseIP9mPJDSIap1rn2Dyy/ tMysbzf5/aX0wL88gtZ94L3M71pqD+KyWOg5gw5nLS0R6E5AQwO47cYXQoPM2kJK5l9A TcImOfRBfpTVnbbhsI7u35AOj59+L8Qu0gGChBON6znjxGeJGlptsuZQfcBBLWPt5Npq J4Wg== X-Gm-Message-State: ACrzQf25AMPSiX42fTG0YuROGybkV/T8qZ9+ZVdYE5WRf2drAfKK424Z NTabNKKq0w3bDH1Ymf7JQvXyg5dPcPYB9JtvFbdK/Rp8QOGb1eEZmqzNOVTFipeZLdm93oCG5cA 8gxxbqS2OqwFII9mkFSKIcS2BbNoU3TwR6nOShDg66w== X-Received: by 2002:a5d:4903:0:b0:22c:c960:dd23 with SMTP id x3-20020a5d4903000000b0022cc960dd23mr3052899wrq.475.1664395337467; Wed, 28 Sep 2022 13:02:17 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6rEH2X/vqm2gUOiwMyg5FCm2mYadAC0QuRkERmGHmC+5pWEVfjq4D2qb3iApkApTXtLPurEQ== X-Received: by 2002:a5d:4903:0:b0:22c:c960:dd23 with SMTP id x3-20020a5d4903000000b0022cc960dd23mr3052879wrq.475.1664395337220; Wed, 28 Sep 2022 13:02:17 -0700 (PDT) Received: from redhat.com ([2.55.47.213]) by smtp.gmail.com with ESMTPSA id l7-20020a05600c4f0700b003b4c979e6bcsm2621685wmq.10.2022.09.28.13.02.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Sep 2022 13:02:16 -0700 (PDT) Date: Wed, 28 Sep 2022 16:02:12 -0400 From: "Michael S. Tsirkin" To: Stefano Garzarella Subject: Re: [PATCH] vhost/vsock: Use kvmalloc/kvfree for larger packets. Message-ID: <20220928160116-mutt-send-email-mst@kernel.org> References: <20220928064538.667678-1-uekawa@chromium.org> <20220928082823.wyxplop5wtpuurwo@sgarzare-redhat> <20220928052738-mutt-send-email-mst@kernel.org> <20220928151135.pvrlsylg6j3hzh74@sgarzare-redhat> MIME-Version: 1.0 In-Reply-To: <20220928151135.pvrlsylg6j3hzh74@sgarzare-redhat> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: Junichi Uekawa , kvm@vger.kernel.org, netdev@vger.kernel.org, Bobby Eshleman , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Eric Dumazet , Stefan Hajnoczi , Jakub Kicinski , Paolo Abeni , davem@davemloft.net X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Wed, Sep 28, 2022 at 05:11:35PM +0200, Stefano Garzarella wrote: > On Wed, Sep 28, 2022 at 05:31:58AM -0400, Michael S. Tsirkin wrote: > > On Wed, Sep 28, 2022 at 10:28:23AM +0200, Stefano Garzarella wrote: > > > On Wed, Sep 28, 2022 at 03:45:38PM +0900, Junichi Uekawa wrote: > > > > When copying a large file over sftp over vsock, data size is usually 32kB, > > > > and kmalloc seems to fail to try to allocate 32 32kB regions. > > > > > > > > Call Trace: > > > > [] dump_stack+0x97/0xdb > > > > [] warn_alloc_failed+0x10f/0x138 > > > > [] ? __alloc_pages_direct_compact+0x38/0xc8 > > > > [] __alloc_pages_nodemask+0x84c/0x90d > > > > [] alloc_kmem_pages+0x17/0x19 > > > > [] kmalloc_order_trace+0x2b/0xdb > > > > [] __kmalloc+0x177/0x1f7 > > > > [] ? copy_from_iter+0x8d/0x31d > > > > [] vhost_vsock_handle_tx_kick+0x1fa/0x301 [vhost_vsock] > > > > [] vhost_worker+0xf7/0x157 [vhost] > > > > [] kthread+0xfd/0x105 > > > > [] ? vhost_dev_set_owner+0x22e/0x22e [vhost] > > > > [] ? flush_kthread_worker+0xf3/0xf3 > > > > [] ret_from_fork+0x4e/0x80 > > > > [] ? flush_kthread_worker+0xf3/0xf3 > > > > > > > > Work around by doing kvmalloc instead. > > > > > > > > Signed-off-by: Junichi Uekawa > > > > My worry here is that this in more of a work around. > > It would be better to not allocate memory so aggressively: > > if we are so short on memory we should probably process > > packets one at a time. Is that very hard to implement? > > Currently the "virtio_vsock_pkt" is allocated in the "handle_kick" callback > of TX virtqueue. Then the packet is multiplexed on the right socket queue, > then the user space can de-queue it whenever they want. > > So maybe we can stop processing the virtqueue if we are short on memory, but > when can we restart the TX virtqueue processing? Assuming you added at least one buffer, the time to restart would be after that buffer has been used. > I think as long as the guest used only 4K buffers we had no problem, but now > that it can create larger buffers the host may not be able to allocate it > contiguously. Since there is no need to have them contiguous here, I think > this patch is okay. > > However, if we switch to sk_buff (as Bobby is already doing), maybe we don't > have this problem because I think there is some kind of pre-allocated pool. > > > > > > > > > > > --- > > > > > > > > drivers/vhost/vsock.c | 2 +- > > > > net/vmw_vsock/virtio_transport_common.c | 2 +- > > > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c > > > > index 368330417bde..5703775af129 100644 > > > > --- a/drivers/vhost/vsock.c > > > > +++ b/drivers/vhost/vsock.c > > > > @@ -393,7 +393,7 @@ vhost_vsock_alloc_pkt(struct vhost_virtqueue *vq, > > > > return NULL; > > > > } > > > > > > > > - pkt->buf = kmalloc(pkt->len, GFP_KERNEL); > > > > + pkt->buf = kvmalloc(pkt->len, GFP_KERNEL); > > > > if (!pkt->buf) { > > > > kfree(pkt); > > > > return NULL; > > > > diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c > > > > index ec2c2afbf0d0..3a12aee33e92 100644 > > > > --- a/net/vmw_vsock/virtio_transport_common.c > > > > +++ b/net/vmw_vsock/virtio_transport_common.c > > > > @@ -1342,7 +1342,7 @@ EXPORT_SYMBOL_GPL(virtio_transport_recv_pkt); > > > > > > > > void virtio_transport_free_pkt(struct virtio_vsock_pkt *pkt) > > > > { > > > > - kfree(pkt->buf); > > > > + kvfree(pkt->buf); > > > > > > virtio_transport_free_pkt() is used also in virtio_transport.c and > > > vsock_loopback.c where pkt->buf is allocated with kmalloc(), but IIUC > > > kvfree() can be used with that memory, so this should be fine. > > > > > > > kfree(pkt); > > > > } > > > > EXPORT_SYMBOL_GPL(virtio_transport_free_pkt); > > > > -- > > > > 2.37.3.998.g577e59143f-goog > > > > > > > > > > This issue should go away with the Bobby's work about introducing sk_buff > > > [1], but we can queue this for now. > > > > > > I'm not sure if we should do the same also in the virtio-vsock driver > > > (virtio_transport.c). Here in vhost-vsock the buf allocated is only used in > > > the host, while in the virtio-vsock driver the buffer is exposed to the > > > device emulated in the host, so it should be physically contiguous (if not, > > > maybe we need to adjust virtio_vsock_rx_fill()). > > > > More importantly it needs to support DMA API which IIUC kvmalloc > > memory does not. > > > > Right, good point! > > Thanks, > Stefano _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization