From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gavin Li <gavinl@nvidia.com>
Cc: virtio-dev@lists.oasis-open.org, sridhar.samudrala@intel.com,
jesse.brandeburg@intel.com,
virtualization@lists.linux-foundation.org,
stephen@networkplumber.org, loseweigh@gmail.com,
netdev@vger.kernel.org, kuba@kernel.org, davem@davemloft.net
Subject: Re: [virtio-dev] [PATCH v6 0/2] Improve virtio performance for 9k mtu
Date: Thu, 29 Sep 2022 03:01:03 -0400 [thread overview]
Message-ID: <20220929030022-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <68934c1a-6c75-f410-2c29-1a7edc97aeb9@nvidia.com>
On Thu, Sep 29, 2022 at 02:50:00PM +0800, Gavin Li wrote:
>
> On 9/14/2022 10:49 PM, Gavin Li wrote:
> > External email: Use caution opening links or attachments
> >
> >
> > This small series contains two patches that improves virtio netdevice
> > performance for 9K mtu when GRO/ guest TSO is disabled.
> >
> > Gavin Li (2):
> > virtio-net: introduce and use helper function for guest gso support
> > checks
> > ---
> > changelog:
> > v4->v5
> > - Addressed comments from Michael S. Tsirkin
> > - Remove unnecessary () in return clause
> > v1->v2
> > - Add new patch
> > ---
> > virtio-net: use mtu size as buffer length for big packets
> > ---
> > changelog:
> > v5->v6
> > - Addressed comments from Jason and Michael S. Tsirkin
> > - Remove wrong commit log description
> > - Rename virtnet_set_big_packets_fields with virtnet_set_big_packets
> > - Add more test results for different feature combinations
> > v4->v5
> > - Addressed comments from Michael S. Tsirkin
> > - Improve commit message
> > v3->v4
> > - Addressed comments from Si-Wei
> > - Rename big_packets_sg_num with big_packets_num_skbfrags
> > v2->v3
> > - Addressed comments from Si-Wei
> > - Simplify the condition check to enable the optimization
> > v1->v2
> > - Addressed comments from Jason, Michael, Si-Wei.
> > - Remove the flag of guest GSO support, set sg_num for big packets and
> > use it directly
> > - Recalculate sg_num for big packets in virtnet_set_guest_offloads
> > - Replace the round up algorithm with DIV_ROUND_UP
> > ---
> >
> > drivers/net/virtio_net.c | 48 ++++++++++++++++++++++++++--------------
> > 1 file changed, 32 insertions(+), 16 deletions(-)
> >
> > --
> > 2.31.1
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
> > For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
> Did you get a chance to pull these short series?
Not in net-next yet for some reason, I was hoping it
will get some testing here. I'll put it in my tree
for next for now so it gets tested. Thanks!
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
prev parent reply other threads:[~2022-09-29 7:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220914144911.56422-1-gavinl@nvidia.com>
[not found] ` <20220914144911.56422-2-gavinl@nvidia.com>
2022-09-22 1:39 ` [PATCH v6 1/2] virtio-net: introduce and use helper function for guest gso support checks Jason Wang
[not found] ` <20220914144911.56422-3-gavinl@nvidia.com>
2022-09-22 1:41 ` [PATCH v6 2/2] virtio-net: use mtu size as buffer length for big packets Jason Wang
2022-09-29 7:00 ` [PATCH v6 0/2] Improve virtio performance for 9k mtu Michael S. Tsirkin
[not found] ` <68934c1a-6c75-f410-2c29-1a7edc97aeb9@nvidia.com>
2022-09-29 7:01 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220929030022-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=davem@davemloft.net \
--cc=gavinl@nvidia.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=loseweigh@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sridhar.samudrala@intel.com \
--cc=stephen@networkplumber.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).