From: Christoph Hellwig <hch@lst.de>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: vincent.fu@samsung.com, vincent.whitchurch@axis.com,
baolin.wang@linux.alibaba.com, mst@redhat.com,
linux-remoteproc@vger.kernel.org, hoeppner@linux.ibm.com,
linux-nvme@lists.infradead.org,
virtualization@lists.linux-foundation.org, bhelgaas@google.com,
linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com,
agordeev@linux.ibm.com, jinpu.wang@ionos.com, hch@lst.de,
alyssa@rosenzweig.io, vigneshr@ti.com,
linux-s390@vger.kernel.org, sagi@grimberg.me,
linux-scsi@vger.kernel.org, richard@nod.at,
damien.lemoal@opensource.wdc.com, vaibhavgupta40@gmail.com,
joel@jms.id.au, shinichiro.kawasaki@wdc.com, idryomov@gmail.com,
jejb@linux.ibm.com, asahi@lists.linux.dev, ohad@wizery.com,
haris.iqbal@ionos.com, gor@linux.ibm.com, sven@svenpeter.dev,
hca@linux.ibm.com, john.garry@huawei.com, josef@toxicpanda.com,
efremov@linux.com, ming.lei@redhat.com,
linux-block@vger.kernel.org, nbd@other.debian.org,
christophe.jaillet@wanadoo.fr, sth@linux.ibm.com,
stefanha@redhat.com, kbusch@kernel.org,
ceph-devel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, bvanassche@acm.org,
axboe@kernel.dk, martin.petersen@oracle.com,
wsa+renesas@sang-engineering.com, johannes.thumshirn@wdc.com,
andersson@kernel.org, marcan@marcan.st,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
dongsheng.yang@easystack.cn, christoph.boehmwalder@linbit.com,
svens@linux.ibm.com, pbonzini@redhat.com
Subject: Re: [RFC PATCH 00/21] block: add and use init tagset helper
Date: Mon, 10 Oct 2022 09:55:04 +0200 [thread overview]
Message-ID: <20221010075504.GA21272@lst.de> (raw)
In-Reply-To: <Y0BvRaVO0iUVmHgB@bombadil.infradead.org>
On Fri, Oct 07, 2022 at 11:26:13AM -0700, Luis Chamberlain wrote:
> *If* there were commonalities at init and these could be broken up into
> common groups, each having their own set of calls, then we simplify and
> can abstract these. I say this without doing a complete review of the
> removals, but if there really isn't much of commonalities I tend to
> agree with Bart that open coding this is better.
The commonality is that there are various required or optional
fields to fill out. I actually have a WIP series to make the tag_set
dynamically allocated and refcounted to fix some long standing life time
issues. That creates a new alloc helper that will take a few mandatory
arguments and would heavily clash with this series.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
prev parent reply other threads:[~2022-10-10 7:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 3:22 [RFC PATCH 00/21] block: add and use init tagset helper Chaitanya Kulkarni via Virtualization
2022-10-05 3:22 ` [RFC PATCH 01/21] " Chaitanya Kulkarni via Virtualization
[not found] ` <6fee2d7a-7fd1-73ee-2911-87a4ed3e8769@opensource.wdc.com>
2022-10-05 9:47 ` Ulf Hansson
2022-10-05 16:54 ` Bart Van Assche
2022-10-05 3:22 ` [RFC PATCH 02/21] loop: use lib tagset init helper Chaitanya Kulkarni
2022-10-05 3:22 ` [RFC PATCH 03/21] nbd: " Chaitanya Kulkarni via Virtualization
2022-10-05 3:22 ` [RFC PATCH 04/21] rnbd: " Chaitanya Kulkarni via Virtualization
2022-10-05 3:22 ` [RFC PATCH 05/21] bsg-lib: " Chaitanya Kulkarni
2022-10-05 3:22 ` [RFC PATCH 06/21] rnbd-clt: " Chaitanya Kulkarni
2022-10-05 3:22 ` [RFC PATCH 07/21] virtio-blk: " Chaitanya Kulkarni via Virtualization
2022-10-05 3:22 ` [RFC PATCH 08/21] scsi: " Chaitanya Kulkarni via Virtualization
2022-10-05 3:22 ` [RFC PATCH 09/21] block: " Chaitanya Kulkarni
2022-10-05 3:22 ` [RFC PATCH 10/21] amiflop: " Chaitanya Kulkarni
2022-10-05 3:22 ` [RFC PATCH 11/21] floppy: " Chaitanya Kulkarni
2022-10-05 3:22 ` [RFC PATCH 12/21] mtip32xx: " Chaitanya Kulkarni
2022-10-05 3:22 ` [RFC PATCH 13/21] z3ram: " Chaitanya Kulkarni via Virtualization
2022-10-05 3:22 ` [RFC PATCH 14/21] scm_blk: " Chaitanya Kulkarni via Virtualization
2022-10-05 3:22 ` [RFC PATCH 15/21] ubi: " Chaitanya Kulkarni
2022-10-05 3:22 ` [RFC PATCH 16/21] mmc: core: " Chaitanya Kulkarni
2022-10-05 3:22 ` [RFC PATCH 17/21] dasd: " Chaitanya Kulkarni via Virtualization
2022-10-05 3:22 ` [RFC PATCH 18/21] nvme-core: use lib tagset init helper for I/O q Chaitanya Kulkarni via Virtualization
2022-10-05 3:22 ` [RFC PATCH 19/21] nvme-core: use lib tagset init helper for adminq Chaitanya Kulkarni
2022-10-05 3:22 ` [RFC PATCH 20/21] nvme-apple: use lib tagset init helper Chaitanya Kulkarni via Virtualization
2022-10-05 3:22 ` [RFC PATCH 21/21] nvme-pci: " Chaitanya Kulkarni
2022-10-07 18:26 ` [RFC PATCH 00/21] block: add and use init tagset helper Luis Chamberlain
2022-10-10 7:55 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221010075504.GA21272@lst.de \
--to=hch@lst.de \
--cc=agordeev@linux.ibm.com \
--cc=alyssa@rosenzweig.io \
--cc=andersson@kernel.org \
--cc=asahi@lists.linux.dev \
--cc=axboe@kernel.dk \
--cc=baolin.wang@linux.alibaba.com \
--cc=bhelgaas@google.com \
--cc=bvanassche@acm.org \
--cc=ceph-devel@vger.kernel.org \
--cc=christoph.boehmwalder@linbit.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=damien.lemoal@opensource.wdc.com \
--cc=dongsheng.yang@easystack.cn \
--cc=efremov@linux.com \
--cc=gor@linux.ibm.com \
--cc=haris.iqbal@ionos.com \
--cc=hca@linux.ibm.com \
--cc=hoeppner@linux.ibm.com \
--cc=idryomov@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=jinpu.wang@ionos.com \
--cc=joel@jms.id.au \
--cc=johannes.thumshirn@wdc.com \
--cc=john.garry@huawei.com \
--cc=josef@toxicpanda.com \
--cc=kbusch@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=martin.petersen@oracle.com \
--cc=mcgrof@kernel.org \
--cc=ming.lei@redhat.com \
--cc=miquel.raynal@bootlin.com \
--cc=mst@redhat.com \
--cc=nbd@other.debian.org \
--cc=ohad@wizery.com \
--cc=pbonzini@redhat.com \
--cc=richard@nod.at \
--cc=sagi@grimberg.me \
--cc=shinichiro.kawasaki@wdc.com \
--cc=stefanha@redhat.com \
--cc=sth@linux.ibm.com \
--cc=sven@svenpeter.dev \
--cc=svens@linux.ibm.com \
--cc=vaibhavgupta40@gmail.com \
--cc=vigneshr@ti.com \
--cc=vincent.fu@samsung.com \
--cc=vincent.whitchurch@axis.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).